From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 208ECC43460 for ; Tue, 13 Apr 2021 09:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0043E611F2 for ; Tue, 13 Apr 2021 09:22:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239156AbhDMJXF (ORCPT ); Tue, 13 Apr 2021 05:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbhDMJXC (ORCPT ); Tue, 13 Apr 2021 05:23:02 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1428C061574; Tue, 13 Apr 2021 02:22:42 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 12so26099774lfq.13; Tue, 13 Apr 2021 02:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FwfRq003k7c0sRHU/LeK71oNXIIg9f2Cbnxik0Fz0nQ=; b=sX9K/Ljtw95FMyxwNsVeoUIlNF84+/1r6bcvSO2rZa/nVv3pL8NFbCap12feHhWX6w Uwap89QRhz3qiiB+KT8l3PcB4khbA8iSdLl2EwFlhLAc3QzDlcbpnFqsa+xd/7jn9nnt vaydNMI+Pw15HYPTB7RvIcQ0HNSHwve/2fwxG6xPxHe24sIV0cCNDiRHYMXiBgkSAX25 TPu3zwBrZhJSCyPms4AxExcU9BOBE8aVf6GFFb0kN8FyTl3Q1n4CuNqER90h87T32psb WLK1eae0UejYFG21t8RQmGKlQXJoe25PnUAe8n7fogtci1wksP578IkXtPe9pecJrlY5 b1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=FwfRq003k7c0sRHU/LeK71oNXIIg9f2Cbnxik0Fz0nQ=; b=Ut5LiG9HSmapLxASegmDXM7Z6oVEA4aIQQ/dTshreFjuWiwP6KHzOEuTVcxtA9k6Mn a3nxIcWFVKP0dfbLBolvy6XvYn4m5u99wlFXEKk2zgTA/VD286/EY9BRZC+VgR06IQCL z8edKcGj6TlT2LuScy9UGFw3tE8JilVZ8rL77SqqKNQvOokmlyfSUVxmPSpkUNY5JNa8 OUwZCFQodbJecUAAfiAxQEdmEkeRcCRPT5TT21PbvmqxEqqOQ5Jh6mYEz3W9gfyeB85p NCogf3ec+sRSASI5peEsEQjsnZzRb3Y2Jiw+hwWPaEwB1qIfAxnm32elibD8REL9wS0t Atkw== X-Gm-Message-State: AOAM530A7tqbKk/B3EVblKKovwg4knn4niQDroMjFbZBuLVi3wV+amuB oq5mzbNgFEVtVBy+j7mDW8s= X-Google-Smtp-Source: ABdhPJzqi84a+Vb4568i24ACcssIFvRunMl+wbAN2BjDniH75FYoen4JMSMo3yHfFQQWWqVuj4QTHA== X-Received: by 2002:a05:6512:1324:: with SMTP id x36mr19139873lfu.189.1618305761247; Tue, 13 Apr 2021 02:22:41 -0700 (PDT) Received: from [192.168.1.100] ([178.176.76.152]) by smtp.gmail.com with ESMTPSA id u25sm3167643lfu.293.2021.04.13.02.22.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 02:22:40 -0700 (PDT) Subject: Re: [PATCH 07/12] usb: dwc2: Update enter clock gating when port is suspended To: Artur Petrosyan , Felipe Balbi , Greg Kroah-Hartman , Minas Harutyunyan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: John Youn References: <9ed1da9780cddf995841cc5867f195024f5a16d9.1618297800.git.Arthur.Petrosyan@synopsys.com> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: <2dc3798a-6a89-b363-aade-e127decfdf20@gmail.com> Date: Tue, 13 Apr 2021 12:22:35 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <9ed1da9780cddf995841cc5867f195024f5a16d9.1618297800.git.Arthur.Petrosyan@synopsys.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 13.04.2021 10:17, Artur Petrosyan wrote: > Updates the implementation of entering clock gating mode > when core receives port suspend. > Instead of setting the required bit fields of the registers > inline, called the "dwc2_host_enter_clock_gating()" function. > > Signed-off-by: Artur Petrosyan > --- > drivers/usb/dwc2/hcd.c | 19 ++++--------------- > 1 file changed, 4 insertions(+), 15 deletions(-) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > index 27f030d5de54..e1225fe6c61a 100644 > --- a/drivers/usb/dwc2/hcd.c > +++ b/drivers/usb/dwc2/hcd.c [...] > @@ -3323,22 +3322,12 @@ int dwc2_port_suspend(struct dwc2_hsotg *hsotg, u16 windex) > break; > case DWC2_POWER_DOWN_PARAM_HIBERNATION: > case DWC2_POWER_DOWN_PARAM_NONE: > - default: > - hprt0 = dwc2_read_hprt0(hsotg); > - hprt0 |= HPRT0_SUSP; > - dwc2_writel(hsotg, hprt0, HPRT0); > - hsotg->bus_suspended = true; > /* > - * If power_down is supported, Phy clock will be suspended > - * after registers are backuped. > + * If not hibernation nor partial power down are supported, s/not/neither/? MBR, Sergei