From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84387C433DB for ; Mon, 18 Jan 2021 17:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49C6222C9E for ; Mon, 18 Jan 2021 17:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436506AbhARRV4 (ORCPT ); Mon, 18 Jan 2021 12:21:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407155AbhARRVs (ORCPT ); Mon, 18 Jan 2021 12:21:48 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70D4DC061573 for ; Mon, 18 Jan 2021 09:21:06 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id g12so24744591ejf.8 for ; Mon, 18 Jan 2021 09:21:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ruKXD8bGqkoghUlX4mzLfQbwoSM0QEpIg9OIDZO9Mdo=; b=f5a2tENvm/u4bFMrMFNXAaNES+GmCodM6qlXaeJTCIca4bsDMi6F94bqs0oWhStzK6 SrQzF6iWuNKVoum76255DMFHCK4NhHbFWoIiV43nAhKldc2KxNWh2P7G24pm3jh/EIkP lezu2qBQsTqdlIl0iknd9Ljr5+M3UOsUBBuuUMIyIvTkBMXjXl5zgHsXoFAQRxemkznY XXER8lOWJb81Pu95woHfz53uj48UmE+Ua/6EHF6WXciyKNVi5/Do3WJxd4CITxjFH9L8 lAjwPcop4tjfxAuqzn768qghPphHAz0+VjxOQCWcezaSXkHOucUF9mjLMkO5EtXTM2qB 1MJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ruKXD8bGqkoghUlX4mzLfQbwoSM0QEpIg9OIDZO9Mdo=; b=YHRLGdZnFESUF16iHlXnQIOO9KtG8ybC5lvsRO0TU6ReMjV+tAXs30xWp1mIRo0EJv QKDz4M393lIiZEjhm562nvqGo9sQnkPmG/PoJ+HZgz57g7uP7U9JbG5tprUB5tzt/vCY nC321sJwDnISba1gjw+WoZXKnwX0spY4+eQvP6mNn0/1oWThNCWZanARN17q/1m7CSJd lDxzwLWU7sFleNxx7G8jiY3sewXmjAlC938DDpstF5qEg+yvaJ27vje3PMA6Ek+V7sEd 8z+orEM8cF7TY7CuvKgjPA43SnWQ7XaLj9x/Wo/QZ2H3VNS0MIihcc774BZFnXXrarce 5/+A== X-Gm-Message-State: AOAM533Pu6mrNmurkys5oXcH70y4trVFnr9Zyzx6hU1SJKichA8vhhG6 qE6CidUtEbN8ncVBlpbYq4Ejmg== X-Google-Smtp-Source: ABdhPJwdgFF5BqmP+9q7+iU/tK8YvN5uva5O2cPfysLnAR8lqJ2SGsX7RryocyV2Q8pOax/ERzd8Iw== X-Received: by 2002:a17:906:97c5:: with SMTP id ef5mr460921ejb.347.1610990465193; Mon, 18 Jan 2021 09:21:05 -0800 (PST) Received: from [192.168.0.3] ([84.238.208.220]) by smtp.googlemail.com with ESMTPSA id c7sm6401239edv.70.2021.01.18.09.21.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 09:21:04 -0800 (PST) Subject: Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct To: AngeloGioacchino Del Regno , stanimir.varbanov@linaro.org Cc: agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, phone-devel@vger.kernel.org References: <20210115185252.333562-1-angelogioacchino.delregno@somainline.org> <20210115185252.333562-2-angelogioacchino.delregno@somainline.org> From: Stanimir Varbanov Message-ID: <2dc8a95f-110f-526f-18a8-6393e508c3a6@linaro.org> Date: Mon, 18 Jan 2021 19:21:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210115185252.333562-2-angelogioacchino.delregno@somainline.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Angelo, Thanks for the patch! On 1/15/21 8:52 PM, AngeloGioacchino Del Regno wrote: > Add the SDM660 DT compatible and its resource structure, also > including support for the Venus pmdomains, in order to support > the Venus block in SDM630, SDM636, SDM660 and SDA variants. > > This SoC features Venus 4.4 (HFI3XX), with one vcodec used for > both encoding and decoding, switched on through two GDSCs. > The core clock for this Venus chip is powered by the RPM VDD_CX > power domain. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/media/platform/qcom/venus/core.c | 66 ++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index bdd293faaad0..83ca86a63241 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -565,6 +565,71 @@ static const struct venus_resources sdm845_res_v2 = { > .fwname = "qcom/venus-5.2/venus.mdt", > }; > > +static const struct freq_tbl sdm660_freq_table[] = { > + { 0, 518400000 }, > + { 0, 441600000 }, > + { 0, 404000000 }, > + { 0, 320000000 }, > + { 0, 269330000 }, > + { 0, 133330000 }, > +}; > + > +static const struct reg_val sdm660_reg_preset[] = { > + { 0x80010, 0x001f001f }, > + { 0x80018, 0x00000156 }, > + { 0x8001C, 0x00000156 }, > +}; > + > +static const struct bw_tbl sdm660_bw_table_enc[] = { > + { 979200, 1044000, 0, 2446336, 0 }, /* 4k UHD @ 30 */ > + { 864000, 887000, 0, 2108416, 0 }, /* 720p @ 240 */ > + { 489600, 666000, 0, 1207296, 0 }, /* 1080p @ 60 */ > + { 432000, 578000, 0, 1058816, 0 }, /* 720p @ 120 */ > + { 244800, 346000, 0, 616448, 0 }, /* 1080p @ 30 */ > + { 216000, 293000, 0, 534528, 0 }, /* 720p @ 60 */ > + { 108000, 151000, 0, 271360, 0 }, /* 720p @ 30 */ > +}; > + > +static const struct bw_tbl sdm660_bw_table_dec[] = { > + { 979200, 2365000, 0, 1892000, 0 }, /* 4k UHD @ 30 */ > + { 864000, 1978000, 0, 1554000, 0 }, /* 720p @ 240 */ > + { 489600, 1133000, 0, 895000, 0 }, /* 1080p @ 60 */ > + { 432000, 994000, 0, 781000, 0 }, /* 720p @ 120 */ > + { 244800, 580000, 0, 460000, 0 }, /* 1080p @ 30 */ > + { 216000, 501000, 0, 301000, 0 }, /* 720p @ 60 */ > + { 108000, 255000, 0, 202000, 0 }, /* 720p @ 30 */ > +}; > + > +static const struct venus_resources sdm660_res = { > + .freq_tbl = sdm660_freq_table, > + .freq_tbl_size = ARRAY_SIZE(sdm660_freq_table), > + .reg_tbl = sdm660_reg_preset, > + .reg_tbl_size = ARRAY_SIZE(sdm660_reg_preset), > + .bw_tbl_enc = sdm660_bw_table_enc, > + .bw_tbl_enc_size = ARRAY_SIZE(sdm660_bw_table_enc), > + .bw_tbl_dec = sdm660_bw_table_dec, > + .bw_tbl_dec_size = ARRAY_SIZE(sdm660_bw_table_dec), > + .clks = {"core", "iface", "bus_throttle", "bus" }, > + .clks_num = 4, > + .vcodec0_clks = { "vcodec0_core" }, > + .vcodec_clks_num = 1, > + .vcodec_pmdomains = { "venus", "vcodec0" }, > + .vcodec_pmdomains_num = 2, > + .opp_pmdomain = (const char *[]) { "cx", NULL }, > + .vcodec_num = 1, > + .max_load = 1036800, > + .hfi_version = HFI_VERSION_3XX, > + .vmem_id = VIDC_RESOURCE_NONE, > + .vmem_size = 0, > + .vmem_addr = 0, > + .cp_start = 0, > + .cp_size = 0x79000000, > + .cp_nonpixel_start = 0x1000000, > + .cp_nonpixel_size = 0x28000000, > + .dma_mask = 0xd9000000 - 1, > + .fwname = "qcom/venus-4.4/venus.mdt", Did you try venus-4.2 firmware from linux-firmware tree [1] ? > +}; > + > static const struct freq_tbl sc7180_freq_table[] = { > { 0, 500000000 }, > { 0, 434000000 }, > @@ -613,6 +678,7 @@ static const struct venus_resources sc7180_res = { > static const struct of_device_id venus_dt_match[] = { > { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, }, > { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, }, > + { .compatible = "qcom,sdm660-venus", .data = &sdm660_res, }, > { .compatible = "qcom,sdm845-venus", .data = &sdm845_res, }, > { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, }, > { .compatible = "qcom,sc7180-venus", .data = &sc7180_res, }, > Reviewed-by: Stanimir Varbanov -- regards, Stan [1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qcom/venus-4.2