From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4B4C433E0 for ; Tue, 5 Jan 2021 08:48:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0222422525 for ; Tue, 5 Jan 2021 08:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0222422525 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.61770.108788 (Exim 4.92) (envelope-from ) id 1kwi0y-00067E-6D; Tue, 05 Jan 2021 08:48:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 61770.108788; Tue, 05 Jan 2021 08:48:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwi0y-000677-2v; Tue, 05 Jan 2021 08:48:28 +0000 Received: by outflank-mailman (input) for mailman id 61770; Tue, 05 Jan 2021 08:48:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwi0w-000672-Fr for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 08:48:26 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 955a668f-4b49-444d-952b-4697e8c1832d; Tue, 05 Jan 2021 08:48:25 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B4A8EAA35; Tue, 5 Jan 2021 08:48:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 955a668f-4b49-444d-952b-4697e8c1832d X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1609836504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xarE/LCUwZEXoHdCE6nfZsxDvZic3GYU2ohQIF6Lg4=; b=LJtgDIo8UPk4BWpXjDynhAR7tfmkZ/6mZhzZ7KT8NwGifn0muxR5KSwFb44aZ+5FvRtHUu cFJW4geHZHhCGsTb22lstSxJa/YAUhGJmrd+zB4FfTwkonLtiSKcf/ohbpJnO7CFoAvdOs bDGoA4w6/JYctKjifRLx9Psqih/Joy0= Subject: Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only To: Oleksandr Tyshchenko Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Andrew Cooper References: From: Jan Beulich Message-ID: <2dcbe286-4112-e4b3-dc12-9691154365b3@suse.com> Date: Tue, 5 Jan 2021 09:48:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04.01.2021 17:57, Oleksandr Tyshchenko wrote: > Hello all. > > [Sorry for the possible format issues] > > On Tue, Dec 22, 2020 at 12:41 PM Andrew Cooper > wrote: > >> On 21/12/2020 08:10, Jan Beulich wrote: >>> On 17.12.2020 20:18, Andrew Cooper wrote: >>>> On 15/12/2020 16:26, Jan Beulich wrote: >>>>> This is together with its only caller, xenmem_add_to_physmap_one(). >>>> I can't parse this sentence. Perhaps "... as is it's only caller," as a >>>> follow-on from the subject sentence. >>>> >>>>> Move >>>>> the latter next to p2m_add_foreign(), allowing this one to become >> static >>>>> at the same time. >>>>> >>>>> Signed-off-by: Jan Beulich >>>> Acked-by: Andrew Cooper >>> So I had to ask Andrew to revert this (I was already at home when >>> noticing the breakage), as it turned out to break the shim build. >>> The problem is that xenmem_add_to_physmap() is non-static and >>> hence can't be eliminated altogether by the compiler when !HVM. >>> We could make the function conditionally static >>> "#if !defined(CONFIG_X86) && !defined(CONFIG_HVM)", but this >>> looks uglier to me than this extra hunk: >>> >>> --- unstable.orig/xen/common/memory.c >>> +++ unstable/xen/common/memory.c >>> @@ -788,7 +788,11 @@ int xenmem_add_to_physmap(struct domain >>> union add_to_physmap_extra extra = {}; >>> struct page_info *pages[16]; >>> >>> - ASSERT(paging_mode_translate(d)); >>> + if ( !paging_mode_translate(d) ) >>> + { >>> + ASSERT_UNREACHABLE(); >>> + return -EACCES; >>> + } >>> >>> if ( xatp->space == XENMAPSPACE_gmfn_foreign ) >>> extra.foreign_domid = DOMID_INVALID; >>> >>> Andrew, please let me know whether your ack stands with this (or >>> said alternative) added, or whether you'd prefer me to re-post. >> >> Yeah, this is probably neater than the ifdefary. My ack stands. >> >> ~Andrew >> > > I might miss something or did incorrect tests, but ... > ... trying to build current staging > (7ba2ab495be54f608cb47440e1497b2795bd301a) for x86 (with # CONFIG_HVM is > not set) I got the following: > > /media/b/build/build/tmp/work/x86_64-xt-linux/domd-image-weston/1.0-r0/repo/build/tmp/work/aarch64-poky-linux/xen/4.14.0+gitAUTOINC+2c6e5a8ceb-r0/git/xen/common/memory.c:941: > undefined reference to `xenmem_add_to_physmap_one' > /media/b/build/build/tmp/work/x86_64-xt-linux/domd-image-weston/1.0-r0/repo/build/tmp/work/aarch64-poky-linux/xen/4.14.0+gitAUTOINC+2c6e5a8ceb-r0/git/xen/common/memory.c:941:(.text+0x1e391): > relocation truncated to fit: R_X86_64_PC32 against undefined symbol > `xenmem_add_to_physmap_one' > ld: > /media/b/build/build/tmp/work/x86_64-xt-linux/domd-image-weston/1.0-r0/repo/build/tmp/work/aarch64-poky-linux/xen/4.14.0+gitAUTOINC+2c6e5a8ceb-r0/git/xen/.xen-syms.0: > hidden symbol `xenmem_add_to_physmap_one' isn't defined > ld: final link failed: Bad value > > It is worth mentioning that I do not use pvshim_defconfig (I disable HVM > support via menuconfig manually before building). The specific .config may matter. The specific compiler version may also matter. Things work fine for me, both for the shim config and a custom !HVM one, with gcc10. Jan