All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Igor Romanov <igor.romanov@oktetlabs.ru>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/2] net/sfc: fix an Rx queue double release possibility
Date: Fri, 21 Sep 2018 15:53:59 +0100	[thread overview]
Message-ID: <2de70a03-3d72-e73b-e2e1-d03faa282fef@intel.com> (raw)
In-Reply-To: <1536910296-17455-1-git-send-email-arybchenko@solarflare.com>

On 9/14/2018 8:31 AM, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
> 
> There are two function that call sfc_rx_qfini():
> sfc_rx_fini_queues() and sfc_rx_queue_release(). But only
> sfc_rx_queue_release() sets rx_queues pointer of the device data to NULL.
> It may lead to the scenario in which a queue is destroyed by
> sfc_rx_fini_queues() and after the queue is attempted to be destroyed again
> by sfc_rx_queue_release().
> 
> Move NULL assignment to sfc_rx_qfini().
> 
> Fixes: ce35b05c635e ("net/sfc: implement Rx queue setup release operations")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Series applied to dpdk-next-net/master, thanks.

      parent reply	other threads:[~2018-09-21 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14  7:31 [PATCH 1/2] net/sfc: fix an Rx queue double release possibility Andrew Rybchenko
2018-09-14  7:31 ` [PATCH 2/2] net/sfc: fix a Tx " Andrew Rybchenko
2018-09-21 14:53 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2de70a03-3d72-e73b-e2e1-d03faa282fef@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=igor.romanov@oktetlabs.ru \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.