All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Levitsky <mlevitsk@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Sean Christopherson <seanjc@google.com>
Subject: Re: Another nice lockdep print in nested SVM code
Date: Tue, 26 Apr 2022 19:56:02 +0300	[thread overview]
Message-ID: <2dea96f99ee7b3b47702292a699d9ac7af1afaaf.camel@redhat.com> (raw)
In-Reply-To: <7a627c97-0fb1-cb35-8623-7893e228852c@redhat.com>

On Tue, 2022-04-26 at 18:47 +0200, Paolo Bonzini wrote:
> On 4/26/22 18:43, Maxim Levitsky wrote:
> > Actually for vmrun, that #GP is I think sort of correct now - that is
> > what AMD cpus do on 'invalid physical address', but for VM exit, we
> > just need to have the vmcb mapped instead of mapping it again -
> > injecting #GP at that point which will go to the nested guest is just
> > wrong.
> 
> Yeah, in that case I can't think of anything better than triple fault.
> 
> Paolo
> 
But do you think that it would be better to keep the vmcb12 page mapped/pinned while doing the nested run
which will both solve the problem of calling sleeping function and allow us
to remove the case of map failing on vm exit?

If I remember correctly, vmx does something like that.

Best regards,
	Maxim Levitsky


  reply	other threads:[~2022-04-26 16:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 16:39 Another nice lockdep print in nested SVM code Maxim Levitsky
2022-04-26 16:43 ` Maxim Levitsky
2022-04-26 16:47   ` Paolo Bonzini
2022-04-26 16:56     ` Maxim Levitsky [this message]
2022-04-26 17:05       ` Paolo Bonzini
2022-04-26 17:08         ` Maxim Levitsky
2022-04-26 17:29 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dea96f99ee7b3b47702292a699d9ac7af1afaaf.camel@redhat.com \
    --to=mlevitsk@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.