From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Leon Romanovsky <leon@kernel.org>,
Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "jiri@mellanox.com" <jiri@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"ram.amrani@cavium.com" <ram.amrani@cavium.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"ogerlitz@mellanox.com" <ogerlitz@mellanox.com>,
"hch@lst.de" <hch@lst.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jgunthorpe@obsidianresearch.com"
<jgunthorpe@obsidianresearch.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"dledford@redhat.com" <dledford@redhat.com>,
"ariela@mellanox.com" <ariela@mellanox.com>
Subject: Re: [RFC iproute2 0/8] RDMA tool
Date: Thu, 4 May 2017 15:26:13 -0400 [thread overview]
Message-ID: <2dee6cde-0406-b101-0fe6-c1f6de7c1b1a@intel.com> (raw)
In-Reply-To: <20170504184531.GE22833@mtr-leonro.local>
On 05/04/2017 02:45 PM, Leon Romanovsky wrote:
> On Thu, May 04, 2017 at 06:30:27PM +0000, Bart Van Assche wrote:
>> On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
>>> On Thu, May 04, 2017 at 06:10:54PM +0000, Bart Van Assche wrote:
>>>> On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:
>>>>> Following our discussion both in mailing list [1] and at the LPC 2016 [2],
>>>>> we would like to propose this RDMA tool to be part of iproute2 package
>>>>> and finally improve this situation.
>>>>
>>>> Hello Leon,
>>>>
>>>> Although I really appreciate your work: can you clarify why you would like to
>>>> add *RDMA* functionality to an *IP routing* tool? I haven't found any motivation
>>>> for adding RDMA functionality to iproute2 in [1].
>>>
>>> We are planning to reuse the same infrastructure provided by iproute2,
>>> like netlink parsing, access to distributions, same CLI and same standards.
>>>
>>> Right now, RDMA is already tightened to netdev: iWARP, RoCE, IPoIB, HFI-VNIC.
>>> Many drivers (mlx, qed, i40, cxgb) are sharing code between net and
>>> RDMA.
>>>
>>> I do expect that iproute2 will be installed on every machine with any
>>> type of connection, including IB and OPA.
>>>
>>> So I think that it is enough to be part of that suite and don't invent
>>> our own for one specific tool.
>>
>> Hello Leon,
>>
>> Sorry but to me that sounds like a weak argument for including RDMA functionality
>> in iproute2. There is already a library for communication over netlink sockets,
>> namely libnl. Is there functionality that is in iproute2 but not in libnl and
>> that is needed for the new tool? If so, have you considered to create a new
>> library for that functionality?
>
> It is not hard to create new tool, the hardest part is to ensure that it is
> part of the distributions. Did you count how many months we are trying to
> add rdma-core to debian?
I do agree that it is a strange pairing and am not really a fan. However
at the end of the day it's just a name for a repo/package. If the
iproute folks are fine to include rdma in their repo/package, great we
can leverage their code for CLI and other common stuff.
Now if the interface was something like "ip -FlagForRdma ..." I would
object to that, but the interface is "rdma ... " so from users
perspective it's different tools. They don't need to care that it was
sourced from a common git repo.
Just as an aside this already works a bit with OPA:
$ ./rdma link
1/1: hfi1_0/1: ifname NONE cap_mask 0x00410022 lid 0x1 lid_mask_count 0
link_layer InfiniBand
phys_state 5: LinkUp rate 100 Gb/sec (4X EDR) sm_lid 0x1 sm_sl
0 state 4: ACTIVE
Leon I'll get you more feedback and testing, I've just been really
bogged down this week, sorry.
-Denny
next prev parent reply other threads:[~2017-05-04 19:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 18:02 [RFC iproute2 0/8] RDMA tool Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 2/8] rdma: Add dev object Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 3/8] rdma: Add link object Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 5/8] rdma: Add memory object Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 6/8] rdma: add stubs for future objects Leon Romanovsky
[not found] ` <20170504180216.7665-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-05-04 18:02 ` [RFC iproute2 1/8] rdma: Add basic infrastructure for RDMA tool Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 4/8] rdma: Add IPoIB object Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 V1 7/8] man: rdma.8: Document objects and commands Leon Romanovsky
2017-05-04 18:02 ` [RFC iproute2 8/8] rdma: Add link capability parsing Leon Romanovsky
2017-05-05 6:54 ` [RFC iproute2 0/8] RDMA tool Jiri Benc
2017-05-05 13:17 ` Leon Romanovsky
[not found] ` <20170505131754.GH22833-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-06 10:48 ` Jiri Pirko
2017-05-07 6:33 ` Leon Romanovsky
2017-05-07 21:02 ` Stephen Hemminger
2017-05-08 13:04 ` Knut Omang
2017-05-04 18:10 ` Bart Van Assche
2017-05-04 18:25 ` Leon Romanovsky
[not found] ` <20170504182542.GD22833-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-04 18:30 ` Bart Van Assche
[not found] ` <1493922625.2692.8.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-04 18:45 ` Leon Romanovsky
2017-05-04 19:26 ` Dennis Dalessandro [this message]
[not found] ` <2dee6cde-0406-b101-0fe6-c1f6de7c1b1a-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-04 19:42 ` Leon Romanovsky
[not found] ` <20170504194242.GF22833-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-08 15:55 ` Dennis Dalessandro
[not found] ` <b82f5d3d-f198-3410-af85-85befc14a2ec-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-09 7:03 ` Leon Romanovsky
2017-05-04 20:45 ` Doug Ledford
[not found] ` <1493930758.3041.231.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-05 0:05 ` Stephen Hemminger
2017-05-05 18:38 ` Bart Van Assche
2017-05-06 10:40 ` Jiri Pirko
2017-05-06 14:40 ` Bart Van Assche
2017-05-07 6:14 ` Leon Romanovsky
2017-05-07 10:20 ` Jiri Pirko
[not found] ` <20170507102046.GA1889-6KJVSR23iU488b5SBfVpbw@public.gmane.org>
2017-05-08 15:19 ` Bart Van Assche
[not found] ` <1494256767.2591.3.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-08 15:33 ` Stephen Hemminger
2017-05-08 16:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dee6cde-0406-b101-0fe6-c1f6de7c1b1a@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=ariela@mellanox.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jiri@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=ram.amrani@cavium.com \
--cc=sagi@grimberg.me \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.