From: Ivan Vecera <ivecera@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [patch net-next 3/5] mlxsw: Move PCI id table definitions into driver modules
Date: Thu, 27 Oct 2016 16:39:23 +0200 [thread overview]
Message-ID: <2df03fe8-8f7a-f6af-6894-54e07f61a962@redhat.com> (raw)
In-Reply-To: <1477573981-26546-4-git-send-email-jiri@resnulli.us>
Dne 27.10.2016 v 15:12 Jiri Pirko napsal(a):
> From: Jiri Pirko <jiri@mellanox.com>
>
> So far, mlxsw_pci.ko is the module that registers PCI table for all
> drivers (spectrum and switchx2). That is problematic for example with
> dracut. Since mlxsw_spectrum.ko and mlxsw_switchx2.ko are loaded
> dynamically from within mlxsw_core.ko, dracut does not have track of
> them and avoids them from being included in initramfs.
>
> So make this in an ordinary way and define the PCI tables in individual
> driver modules, so it can be properly loaded and included in dracut
> initramfs image. As a side effect, this patch could remove no longer
> necessary driver "kind" strings which were used to link PCI ids with
> individual mlxsw drivers.
>
> Suggested-by: Ivan Vecera <ivecera@redhat.com>
> Tested-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Thanks Jiri.
Acked-by: Ivan Vecera <ivecera@redhat.com>
next prev parent reply other threads:[~2016-10-27 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 13:12 [patch net-next 0/5] mlxsw: small driver update Jiri Pirko
2016-10-27 13:12 ` [patch net-next 1/5] mlxsw: spectrum: Remove extra whitespace Jiri Pirko
2016-10-27 13:12 ` [patch net-next 2/5] mlxsw: pci: Rename header with HW definitions Jiri Pirko
2016-10-27 13:12 ` [patch net-next 3/5] mlxsw: Move PCI id table definitions into driver modules Jiri Pirko
2016-10-27 14:39 ` Ivan Vecera [this message]
2016-10-27 13:13 ` [patch net-next 4/5] mlxsw: spectrum: Set physical device for port netdevice Jiri Pirko
2016-10-27 13:13 ` [patch net-next 5/5] mlxsw: switchx2: " Jiri Pirko
2016-10-28 17:46 ` [patch net-next 0/5] mlxsw: small driver update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df03fe8-8f7a-f6af-6894-54e07f61a962@redhat.com \
--to=ivecera@redhat.com \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.