From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848A2C433EF for ; Wed, 13 Oct 2021 05:26:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A49C560E8B for ; Wed, 13 Oct 2021 05:26:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A49C560E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4BC7A82BC4; Wed, 13 Oct 2021 07:26:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cjo+Z+Jt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C6B6882ECC; Wed, 13 Oct 2021 07:26:25 +0200 (CEST) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B7482827C5 for ; Wed, 13 Oct 2021 07:26:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=a.heider@gmail.com Received: by mail-wr1-x42e.google.com with SMTP id e12so4135850wra.4 for ; Tue, 12 Oct 2021 22:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=AE6JlbcrNJrp7JFG3UZcaAYniTcSKAeiubid+PHrDEY=; b=cjo+Z+JtK5IMf9HFFh1j7r5Wd+N9LhDSpcL4tKKFJIy0jPfRgz34ZeHSsTNZ5x1II5 Pe4gTZfjTZ+XEH328eOS674zBIS5P63ETGgdmjJ9wmmVOdAOaW0IBkn5uCOXsbJ62gm4 q9I3mL+qkopINXzX+eWsKKnxMINRNAm7Ke69Zmc0+IHoQyvyAA5oM7OOk3LU9grzTyJl 4yyYNUmRCVrqMcYmYN8y05yQv+JQp2LbflqtZqIrWsiHC2k8sTfuuots0eXJEcBWfdls yh5IE8nJ5zSuwrCfYGhgiD2SvE+4IbJZ/kURRIKJbJWTABKZJfFvvSsD1/de2NEm5gx/ 9ZEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=AE6JlbcrNJrp7JFG3UZcaAYniTcSKAeiubid+PHrDEY=; b=tXQSs/wIrdHd24YNiEVw1U8OhBYV6X8iYPcr3rREA+PlKgfN7E7BkXgF7OyCSmr8iU rAPoG7Odel4Q5Ph6MheFposOE+UeHCEH5wDhiFWE+q51Jzzp6ExdOqWAOLSKf/1w77Jd tlabA9MEtUNvNwECMIotYTcDgGoFcQiV4ZHb+ftPBQWWf0DWO4XMXAwprlKtYoDfvObI z4S3kuW+Iwye0TrWX759HE8O1vVFweaGtbK6ZGdOoMgfJMOssj3tEoF8iUcDhZjgULwa YvBQlUaN/nBWSBku0ideNDFFAAcZfa+en3RrFEpOAl0VLUQ/PsV+2yiXT1+sJottEtYJ WZcw== X-Gm-Message-State: AOAM532NmT55rbUjohgV/8Z7YtNI94B+oXeFUSNDA9w/b3I8yACgdM1z 8q3pvx5dDkNaTiEkKwCtGFk= X-Google-Smtp-Source: ABdhPJwxLaK4Cy4Nhuu6N8L5nK966S874j9RFpnjp5yXfE/Ak+XMpG3u6X+LcQPoBLRUkYfjY7ibow== X-Received: by 2002:adf:ca09:: with SMTP id o9mr35819533wrh.303.1634102782261; Tue, 12 Oct 2021 22:26:22 -0700 (PDT) Received: from [192.168.0.40] (a89-182-220-21.net-htp.de. [89.182.220.21]) by smtp.gmail.com with ESMTPSA id t11sm12073984wrz.65.2021.10.12.22.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Oct 2021 22:26:21 -0700 (PDT) Message-ID: <2df95136-ae22-8cd4-a2d2-43a5af2f0090@gmail.com> Date: Wed, 13 Oct 2021 07:26:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: Broken build with disabling OpenSSL crypto Content-Language: en-US To: "Alex G." , =?UTF-8?Q?Jernej_=c5=a0krabec?= , u-boot@lists.denx.de References: <18564205.Z0HQFNUZ9R@kista> <544c0c86-ca3f-036e-2523-3f973105410a@gmail.com> From: Andre Heider In-Reply-To: <544c0c86-ca3f-036e-2523-3f973105410a@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On 07/10/2021 00:05, Alex G. wrote: > Hi Jernej, > > On 10/6/21 4:27 PM, Jernej Škrabec wrote: >> Hi everyone! >> >> Commit cb9faa6f98ae ("tools: Use a single target-independent config to >> enable >> OpenSSL") recently introduced option to disable usage of OpenSSL via >> CONFIG_TOOLS_LIBCRYPTO. However, just a bit later, another commit >> b4f3cc2c42d9 >> ("tools: kwbimage: Do not hide usage of secure header under >> CONFIG_ARMADA_38X") made U-Boot tools hard dependent on OpenSSL. That >> totally >> defeats the purpose of first commit. I suggest that it gets reverted. >> >> I would like disable OpenSSL for my usage, since it gives me troubles >> when >> cross-compiling U-Boot inside LibreELEC build system. It's not needed >> for our >> case anyway. >> >> Best regards, >> > > Can you please give the following diff a try, and if it works for you, > submit as patch? it looks like this is still required, as this fixes it for me too ;) Thanks, Andre > > Alex > > diff --git a/tools/Makefile b/tools/Makefile > index 4a86321f64..7f72ff9645 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -96,7 +96,8 @@ AES_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := $(addprefix > lib/aes/, \ > >  # Cryptographic helpers that depend on openssl/libcrypto >  LIBCRYPTO_OBJS-$(CONFIG_TOOLS_LIBCRYPTO) := $(addprefix lib/, \ > -                    fdt-libcrypto.o) > +                    fdt-libcrypto.o) \ > +                    kwbimage.o > >  ROCKCHIP_OBS = lib/rc4.o rkcommon.o rkimage.o rksd.o rkspi.o > > @@ -117,7 +118,6 @@ dumpimage-mkimage-objs := aisimage.o \ >              imximage.o \ >              imx8image.o \ >              imx8mimage.o \ > -            kwbimage.o \ >              lib/md5.o \ >              lpc32xximage.o \ >              mxsimage.o \ > @@ -169,8 +169,8 @@ HOST_EXTRACFLAGS    += > -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff >  HOST_EXTRACFLAGS    += -DCONFIG_FIT_CIPHER >  endif > > -# MXSImage needs LibSSL > -ifneq > ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_TOOLS_LIBCRYPTO),) > > +# MXSImage needs LibSSL <- Nope! Read the frogging notice at the top > +ifneq ($(CONFIG_TOOLS_LIBCRYPTO),) >  HOSTCFLAGS_kwbimage.o += \ >      $(shell pkg-config --cflags libssl libcrypto 2> /dev/null || echo "") >  HOSTLDLIBS_mkimage += \