All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: "Guilherme G. Piccoli" <guilherme@gpiccoli.net>,
	Michal Hocko <mhocko@kernel.org>, Qian Cai <cai@lca.pw>
Cc: Guilherme Piccoli <gpiccoli@canonical.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Jay Vosburgh <jay.vosburgh@canonical.com>,
	"Guilherme G. Piccoli" <kernel@gpiccoli.net>
Subject: Re: [PATCH] hugetlb: Add nohugepages parameter to prevent hugepages creation
Date: Fri, 18 Oct 2019 11:29:40 -0700	[thread overview]
Message-ID: <2df9c30d-b1e0-648e-93ba-85c78fbcbd0e@oracle.com> (raw)
In-Reply-To: <2d593c95-3c69-8f50-17ff-223bd607caf1@gpiccoli.net>

On 10/15/19 7:09 AM, Guilherme G. Piccoli wrote:
> 
> 
> On 10/15/19 11:05 AM, Michal Hocko wrote:
>> On Tue 15-10-19 10:58:36, Guilherme G. Piccoli wrote:
>>> On 10/15/19 9:18 AM, Michal Hocko wrote:
>>>> I do agree with Qian Cai here. Kdump kernel requires a very tailored
>>>> environment considering it is running in a very restricted
>>>> configuration. The hugetlb pre-allocation sounds like a tooling problem
>>>> and should be fixed at that layer.
>>>>
>>>
>>> Hi Michal, thanks for your response. Can you suggest me a current way of
>>> preventing hugepages for being created, using userspace? The goal for this
>>> patch is exactly this, introduce such a way.
>>
>> Simply restrict the environment to not allocate any hugepages? Kdump
>> already controls the kernel command line and it also starts only a very
>> minimal subset of services. So who is allocating those hugepages?
>> sysctls should be already excluded by default as Qian mentioned.
>>
> 
> 
> OK, thanks Michal and Qian, I'll try to make things work from kdump perspective. The trick part is exactly preventing the sysctl to get applied heh
> 

Please do let us know if this can be done in tooling.

I am not opposed to the approach taken in your v2 patch as it essentially
uses the hugepages_supported() functionality that exists today.  However,
it seems that other distros have ways around this issue.  As such, I would
prefer if the issue was addressed in the tooling.
-- 
Mike Kravetz

  reply	other threads:[~2019-10-18 18:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 22:39 [PATCH] hugetlb: Add nohugepages parameter to prevent hugepages creation Guilherme G. Piccoli
2019-10-11 23:35 ` Qian Cai
2019-10-11 23:41   ` Guilherme Piccoli
2019-10-11 23:41     ` Guilherme Piccoli
2019-10-11 23:52     ` Qian Cai
2019-10-12  0:41       ` Guilherme Piccoli
2019-10-12  0:41         ` Guilherme Piccoli
2019-10-15 12:18         ` Michal Hocko
2019-10-15 13:58           ` Guilherme G. Piccoli
2019-10-15 14:05             ` Michal Hocko
2019-10-15 14:09               ` Guilherme G. Piccoli
2019-10-18 18:29                 ` Mike Kravetz [this message]
2019-10-24 16:21                   ` Guilherme G. Piccoli
2019-10-14 18:25 ` Mike Kravetz
2019-10-15  4:50   ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2df9c30d-b1e0-648e-93ba-85c78fbcbd0e@oracle.com \
    --to=mike.kravetz@oracle.com \
    --cc=cai@lca.pw \
    --cc=gpiccoli@canonical.com \
    --cc=guilherme@gpiccoli.net \
    --cc=jay.vosburgh@canonical.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.