From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8F21C3DA7A for ; Thu, 5 Jan 2023 07:25:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A54DE85589; Thu, 5 Jan 2023 08:25:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="FhoULS3J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 757B285590; Thu, 5 Jan 2023 08:25:54 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2052.outbound.protection.outlook.com [40.107.223.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 407A785574 for ; Thu, 5 Jan 2023 08:25:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NI867yX/bRyMLdPOiPdeCG+ltFFLQmYoLWHiAq7HRlzmMLTR8syUFIAMFUKzXlC/DAbPKo7P9cm8Xt63UdjZesc4vG+BTPkr9dPsNhXkAsZ8+GUVUrQkP+/ulK9bMzUEqPtZYjvsvgN4rhxBVpm+5PUKNZ8g97LSk1SljnoRjQXT5MZeM1859p5Z2n/B26dtxg2oaJEDlTDRIoFEbzX1E5Z4T65q5ZAE15ldIVXXsvy7oCswr0qf6mDLUUKEq67Vqx4cd52Hy4mlUDyZdg/LvbumY905/W3yGb0sCIYoY5N7KQaQUpMKmgs4B4iuDSwoUokey2T5eCtliQcivHGokA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AI3yNoypNAxXseGWnWp0SLrl2SzGGKkhJMrSA1YxwTw=; b=R27Glk0brOsA8yZrjmwZPv9VM+LdIvSyZ0ZpkaHcAH8Lx4NVDhP6W/ixRGaVlrlSidaRwVzgMMcDW62jjNEFKGK7yX5gg65VRoPf7oZjWVp0gEn0q3LmuFBcjTSAg8hUFKcbH0r48h73QnQC6X6hA8RJGqA/JyouRUXaYWG0swA+YCQs0CwoyK7M36ma/1blrs7PTkhRlV3m/gVSjGRObblG9ajIWObNTlHgUMSN8fuyyewTgwl1REdqCvlnf65WxX82HuswWWaC0Gk44Mwmmu3g5bbjdvgqlFtdVWtH0a2ZQw7/ynKKB9dGjTYT5WC/E8KHiFuuYT0ZMjG3r5kR6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gigadevice.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AI3yNoypNAxXseGWnWp0SLrl2SzGGKkhJMrSA1YxwTw=; b=FhoULS3Jgyq43i6VvqUytnQdsi7jYD3itY9+VpgYHjPwUhDxi+dmQduVkOhjtbawMCQDNawFZ2jeP3VoannhvTIWCvSXoeI8lhPkipGpAKQWWxL34Ipsm0ffp1bCHM+xYaI4ZVCjhAKSB4FGIIPKFugKulbmQNxpxmCQb5ibSuc= Received: from MW2PR16CA0039.namprd16.prod.outlook.com (2603:10b6:907:1::16) by SJ1PR12MB6316.namprd12.prod.outlook.com (2603:10b6:a03:455::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:25:47 +0000 Received: from CO1NAM11FT092.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::9e) by MW2PR16CA0039.outlook.office365.com (2603:10b6:907:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.14 via Frontend Transport; Thu, 5 Jan 2023 07:25:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT092.mail.protection.outlook.com (10.13.175.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.14 via Frontend Transport; Thu, 5 Jan 2023 07:25:46 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 5 Jan 2023 01:25:37 -0600 Message-ID: <2e072563-2151-6f68-4359-7eeb6eaa3ec1@amd.com> Date: Thu, 5 Jan 2023 08:25:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/4] Enable gigadevice and add new part #s To: Vlim , Michal Simek , "u-boot@lists.denx.de" CC: "vigneshr@ti.com" , "jagan@amarulasolutions.com" , "michal.simek@xilinx.com" , "vikhyat.goyal@amd.com" , "ashok.reddy.soma@amd.com" References: <20221219224818.6801-1-vlim@gigadevice.com> <3d2a5e8b-0c35-b516-374c-61aabb326f5a@monstr.eu> Content-Language: en-US From: Michal Simek In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT092:EE_|SJ1PR12MB6316:EE_ X-MS-Office365-Filtering-Correlation-Id: 25210a4b-0d93-4038-3484-08daeeee105c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CfsEo81Pf+7q8f2GFM5Ly0GX6Nm0xvE3PyKTDPX9f3uocvYRfbt87GZBhmBNiGl5S11Z2O27b+e//X3D3haNoJyEgomm/mBNDDUL48EoHT0gClqh6Mcauj9eykUX1EZucWpJQCAEPD+l7RQqZ9VPDoBHW7zzs94CrqMlSFw5Y/Kv6u9U9MTAPfHHRilNbmYfj+vU0j5N7ZiTFejdhoy1VBipz4XG1EHUhH45sAIl4PJCOKGNhgKDg8WGOBGT6/2ftMPeqr+NSCEb//W0V1RMpC/qh3DLzbuXpS1xbhMYEp0Yg6WBCi1wTUqk1Xf/Qi9bm/fLsHRR+PLCwu0ldWn1fAtQAlITbo5E1II/lvy5qNzHfcd/WZ1RjHCFRGncP/NJYxuExGYIqKveesYeR4OYa+Vlf5n5lbCX78NXRLFATqIvzEE4XsOriV95EcHp24PfMq9tkgufQ/dVFmcnK9WQOTFXHhsFlCGgjXW5HknK4Rot4vyuQIfIvVsdwFVb8O/tUTqTXoByu3s3yQhQngQ/nZaAXrcbAtd9HbwsV7SqNN8BKDWSXcW+o+ZQrJwzyOSInOrBRMfIuZ8WWXJlWsVwT9R6mnMrRjZpaqcasJBk8CFBPMe8OvM4O1smFLIV3hylIxM5+Fns8rDIZmWDh79RxVNp5S/ozMPuuSHPo/cZdZS5tHmmUuMuciqC5ZRX6dpT3zXoZzWUIOi0JLCP03iz+vOZX6lq1UILbA3oOaL8Ui8T1jDg9BkyP1n2fNzByOqEcAfGQFekWe1qqWOT6abW1lXlwBsAkzzDG5wDW0J72zU= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(8936002)(316002)(41300700001)(5660300002)(4326008)(8676002)(70586007)(70206006)(16576012)(54906003)(31686004)(110136005)(44832011)(2906002)(53546011)(966005)(478600001)(6666004)(2616005)(16526019)(86362001)(47076005)(426003)(40480700001)(31696002)(336012)(186003)(26005)(83380400001)(36860700001)(36756003)(81166007)(356005)(82740400003)(40460700003)(82310400005)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:25:46.8733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25210a4b-0d93-4038-3484-08daeeee105c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT092.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6316 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/4/23 19:50, Vlim wrote: > Thanks, Michal, > > Thanks for the feedback. > > I do have some questions regarding the following comments, > > Second. When I run this > > for i in `ls configs/xilinx_*`; do NAME=`basename $i`; echo $NAME; make $NAME; > make savedefconfig; cp defconfig $i; done > > I see that locations your added entries are not correct. > > Third b4 am -g is showing that base is not upstream version. > Please use next branch as base. Simply base your patches on upstream git repository not u-boot-xlnx. Use https://source.denx.de/u-boot/u-boot master or next branch. (next branch is preferred now for upcoming one week or so). > > Regarding the location of the entry, I believe you want me to add the entry in > the alphabetical order? Not really. I want to you follow Kconfig layout which is what make savedefconfig && cp defconfig configs/ is for. > Also, for top posting, I am still not fully understood. > It seems like I should not include the previous email. > Let me try it here see if it is correct. Just put reaction below things you want to comment as I do here. Thanks, Michal