From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005AbdJSQdd (ORCPT ); Thu, 19 Oct 2017 12:33:33 -0400 Received: from mga06.intel.com ([134.134.136.31]:20887 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391AbdJSQdb (ORCPT ); Thu, 19 Oct 2017 12:33:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,402,1503385200"; d="scan'208";a="162445187" Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: sst: remove redundant variable dma_dev_name To: Colin King , Jie Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171019123352.30294-1-colin.king@canonical.com> From: Pierre-Louis Bossart Message-ID: <2e0d8b0e-a778-a2c5-45a2-dbef62d40a8b@linux.intel.com> Date: Thu, 19 Oct 2017 11:33:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171019123352.30294-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2017 07:33 AM, Colin King wrote: > From: Colin Ian King > > The pointer dma_dev_name is assigned but never read, it is redundant > and can therefore be removed. > > Cleans up clang warning: > sound/soc/intel/common/sst-firmware.c:288:3: warning: Value stored to > 'dma_dev_name' is never read > > Signed-off-by: Colin Ian King Indeed this has been unused since at least 2015... FWIW Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/common/sst-firmware.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c > index a086c35f91bb..79a9fdf94d38 100644 > --- a/sound/soc/intel/common/sst-firmware.c > +++ b/sound/soc/intel/common/sst-firmware.c > @@ -274,7 +274,6 @@ int sst_dma_new(struct sst_dsp *sst) > struct sst_pdata *sst_pdata = sst->pdata; > struct sst_dma *dma; > struct resource mem; > - const char *dma_dev_name; > int ret = 0; > > if (sst->pdata->resindex_dma_base == -1) > @@ -285,7 +284,6 @@ int sst_dma_new(struct sst_dsp *sst) > * is attached to the ADSP IP. */ > switch (sst->pdata->dma_engine) { > case SST_DMA_TYPE_DW: > - dma_dev_name = "dw_dmac"; > break; > default: > dev_err(sst->dev, "error: invalid DMA engine %d\n", From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Date: Thu, 19 Oct 2017 16:33:29 +0000 Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: sst: remove redundant variable dma_dev_name Message-Id: <2e0d8b0e-a778-a2c5-45a2-dbef62d40a8b@linux.intel.com> List-Id: References: <20171019123352.30294-1-colin.king@canonical.com> In-Reply-To: <20171019123352.30294-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Jie Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 10/19/2017 07:33 AM, Colin King wrote: > From: Colin Ian King > > The pointer dma_dev_name is assigned but never read, it is redundant > and can therefore be removed. > > Cleans up clang warning: > sound/soc/intel/common/sst-firmware.c:288:3: warning: Value stored to > 'dma_dev_name' is never read > > Signed-off-by: Colin Ian King Indeed this has been unused since at least 2015... FWIW Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/common/sst-firmware.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c > index a086c35f91bb..79a9fdf94d38 100644 > --- a/sound/soc/intel/common/sst-firmware.c > +++ b/sound/soc/intel/common/sst-firmware.c > @@ -274,7 +274,6 @@ int sst_dma_new(struct sst_dsp *sst) > struct sst_pdata *sst_pdata = sst->pdata; > struct sst_dma *dma; > struct resource mem; > - const char *dma_dev_name; > int ret = 0; > > if (sst->pdata->resindex_dma_base = -1) > @@ -285,7 +284,6 @@ int sst_dma_new(struct sst_dsp *sst) > * is attached to the ADSP IP. */ > switch (sst->pdata->dma_engine) { > case SST_DMA_TYPE_DW: > - dma_dev_name = "dw_dmac"; > break; > default: > dev_err(sst->dev, "error: invalid DMA engine %d\n",