From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alex G." Subject: Re: [RFC PATCH v3 3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" Date: Wed, 2 May 2018 14:29:40 -0500 Message-ID: <2e1b1d18-08b5-fa85-be7b-ab29ac2195b3@gmail.com> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180425203957.18224-1-mr.nuke.me@gmail.com> <20180425203957.18224-4-mr.nuke.me@gmail.com> <20180426112057.GB15009@pd.tnic> <20180502191029.hcvf56xbdna7oi4k@devuan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180502191029.hcvf56xbdna7oi4k@devuan> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek , Borislav Petkov Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-kernel@vger.kernel.org, devel@acpica.org List-Id: linux-acpi@vger.kernel.org On 05/02/2018 02:10 PM, Pavel Machek wrote: > On Thu 2018-04-26 13:20:57, Borislav Petkov wrote: >> On Wed, Apr 25, 2018 at 03:39:51PM -0500, Alexandru Gagniuc wrote: >>> There seems to be a culture amongst BIOS teams to want to crash the >>> OS when an error can't be handled in firmware. Marking GHES errors as >>> "fatal" is a very common way to do this. >>> >>> However, a number of errors reported by GHES may be fatal in the sense >>> a device or link is lost, but are not fatal to the system. When there >>> is a disagreement with firmware about the handleability of an error, >>> print a warning message. > > >>> + >>> + if ((sev >= GHES_SEV_PANIC) && (ghes_actual_severity(ghes) < sev)) { >>> + pr_warn("FIRMWARE BUG: Firmware sent fatal error that we were able to correct"); >>> + pr_warn("BROKEN FIRMWARE: Complain to your hardware vendor"); >> >> Pasting the same comment from last time since you missed it: >> >> "No, I don't want any of that crap issuing stuff in dmesg and then people >> opening bugs and running around and trying to replace hardware. > > We want to see warnings. Maybe they can be toned done. We even have > dedicated distros for firmware testing. I'm told that had we had this warning when the r740 BIOS was in development, we would have solved a lot of the issues that I'm currently working on. That would, in turn, have exposed bigger issues, and we would have had a platform to fix and test those bigger issues. Hardware vendors who test on linux might be scratching their heads at this error, though they tend to figure out what they're doing wrong, and fix it. One argument against was "expensive support calls", on which I call BS. The firmware resources are expensive, but those are there whether or not the customers call to complain. Alex >> Good mailing practices for 400: avoid top-posting and trim the reply. > > Good mailing practices -- limit use of four letter words on public lists. Then can't show word 'four'. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v3,3/3] acpi: apei: Warn when GHES marks correctable errors as "fatal" From: Alexandru Gagniuc Message-Id: <2e1b1d18-08b5-fa85-be7b-ab29ac2195b3@gmail.com> Date: Wed, 2 May 2018 14:29:40 -0500 To: Pavel Machek , Borislav Petkov Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-kernel@vger.kernel.org, devel@acpica.org List-ID: T24gMDUvMDIvMjAxOCAwMjoxMCBQTSwgUGF2ZWwgTWFjaGVrIHdyb3RlOgo+IE9uIFRodSAyMDE4 LTA0LTI2IDEzOjIwOjU3LCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6Cj4+IE9uIFdlZCwgQXByIDI1 LCAyMDE4IGF0IDAzOjM5OjUxUE0gLTA1MDAsIEFsZXhhbmRydSBHYWduaXVjIHdyb3RlOgo+Pj4g VGhlcmUgc2VlbXMgdG8gYmUgYSBjdWx0dXJlIGFtb25nc3QgQklPUyB0ZWFtcyB0byB3YW50IHRv IGNyYXNoIHRoZQo+Pj4gT1Mgd2hlbiBhbiBlcnJvciBjYW4ndCBiZSBoYW5kbGVkIGluIGZpcm13 YXJlLiBNYXJraW5nIEdIRVMgZXJyb3JzIGFzCj4+PiAiZmF0YWwiIGlzIGEgdmVyeSBjb21tb24g d2F5IHRvIGRvIHRoaXMuCj4+Pgo+Pj4gSG93ZXZlciwgYSBudW1iZXIgb2YgZXJyb3JzIHJlcG9y dGVkIGJ5IEdIRVMgbWF5IGJlIGZhdGFsIGluIHRoZSBzZW5zZQo+Pj4gYSBkZXZpY2Ugb3IgbGlu ayBpcyBsb3N0LCBidXQgYXJlIG5vdCBmYXRhbCB0byB0aGUgc3lzdGVtLiBXaGVuIHRoZXJlCj4+ PiBpcyBhIGRpc2FncmVlbWVudCB3aXRoIGZpcm13YXJlIGFib3V0IHRoZSBoYW5kbGVhYmlsaXR5 IG9mIGFuIGVycm9yLAo+Pj4gcHJpbnQgYSB3YXJuaW5nIG1lc3NhZ2UuCj4gCj4gCj4+PiArCj4+ PiArCWlmICgoc2V2ID49IEdIRVNfU0VWX1BBTklDKSAmJiAoZ2hlc19hY3R1YWxfc2V2ZXJpdHko Z2hlcykgPCBzZXYpKSB7Cj4+PiArCQlwcl93YXJuKCJGSVJNV0FSRSBCVUc6IEZpcm13YXJlIHNl bnQgZmF0YWwgZXJyb3IgdGhhdCB3ZSB3ZXJlIGFibGUgdG8gY29ycmVjdCIpOwo+Pj4gKwkJcHJf d2FybigiQlJPS0VOIEZJUk1XQVJFOiBDb21wbGFpbiB0byB5b3VyIGhhcmR3YXJlIHZlbmRvciIp Owo+Pgo+PiBQYXN0aW5nIHRoZSBzYW1lIGNvbW1lbnQgZnJvbSBsYXN0IHRpbWUgc2luY2UgeW91 IG1pc3NlZCBpdDoKPj4KPj4gIk5vLCBJIGRvbid0IHdhbnQgYW55IG9mIHRoYXQgY3JhcCBpc3N1 aW5nIHN0dWZmIGluIGRtZXNnIGFuZCB0aGVuIHBlb3BsZQo+PiBvcGVuaW5nIGJ1Z3MgYW5kIHJ1 bm5pbmcgYXJvdW5kIGFuZCB0cnlpbmcgdG8gcmVwbGFjZSBoYXJkd2FyZS4KPiAKPiBXZSB3YW50 IHRvIHNlZSB3YXJuaW5ncy4gTWF5YmUgdGhleSBjYW4gYmUgdG9uZWQgZG9uZS4gV2UgZXZlbiBo YXZlCj4gZGVkaWNhdGVkIGRpc3Ryb3MgZm9yIGZpcm13YXJlIHRlc3RpbmcuCgpJJ20gdG9sZCB0 aGF0IGhhZCB3ZSBoYWQgdGhpcyB3YXJuaW5nIHdoZW4gdGhlIHI3NDAgQklPUyB3YXMgaW4KZGV2 ZWxvcG1lbnQsIHdlIHdvdWxkIGhhdmUgc29sdmVkIGEgbG90IG9mIHRoZSBpc3N1ZXMgdGhhdCBJ J20gY3VycmVudGx5Cndvcmtpbmcgb24uIFRoYXQgd291bGQsIGluIHR1cm4sIGhhdmUgZXhwb3Nl ZCBiaWdnZXIgaXNzdWVzLCBhbmQgd2UKd291bGQgaGF2ZSBoYWQgYSBwbGF0Zm9ybSB0byBmaXgg YW5kIHRlc3QgdGhvc2UgYmlnZ2VyIGlzc3Vlcy4KCkhhcmR3YXJlIHZlbmRvcnMgd2hvIHRlc3Qg b24gbGludXggbWlnaHQgYmUgc2NyYXRjaGluZyB0aGVpciBoZWFkcyBhdAp0aGlzIGVycm9yLCB0 aG91Z2ggdGhleSB0ZW5kIHRvIGZpZ3VyZSBvdXQgd2hhdCB0aGV5J3JlIGRvaW5nIHdyb25nLCBh bmQKZml4IGl0LgoKT25lIGFyZ3VtZW50IGFnYWluc3Qgd2FzICJleHBlbnNpdmUgc3VwcG9ydCBj YWxscyIsIG9uIHdoaWNoIEkgY2FsbCBCUy4KVGhlIGZpcm13YXJlIHJlc291cmNlcyBhcmUgZXhw ZW5zaXZlLCBidXQgdGhvc2UgYXJlIHRoZXJlIHdoZXRoZXIgb3Igbm90CnRoZSBjdXN0b21lcnMg Y2FsbCB0byBjb21wbGFpbi4KCkFsZXgKCj4+IEdvb2QgbWFpbGluZyBwcmFjdGljZXMgZm9yIDQw MDogYXZvaWQgdG9wLXBvc3RpbmcgYW5kIHRyaW0gdGhlIHJlcGx5Lgo+IAo+IEdvb2QgbWFpbGlu ZyBwcmFjdGljZXMgLS0gbGltaXQgdXNlIG9mIGZvdXIgbGV0dGVyIHdvcmRzIG9uIHB1YmxpYyBs aXN0cy4KClRoZW4gY2FuJ3Qgc2hvdyB3b3JkICdmb3VyJy4KLS0tClRvIHVuc3Vic2NyaWJlIGZy b20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1lZGFjIiBpbgp0 aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1h am9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0 bWwK