From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cb4Mr-0000lT-6o for qemu-devel@nongnu.org; Tue, 07 Feb 2017 06:55:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cb4Mo-0003xf-63 for qemu-devel@nongnu.org; Tue, 07 Feb 2017 06:55:29 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51652 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cb4Mo-0003x7-0l for qemu-devel@nongnu.org; Tue, 07 Feb 2017 06:55:26 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v17BrlGK018772 for ; Tue, 7 Feb 2017 06:55:24 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 28f8ncwft6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 07 Feb 2017 06:55:23 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Feb 2017 11:55:21 -0000 References: <1484727757-41240-1-git-send-email-arei.gonglei@huawei.com> <1484727757-41240-2-git-send-email-arei.gonglei@huawei.com> <20170203103316.GA29200@stefanha-x1.localdomain> <33183CC9F5247A488A2544077AF19020DA1AED04@DGGEMA505-MBX.china.huawei.com> <20170206154625.GB32590@stefanha-x1.localdomain> <20170206201814-mutt-send-email-mst@kernel.org> From: Halil Pasic Date: Tue, 7 Feb 2017 12:55:12 +0100 MIME-Version: 1.0 In-Reply-To: <20170206201814-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: <2e20c38c-8b30-0b85-7282-b9a52e1593ab@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Stefan Hajnoczi Cc: "Huangweidong (C)" , Stefan Hajnoczi , "qemu-devel@nongnu.org" , "john.griffin@intel.com" , "Zhoujian (jay)" , "Varun.Sethi@freescale.com" , "denglingli@chinamobile.com" , "arei.gonglei@hotmail.com" , "virtio-dev@lists.oasis-open.org" , "agraf@suse.de" , "Gonglei (Arei)" , "nmorey@kalray.eu" , longpeng , "vincent.jardin@6wind.com" , "xin.zeng@intel.com" , "Ola.Liljedahl@arm.com" , "liang.j.ma@intel.com" , Luonengjun , "cornelia.huck@de.ibm.com" , Jani Kokkonen , "brian.a.keating@intel.com" , "claudio.fontana@huawei.com" , "mike.caraman@nxp.com" , "Wubin (H)" On 02/06/2017 07:19 PM, Michael S. Tsirkin wrote: > On Mon, Feb 06, 2017 at 03:46:25PM +0000, Stefan Hajnoczi wrote: >> On Mon, Feb 06, 2017 at 01:48:09AM +0000, Gonglei (Arei) wrote: >>>>> +\item The device MUST set \field{max_size} to show the maximum size of >>>> crypto request the device supports. >>>> >>>> In bytes? >>>> >>>>> +\item The device MUST set \field{max_cipher_key_len} to show the >>>> maximum length of cipher key if the device supports CIPHER service. >>>> >>>> In bits or bytes? >>>> >>>>> +\item The device MUST set \field{max_auth_key_len} to show the maximum >>>> length of authenticated key if the device supports MAC service. >>>> >>>> In bits or bytes? >>>> >>> >>> All lengths in virtio crypto spec are bytes. >> >> Please move this before the first length field is defined: >> >> +\begin{note} >> +The basic unit of all data length the byte. >> +\end{note} > > And I'd rewrite as > > All data length fields specify the length in bytes. I clearly prefer this to the 'basic unit' formulation. We could also do something like "Unless explicitly stated otherwise all lengths and sizes are in bytes." but I'm quite happy with your formulation too. Regards, Halil > >> >> It should be at the beginning of the spec. > > >