From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA28C64E90 for ; Tue, 1 Dec 2020 16:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 789FA208FE for ; Tue, 1 Dec 2020 16:53:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="evi8aFNo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390815AbgLAQxY (ORCPT ); Tue, 1 Dec 2020 11:53:24 -0500 Received: from a2.mail.mailgun.net ([198.61.254.61]:18493 "EHLO a2.mail.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388131AbgLAQxX (ORCPT ); Tue, 1 Dec 2020 11:53:23 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606841582; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=vHVerjrHrtjQ+JfG4LASvM1TDWXfkcH4kB6Bb8hWyRY=; b=evi8aFNooIUFx5XGkXSe9/qYotNP6s/C+7BXy9N2eb5DySijeAxgIe8ZAqtOAhTHITqSY+nh DnFqB3w1cLTKkjInEhvrWoAws5tO5i9UgUimwkcRuBgXQl6bB866g5phrxrKTIhSytCRPv2X DbzDEa8N+pU3r1WDfbxdoKwuN8o= X-Mailgun-Sending-Ip: 198.61.254.61 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-west-2.postgun.com with SMTP id 5fc673912ef3e1355f457469 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 01 Dec 2020 16:47:13 GMT Sender: asutoshd=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8EA92C43460; Tue, 1 Dec 2020 16:47:13 +0000 (UTC) Received: from [192.168.8.168] (cpe-70-95-149-85.san.res.rr.com [70.95.149.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id 574F9C433ED; Tue, 1 Dec 2020 16:47:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 574F9C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v3 1/2] scsi: ufs: Refactor ufshcd_setup_clocks() to remove skip_ref_clk To: Can Guo Cc: nguyenb@codeaurora.org, hongwus@codeaurora.org, ziqichen@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , Bean Huo , Stanley Chu , Tomas Winkler , Bart Van Assche , Satya Tangirala , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" References: <1606356063-38380-1-git-send-email-cang@codeaurora.org> <1606356063-38380-2-git-send-email-cang@codeaurora.org> <81ac4e5b5974cd7a21f18bf4e74213e9@codeaurora.org> From: "Asutosh Das (asd)" Message-ID: <2e27f15a-988a-fb08-9c51-913a542b7399@codeaurora.org> Date: Tue, 1 Dec 2020 08:47:09 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <81ac4e5b5974cd7a21f18bf4e74213e9@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2020 7:11 PM, Can Guo wrote: > On 2020-12-01 07:01, Asutosh Das (asd) wrote: >> On 11/25/2020 6:01 PM, Can Guo wrote: >>> Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep >>> a flag >>> in struct ufs_clk_info to tell whether a clock can be disabled or not >>> while >>> the link is active. >>> >>> Reviewed-by: Hongwu Su >>> Reviewed-by: Bean Huo >>> Reviewed-by: Stanley Chu >>> Signed-off-by: Can Guo >>> --- >>>   drivers/scsi/ufs/ufshcd-pltfrm.c |  2 ++ >>>   drivers/scsi/ufs/ufshcd.c        | 29 +++++++++-------------------- >>>   drivers/scsi/ufs/ufshcd.h        |  3 +++ >>>   3 files changed, 14 insertions(+), 20 deletions(-) >>> >>> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c >>> b/drivers/scsi/ufs/ufshcd-pltfrm.c >>> index 3db0af6..873ef14 100644 >>> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c >>> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c >>> @@ -92,6 +92,8 @@ static int ufshcd_parse_clock_info(struct ufs_hba >>> *hba) >>>           clki->min_freq = clkfreq[i]; >>>           clki->max_freq = clkfreq[i+1]; >>>           clki->name = kstrdup(name, GFP_KERNEL); >>> +        if (!strcmp(name, "ref_clk")) >>> +            clki->keep_link_active = true; >>>           dev_dbg(dev, "%s: min %u max %u name %s\n", "freq-table-hz", >>>                   clki->min_freq, clki->max_freq, clki->name); >>>           list_add_tail(&clki->list, &hba->clk_list_head); >>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >>> index a7857f6..44254c9 100644 >>> --- a/drivers/scsi/ufs/ufshcd.c >>> +++ b/drivers/scsi/ufs/ufshcd.c >>> @@ -221,8 +221,6 @@ static int ufshcd_eh_host_reset_handler(struct >>> scsi_cmnd *cmd); >>>   static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag); >>>   static void ufshcd_hba_exit(struct ufs_hba *hba); >>>   static int ufshcd_probe_hba(struct ufs_hba *hba, bool async); >>> -static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, >>> -                 bool skip_ref_clk); >>>   static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on); >>>   static int ufshcd_uic_hibern8_enter(struct ufs_hba *hba); >>>   static inline void ufshcd_add_delay_before_dme_cmd(struct ufs_hba >>> *hba); >>> @@ -1707,11 +1705,7 @@ static void ufshcd_gate_work(struct >>> work_struct *work) >>>         ufshcd_disable_irq(hba); >>>   -    if (!ufshcd_is_link_active(hba)) >>> -        ufshcd_setup_clocks(hba, false); >>> -    else >>> -        /* If link is active, device ref_clk can't be switched off */ >>> -        __ufshcd_setup_clocks(hba, false, true); >>> +    ufshcd_setup_clocks(hba, false); >>>         /* >>>        * In case you are here to cancel this work the gating state >>> @@ -7990,8 +7984,7 @@ static int ufshcd_init_hba_vreg(struct ufs_hba >>> *hba) >>>       return 0; >>>   } >>>   -static int __ufshcd_setup_clocks(struct ufs_hba *hba, bool on, >>> -                    bool skip_ref_clk) >>> +static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on) >>>   { >>>       int ret = 0; >>>       struct ufs_clk_info *clki; >>> @@ -8009,7 +8002,12 @@ static int __ufshcd_setup_clocks(struct >>> ufs_hba *hba, bool on, >>>         list_for_each_entry(clki, head, list) { >>>           if (!IS_ERR_OR_NULL(clki->clk)) { >>> -            if (skip_ref_clk && !strcmp(clki->name, "ref_clk")) >>> +            /* >>> +             * Don't disable clocks which are needed >>> +             * to keep the link active. >>> +             */ >>> +            if (ufshcd_is_link_active(hba) && >>> +                clki->keep_link_active) >>>                   continue; >>>                 clk_state_changed = on ^ clki->enabled; >>> @@ -8054,11 +8052,6 @@ static int __ufshcd_setup_clocks(struct >>> ufs_hba *hba, bool on, >>>       return ret; >>>   } >>>   -static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on) >>> -{ >>> -    return  __ufshcd_setup_clocks(hba, on, false); >>> -} >>> - >>>   static int ufshcd_init_clocks(struct ufs_hba *hba) >>>   { >>>       int ret = 0; >>> @@ -8577,11 +8570,7 @@ static int ufshcd_suspend(struct ufs_hba *hba, >>> enum ufs_pm_op pm_op) >>>        */ >>>       ufshcd_disable_irq(hba); >>>   -    if (!ufshcd_is_link_active(hba)) >>> -        ufshcd_setup_clocks(hba, false); >>> -    else >>> -        /* If link is active, device ref_clk can't be switched off */ >>> -        __ufshcd_setup_clocks(hba, false, true); >>> +    ufshcd_setup_clocks(hba, false); >>>         if (ufshcd_is_clkgating_allowed(hba)) { >>>           hba->clk_gating.state = CLKS_OFF; >>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >>> index 66e5338..6f0f2d4 100644 >>> --- a/drivers/scsi/ufs/ufshcd.h >>> +++ b/drivers/scsi/ufs/ufshcd.h >>> @@ -229,6 +229,8 @@ struct ufs_dev_cmd { >>>    * @max_freq: maximum frequency supported by the clock >>>    * @min_freq: min frequency that can be used for clock scaling >>>    * @curr_freq: indicates the current frequency that it is set to >>> + * @keep_link_active: indicates that the clk should not be disabled if >>> +              link is active >>>    * @enabled: variable to check against multiple enable/disable >>>    */ >>>   struct ufs_clk_info { >>> @@ -238,6 +240,7 @@ struct ufs_clk_info { >>>       u32 max_freq; >>>       u32 min_freq; >>>       u32 curr_freq; >>> +    bool keep_link_active; >> >> Nitpick - How about 'always-on' instead of 'keep_link_active'? > > Hi Asutosh, > > But it is not always-on, during suspend, it is on when rpm/spm-lvl is 1 > and 2, off when rpm/spm-lvl is 3, 4 and 5, depending on the link state. > Understood & agree. > Thanks, > > Can Guo. > >>>       bool enabled; >>>   }; >>> -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2898C64E7A for ; Tue, 1 Dec 2020 16:47:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C2D3206B7 for ; Tue, 1 Dec 2020 16:47:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CWjVtQLL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="cbH7oSfX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C2D3206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7xaBF/J4plCHTpijaCQUgFxHf52rpX9Hrput/EsXv3I=; b=CWjVtQLL17di6PJ3PAfdCxfwc dUzKnWbdvrP8sxeKZIskV3UKEwhgZ3nNFK7a38nWDi55dakUSggvpez1JrQIWfDjfEttLw+iIRtR2 wpI9iUAiv4qE2T35sDUZN1kA74MU0RA+lg/nQMt7aFVtIl9dXPj606LPlPgkVUmwvlX0eBZHMx+xP aijPsJGVumsa3dWA+z2Hj+GIalj+PFvjEAQoBYFehvw6ZUEBmbz9xjnYJYkp6LpgoTefTg/c9hl/A k7NoPwk7nRE6FayWLSwFMlwkxnWvbEEW7zZ4b/amiSYZU6/E58Dwat36QLI0lsRG4Pe5So/LSLoaw BefM8pKxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk8oG-00030y-Nu; Tue, 01 Dec 2020 16:47:24 +0000 Received: from m42-5.mailgun.net ([69.72.42.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk8oB-000304-O9 for linux-mediatek@lists.infradead.org; Tue, 01 Dec 2020 16:47:21 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606841240; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=vHVerjrHrtjQ+JfG4LASvM1TDWXfkcH4kB6Bb8hWyRY=; b=cbH7oSfXZNymVSgXRukUO03j2KcopT/sHzt6OCr7oGBCcbQ/GHSif6/vGsqiRIuu/saXvQqf 2UUMNOEX1uBKIp1QH1z9key/fTMHpei8oT2+I+E2ypsKnRYSA+YrjAkBCIMtluldFhgMMtkR 9PcQGDmttAMCfRUkkzsSiBDqTQU= X-Mailgun-Sending-Ip: 69.72.42.5 X-Mailgun-Sid: WyI0ZDIyMyIsICJsaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5fc673920f9adc18c7304871 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 01 Dec 2020 16:47:14 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7E8E4C43466; Tue, 1 Dec 2020 16:47:13 +0000 (UTC) Received: from [192.168.8.168] (cpe-70-95-149-85.san.res.rr.com [70.95.149.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id 574F9C433ED; Tue, 1 Dec 2020 16:47:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 574F9C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=asutoshd@codeaurora.org Subject: Re: [PATCH v3 1/2] scsi: ufs: Refactor ufshcd_setup_clocks() to remove skip_ref_clk To: Can Guo References: <1606356063-38380-1-git-send-email-cang@codeaurora.org> <1606356063-38380-2-git-send-email-cang@codeaurora.org> <81ac4e5b5974cd7a21f18bf4e74213e9@codeaurora.org> From: "Asutosh Das (asd)" Message-ID: <2e27f15a-988a-fb08-9c51-913a542b7399@codeaurora.org> Date: Tue, 1 Dec 2020 08:47:09 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <81ac4e5b5974cd7a21f18bf4e74213e9@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_114720_868100_CFD31D60 X-CRM114-Status: GOOD ( 25.02 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:ARM/Mediatek SoC support" , Satya Tangirala , rnayak@codeaurora.org, saravanak@google.com, linux-scsi@vger.kernel.org, open list , "James E.J. Bottomley" , nguyenb@codeaurora.org, ziqichen@codeaurora.org, Avri Altman , "moderated list:ARM/Mediatek SoC support" , salyzyn@google.com, Alim Akhtar , "Martin K. Petersen" , Matthias Brugger , Tomas Winkler , Stanley Chu , kernel-team@android.com, Bart Van Assche , hongwus@codeaurora.org, Bean Huo Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gMTEvMzAvMjAyMCA3OjExIFBNLCBDYW4gR3VvIHdyb3RlOgo+IE9uIDIwMjAtMTItMDEgMDc6 MDEsIEFzdXRvc2ggRGFzIChhc2QpIHdyb3RlOgo+PiBPbiAxMS8yNS8yMDIwIDY6MDEgUE0sIENh biBHdW8gd3JvdGU6Cj4+PiBSZW1vdmUgdGhlIHBhcmFtIHNraXBfcmVmX2NsayBmcm9tIF9fdWZz aGNkX3NldHVwX2Nsb2NrcygpLCBidXQga2VlcCAKPj4+IGEgZmxhZwo+Pj4gaW4gc3RydWN0IHVm c19jbGtfaW5mbyB0byB0ZWxsIHdoZXRoZXIgYSBjbG9jayBjYW4gYmUgZGlzYWJsZWQgb3Igbm90 IAo+Pj4gd2hpbGUKPj4+IHRoZSBsaW5rIGlzIGFjdGl2ZS4KPj4+Cj4+PiBSZXZpZXdlZC1ieTog SG9uZ3d1IFN1PGhvbmd3dXNAY29kZWF1cm9yYS5vcmc+Cj4+PiBSZXZpZXdlZC1ieTogQmVhbiBI dW8gPGJlYW5odW9AbWljcm9uLmNvbT4KPj4+IFJldmlld2VkLWJ5OiBTdGFubGV5IENodSA8c3Rh bmxleS5jaHVAbWVkaWF0ZWsuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2FuIEd1byA8Y2FuZ0Bj b2RlYXVyb3JhLm9yZz4KPj4+IC0tLQo+Pj4gwqAgZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2QtcGx0 ZnJtLmMgfMKgIDIgKysKPj4+IMKgIGRyaXZlcnMvc2NzaS91ZnMvdWZzaGNkLmPCoMKgwqDCoMKg wqDCoCB8IDI5ICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+PiDCoCBkcml2ZXJzL3Nj c2kvdWZzL3Vmc2hjZC5owqDCoMKgwqDCoMKgwqAgfMKgIDMgKysrCj4+PiDCoCAzIGZpbGVzIGNo YW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC1wbHRmcm0uYyAKPj4+IGIvZHJpdmVycy9zY3Np L3Vmcy91ZnNoY2QtcGx0ZnJtLmMKPj4+IGluZGV4IDNkYjBhZjYuLjg3M2VmMTQgMTAwNjQ0Cj4+ PiAtLS0gYS9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC1wbHRmcm0uYwo+Pj4gKysrIGIvZHJpdmVy cy9zY3NpL3Vmcy91ZnNoY2QtcGx0ZnJtLmMKPj4+IEBAIC05Miw2ICs5Miw4IEBAIHN0YXRpYyBp bnQgdWZzaGNkX3BhcnNlX2Nsb2NrX2luZm8oc3RydWN0IHVmc19oYmEgCj4+PiAqaGJhKQo+Pj4g wqDCoMKgwqDCoMKgwqDCoMKgIGNsa2ktPm1pbl9mcmVxID0gY2xrZnJlcVtpXTsKPj4+IMKgwqDC oMKgwqDCoMKgwqDCoCBjbGtpLT5tYXhfZnJlcSA9IGNsa2ZyZXFbaSsxXTsKPj4+IMKgwqDCoMKg wqDCoMKgwqDCoCBjbGtpLT5uYW1lID0ga3N0cmR1cChuYW1lLCBHRlBfS0VSTkVMKTsKPj4+ICvC oMKgwqDCoMKgwqDCoCBpZiAoIXN0cmNtcChuYW1lLCAicmVmX2NsayIpKQo+Pj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgY2xraS0+a2VlcF9saW5rX2FjdGl2ZSA9IHRydWU7Cj4+PiDCoMKgwqDC oMKgwqDCoMKgwqAgZGV2X2RiZyhkZXYsICIlczogbWluICV1IG1heCAldSBuYW1lICVzXG4iLCAi ZnJlcS10YWJsZS1oeiIsCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNs a2ktPm1pbl9mcmVxLCBjbGtpLT5tYXhfZnJlcSwgY2xraS0+bmFtZSk7Cj4+PiDCoMKgwqDCoMKg wqDCoMKgwqAgbGlzdF9hZGRfdGFpbCgmY2xraS0+bGlzdCwgJmhiYS0+Y2xrX2xpc3RfaGVhZCk7 Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2QuYyBiL2RyaXZlcnMvc2Nz aS91ZnMvdWZzaGNkLmMKPj4+IGluZGV4IGE3ODU3ZjYuLjQ0MjU0YzkgMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC5jCj4+PiArKysgYi9kcml2ZXJzL3Njc2kvdWZzL3Vm c2hjZC5jCj4+PiBAQCAtMjIxLDggKzIyMSw2IEBAIHN0YXRpYyBpbnQgdWZzaGNkX2VoX2hvc3Rf cmVzZXRfaGFuZGxlcihzdHJ1Y3QgCj4+PiBzY3NpX2NtbmQgKmNtZCk7Cj4+PiDCoCBzdGF0aWMg aW50IHVmc2hjZF9jbGVhcl90bV9jbWQoc3RydWN0IHVmc19oYmEgKmhiYSwgaW50IHRhZyk7Cj4+ PiDCoCBzdGF0aWMgdm9pZCB1ZnNoY2RfaGJhX2V4aXQoc3RydWN0IHVmc19oYmEgKmhiYSk7Cj4+ PiDCoCBzdGF0aWMgaW50IHVmc2hjZF9wcm9iZV9oYmEoc3RydWN0IHVmc19oYmEgKmhiYSwgYm9v bCBhc3luYyk7Cj4+PiAtc3RhdGljIGludCBfX3Vmc2hjZF9zZXR1cF9jbG9ja3Moc3RydWN0IHVm c19oYmEgKmhiYSwgYm9vbCBvbiwKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBib29sIHNraXBfcmVmX2Nsayk7Cj4+PiDCoCBzdGF0aWMgaW50IHVmc2hjZF9zZXR1cF9jbG9j a3Moc3RydWN0IHVmc19oYmEgKmhiYSwgYm9vbCBvbik7Cj4+PiDCoCBzdGF0aWMgaW50IHVmc2hj ZF91aWNfaGliZXJuOF9lbnRlcihzdHJ1Y3QgdWZzX2hiYSAqaGJhKTsKPj4+IMKgIHN0YXRpYyBp bmxpbmUgdm9pZCB1ZnNoY2RfYWRkX2RlbGF5X2JlZm9yZV9kbWVfY21kKHN0cnVjdCB1ZnNfaGJh IAo+Pj4gKmhiYSk7Cj4+PiBAQCAtMTcwNywxMSArMTcwNSw3IEBAIHN0YXRpYyB2b2lkIHVmc2hj ZF9nYXRlX3dvcmsoc3RydWN0IAo+Pj4gd29ya19zdHJ1Y3QgKndvcmspCj4+PiDCoMKgwqDCoMKg wqDCoCB1ZnNoY2RfZGlzYWJsZV9pcnEoaGJhKTsKPj4+IMKgIC3CoMKgwqAgaWYgKCF1ZnNoY2Rf aXNfbGlua19hY3RpdmUoaGJhKSkKPj4+IC3CoMKgwqDCoMKgwqDCoCB1ZnNoY2Rfc2V0dXBfY2xv Y2tzKGhiYSwgZmFsc2UpOwo+Pj4gLcKgwqDCoCBlbHNlCj4+PiAtwqDCoMKgwqDCoMKgwqAgLyog SWYgbGluayBpcyBhY3RpdmUsIGRldmljZSByZWZfY2xrIGNhbid0IGJlIHN3aXRjaGVkIG9mZiAq Lwo+Pj4gLcKgwqDCoMKgwqDCoMKgIF9fdWZzaGNkX3NldHVwX2Nsb2NrcyhoYmEsIGZhbHNlLCB0 cnVlKTsKPj4+ICvCoMKgwqAgdWZzaGNkX3NldHVwX2Nsb2NrcyhoYmEsIGZhbHNlKTsKPj4+IMKg wqDCoMKgwqDCoMKgIC8qCj4+PiDCoMKgwqDCoMKgwqAgKiBJbiBjYXNlIHlvdSBhcmUgaGVyZSB0 byBjYW5jZWwgdGhpcyB3b3JrIHRoZSBnYXRpbmcgc3RhdGUKPj4+IEBAIC03OTkwLDggKzc5ODQs NyBAQCBzdGF0aWMgaW50IHVmc2hjZF9pbml0X2hiYV92cmVnKHN0cnVjdCB1ZnNfaGJhIAo+Pj4g KmhiYSkKPj4+IMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+PiDCoCB9Cj4+PiDCoCAtc3RhdGljIGlu dCBfX3Vmc2hjZF9zZXR1cF9jbG9ja3Moc3RydWN0IHVmc19oYmEgKmhiYSwgYm9vbCBvbiwKPj4+ IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBib29sIHNraXBfcmVmX2Ns aykKPj4+ICtzdGF0aWMgaW50IHVmc2hjZF9zZXR1cF9jbG9ja3Moc3RydWN0IHVmc19oYmEgKmhi YSwgYm9vbCBvbikKPj4+IMKgIHsKPj4+IMKgwqDCoMKgwqAgaW50IHJldCA9IDA7Cj4+PiDCoMKg wqDCoMKgIHN0cnVjdCB1ZnNfY2xrX2luZm8gKmNsa2k7Cj4+PiBAQCAtODAwOSw3ICs4MDAyLDEy IEBAIHN0YXRpYyBpbnQgX191ZnNoY2Rfc2V0dXBfY2xvY2tzKHN0cnVjdCAKPj4+IHVmc19oYmEg KmhiYSwgYm9vbCBvbiwKPj4+IMKgwqDCoMKgwqDCoMKgIGxpc3RfZm9yX2VhY2hfZW50cnkoY2xr aSwgaGVhZCwgbGlzdCkgewo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmICghSVNfRVJSX09SX05V TEwoY2xraS0+Y2xrKSkgewo+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNraXBfcmVm X2NsayAmJiAhc3RyY21wKGNsa2ktPm5hbWUsICJyZWZfY2xrIikpCj4+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAvKgo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqIERvbid0IGRpc2Fi bGUgY2xvY2tzIHdoaWNoIGFyZSBuZWVkZWQKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg KiB0byBrZWVwIHRoZSBsaW5rIGFjdGl2ZS4KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Ki8KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICh1ZnNoY2RfaXNfbGlua19hY3RpdmUo aGJhKSAmJgo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjbGtpLT5rZWVwX2xp bmtfYWN0aXZlKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb250aW51 ZTsKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjbGtfc3RhdGVfY2hhbmdlZCA9 IG9uIF4gY2xraS0+ZW5hYmxlZDsKPj4+IEBAIC04MDU0LDExICs4MDUyLDYgQEAgc3RhdGljIGlu dCBfX3Vmc2hjZF9zZXR1cF9jbG9ja3Moc3RydWN0IAo+Pj4gdWZzX2hiYSAqaGJhLCBib29sIG9u LAo+Pj4gwqDCoMKgwqDCoCByZXR1cm4gcmV0Owo+Pj4gwqAgfQo+Pj4gwqAgLXN0YXRpYyBpbnQg dWZzaGNkX3NldHVwX2Nsb2NrcyhzdHJ1Y3QgdWZzX2hiYSAqaGJhLCBib29sIG9uKQo+Pj4gLXsK Pj4+IC3CoMKgwqAgcmV0dXJuwqAgX191ZnNoY2Rfc2V0dXBfY2xvY2tzKGhiYSwgb24sIGZhbHNl KTsKPj4+IC19Cj4+PiAtCj4+PiDCoCBzdGF0aWMgaW50IHVmc2hjZF9pbml0X2Nsb2NrcyhzdHJ1 Y3QgdWZzX2hiYSAqaGJhKQo+Pj4gwqAgewo+Pj4gwqDCoMKgwqDCoCBpbnQgcmV0ID0gMDsKPj4+ IEBAIC04NTc3LDExICs4NTcwLDcgQEAgc3RhdGljIGludCB1ZnNoY2Rfc3VzcGVuZChzdHJ1Y3Qg dWZzX2hiYSAqaGJhLCAKPj4+IGVudW0gdWZzX3BtX29wIHBtX29wKQo+Pj4gwqDCoMKgwqDCoMKg ICovCj4+PiDCoMKgwqDCoMKgIHVmc2hjZF9kaXNhYmxlX2lycShoYmEpOwo+Pj4gwqAgLcKgwqDC oCBpZiAoIXVmc2hjZF9pc19saW5rX2FjdGl2ZShoYmEpKQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHVm c2hjZF9zZXR1cF9jbG9ja3MoaGJhLCBmYWxzZSk7Cj4+PiAtwqDCoMKgIGVsc2UKPj4+IC3CoMKg wqDCoMKgwqDCoCAvKiBJZiBsaW5rIGlzIGFjdGl2ZSwgZGV2aWNlIHJlZl9jbGsgY2FuJ3QgYmUg c3dpdGNoZWQgb2ZmICovCj4+PiAtwqDCoMKgwqDCoMKgwqAgX191ZnNoY2Rfc2V0dXBfY2xvY2tz KGhiYSwgZmFsc2UsIHRydWUpOwo+Pj4gK8KgwqDCoCB1ZnNoY2Rfc2V0dXBfY2xvY2tzKGhiYSwg ZmFsc2UpOwo+Pj4gwqDCoMKgwqDCoMKgwqAgaWYgKHVmc2hjZF9pc19jbGtnYXRpbmdfYWxsb3dl ZChoYmEpKSB7Cj4+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaGJhLT5jbGtfZ2F0aW5nLnN0YXRlID0g Q0xLU19PRkY7Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2QuaCBiL2Ry aXZlcnMvc2NzaS91ZnMvdWZzaGNkLmgKPj4+IGluZGV4IDY2ZTUzMzguLjZmMGYyZDQgMTAwNjQ0 Cj4+PiAtLS0gYS9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC5oCj4+PiArKysgYi9kcml2ZXJzL3Nj c2kvdWZzL3Vmc2hjZC5oCj4+PiBAQCAtMjI5LDYgKzIyOSw4IEBAIHN0cnVjdCB1ZnNfZGV2X2Nt ZCB7Cj4+PiDCoMKgICogQG1heF9mcmVxOiBtYXhpbXVtIGZyZXF1ZW5jeSBzdXBwb3J0ZWQgYnkg dGhlIGNsb2NrCj4+PiDCoMKgICogQG1pbl9mcmVxOiBtaW4gZnJlcXVlbmN5IHRoYXQgY2FuIGJl IHVzZWQgZm9yIGNsb2NrIHNjYWxpbmcKPj4+IMKgwqAgKiBAY3Vycl9mcmVxOiBpbmRpY2F0ZXMg dGhlIGN1cnJlbnQgZnJlcXVlbmN5IHRoYXQgaXQgaXMgc2V0IHRvCj4+PiArICogQGtlZXBfbGlu a19hY3RpdmU6IGluZGljYXRlcyB0aGF0IHRoZSBjbGsgc2hvdWxkIG5vdCBiZSBkaXNhYmxlZCBp Zgo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGxpbmsgaXMgYWN0aXZlCj4+PiDCoMKg ICogQGVuYWJsZWQ6IHZhcmlhYmxlIHRvIGNoZWNrIGFnYWluc3QgbXVsdGlwbGUgZW5hYmxlL2Rp c2FibGUKPj4+IMKgwqAgKi8KPj4+IMKgIHN0cnVjdCB1ZnNfY2xrX2luZm8gewo+Pj4gQEAgLTIz OCw2ICsyNDAsNyBAQCBzdHJ1Y3QgdWZzX2Nsa19pbmZvIHsKPj4+IMKgwqDCoMKgwqAgdTMyIG1h eF9mcmVxOwo+Pj4gwqDCoMKgwqDCoCB1MzIgbWluX2ZyZXE7Cj4+PiDCoMKgwqDCoMKgIHUzMiBj dXJyX2ZyZXE7Cj4+PiArwqDCoMKgIGJvb2wga2VlcF9saW5rX2FjdGl2ZTsKPj4KPj4gTml0cGlj ayAtIEhvdyBhYm91dCAnYWx3YXlzLW9uJyBpbnN0ZWFkIG9mICdrZWVwX2xpbmtfYWN0aXZlJz8K PiAKPiBIaSBBc3V0b3NoLAo+IAo+IEJ1dCBpdCBpcyBub3QgYWx3YXlzLW9uLCBkdXJpbmcgc3Vz cGVuZCwgaXQgaXMgb24gd2hlbiBycG0vc3BtLWx2bCBpcyAxCj4gYW5kIDIsIG9mZiB3aGVuIHJw bS9zcG0tbHZsIGlzIDMsIDQgYW5kIDUsIGRlcGVuZGluZyBvbiB0aGUgbGluayBzdGF0ZS4KPiAK ClVuZGVyc3Rvb2QgJiBhZ3JlZS4KCgo+IFRoYW5rcywKPiAKPiBDYW4gR3VvLgo+IAo+Pj4gwqDC oMKgwqDCoCBib29sIGVuYWJsZWQ7Cj4+PiDCoCB9Owo+Pj4KCgotLSAKVGhlIFF1YWxjb21tIElu bm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIHRoZSBDb2RlIEF1cm9yYSBGb3J1 bSwKTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcg bGlzdApMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK