From: David Hildenbrand <david@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v1 1/2] virtio-mem: Warn if a memory backend with "prealloc=on" is used
Date: Tue, 25 Jan 2022 13:08:27 +0100 [thread overview]
Message-ID: <2e2e4287-2063-ea47-c92b-0822b6910365@redhat.com> (raw)
In-Reply-To: <Ye/cwauVLyq3RSq7@work-vm>
On 25.01.22 12:19, Dr. David Alan Gilbert wrote:
> * David Hildenbrand (david@redhat.com) wrote:
>> "prealloc=on" for the memory backend does not work as expected, as
>> virtio-mem will simply discard all preallocated memory immediately again.
>> In the best case, it's an expensive NOP. In the worst case, it's an
>> unexpected allocation error.
>>
>> Instead, "prealloc=on" should be specified for the virtio-mem device only,
>> such that virtio-mem will try preallocating memory before plugging
>> memory dynamically to the guest.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> Why is this a warning rather than an error that stops creation of the
> device?
No strong opinion, an error might actually be better.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-01-25 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 15:07 [PATCH v1 0/2] virtio-mem: Handle preallocation with migration David Hildenbrand
2022-01-18 15:07 ` [PATCH v1 1/2] virtio-mem: Warn if a memory backend with "prealloc=on" is used David Hildenbrand
2022-01-25 11:19 ` Dr. David Alan Gilbert
2022-01-25 12:08 ` David Hildenbrand [this message]
2022-01-18 15:07 ` [PATCH v1 2/2] virtio-mem: Handle preallocation with migration David Hildenbrand
2022-01-25 11:43 ` Dr. David Alan Gilbert
2022-01-19 13:26 ` [PATCH v1 0/2] " Michal Prívozník
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e2e4287-2063-ea47-c92b-0822b6910365@redhat.com \
--to=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.