From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C57E96D00 for ; Tue, 15 Jun 2021 13:18:40 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lt8xD-0007qa-D2; Tue, 15 Jun 2021 15:18:07 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1lt8xB-0000Sh-75; Tue, 15 Jun 2021 15:18:05 +0200 Message-ID: <2e369015776577c6c32ec2f7d05e35f796edf713.camel@pengutronix.de> Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver From: Philipp Zabel To: Ban Tao , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, krzk@kernel.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Date: Tue, 15 Jun 2021 15:18:05 +0200 In-Reply-To: <20210615130326.2044-1-fengzheng923@gmail.com> References: <20210615130326.2044-1-fengzheng923@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-sunxi@lists.linux.dev Hi Ban, On Tue, 2021-06-15 at 21:03 +0800, Ban Tao wrote: > The Allwinner H6 and later SoCs have an DMIC block > which is capable of capture. >=20 > Signed-off-by: Ban Tao [...] > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.= c > new file mode 100644 > index 000000000000..78d512d93974 > --- /dev/null > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -0,0 +1,408 @@ [...] > + host->rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, NUL= L); > + if (IS_ERR(host->rst) && PTR_ERR(host->rst) =3D=3D -EPROBE_DEFER) { > + ret =3D -EPROBE_DEFER; > + dev_err(&pdev->dev, "Failed to get reset: %d\n", ret); > + return ret; > + } Please don't ignore errors. For example: if (IS_ERR(host->rst)) return dev_err_probe(&pdev->dev, PTR_ERR(host->rst), "Failed to get reset\n"); devm_reset_control_get_optional_exclusive() will return NULL if no reset is specified in the device tree. > + if (!IS_ERR(host->rst)) > + reset_control_deassert(host->rst); Then this is not necessary. Just use: reset_control_deassert(host->rst); regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6E6C48BDF for ; Tue, 15 Jun 2021 13:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0004F6145D for ; Tue, 15 Jun 2021 13:18:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbhFONUd convert rfc822-to-8bit (ORCPT ); Tue, 15 Jun 2021 09:20:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhFONUa (ORCPT ); Tue, 15 Jun 2021 09:20:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0506EC061574 for ; Tue, 15 Jun 2021 06:18:25 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lt8xD-0007qa-D2; Tue, 15 Jun 2021 15:18:07 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1lt8xB-0000Sh-75; Tue, 15 Jun 2021 15:18:05 +0200 Message-ID: <2e369015776577c6c32ec2f7d05e35f796edf713.camel@pengutronix.de> Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver From: Philipp Zabel To: Ban Tao , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, krzk@kernel.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Date: Tue, 15 Jun 2021 15:18:05 +0200 In-Reply-To: <20210615130326.2044-1-fengzheng923@gmail.com> References: <20210615130326.2044-1-fengzheng923@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ban, On Tue, 2021-06-15 at 21:03 +0800, Ban Tao wrote: > The Allwinner H6 and later SoCs have an DMIC block > which is capable of capture. > > Signed-off-by: Ban Tao [...] > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c > new file mode 100644 > index 000000000000..78d512d93974 > --- /dev/null > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -0,0 +1,408 @@ [...] > + host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); > + if (IS_ERR(host->rst) && PTR_ERR(host->rst) == -EPROBE_DEFER) { > + ret = -EPROBE_DEFER; > + dev_err(&pdev->dev, "Failed to get reset: %d\n", ret); > + return ret; > + } Please don't ignore errors. For example: if (IS_ERR(host->rst)) return dev_err_probe(&pdev->dev, PTR_ERR(host->rst), "Failed to get reset\n"); devm_reset_control_get_optional_exclusive() will return NULL if no reset is specified in the device tree. > + if (!IS_ERR(host->rst)) > + reset_control_deassert(host->rst); Then this is not necessary. Just use: reset_control_deassert(host->rst); regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22ACDC48BE5 for ; Tue, 15 Jun 2021 13:19:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 878236145D for ; Tue, 15 Jun 2021 13:19:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 878236145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3FE5286E; Tue, 15 Jun 2021 15:18:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3FE5286E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623763171; bh=/GB/FSkgMwQHniWR+6mJujhqtDWVZbA2REQv9FEeEGE=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ghJQv3JQu4A3c+TMfnl9zuklEe7WirKvOZAlumzmTWr5C56BMRPJ3mtxtU1VToeDJ TnrQwvGmgCGtaxso4hk74kKlpqjxoR77Usv/lXKNJ4lDob+Onu3O0YKhKwZXmbw6ip 62TFMXERM28U9S3LD1m7p3dPAEKbaoaMP+N+2LXA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BECC0F8016D; Tue, 15 Jun 2021 15:18:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E5030F80171; Tue, 15 Jun 2021 15:18:38 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B479AF80113 for ; Tue, 15 Jun 2021 15:18:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B479AF80113 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lt8xD-0007qa-D2; Tue, 15 Jun 2021 15:18:07 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1lt8xB-0000Sh-75; Tue, 15 Jun 2021 15:18:05 +0200 Message-ID: <2e369015776577c6c32ec2f7d05e35f796edf713.camel@pengutronix.de> Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver From: Philipp Zabel To: Ban Tao , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, krzk@kernel.org Date: Tue, 15 Jun 2021 15:18:05 +0200 In-Reply-To: <20210615130326.2044-1-fengzheng923@gmail.com> References: <20210615130326.2044-1-fengzheng923@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Ban, On Tue, 2021-06-15 at 21:03 +0800, Ban Tao wrote: > The Allwinner H6 and later SoCs have an DMIC block > which is capable of capture. >=20 > Signed-off-by: Ban Tao [...] > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.= c > new file mode 100644 > index 000000000000..78d512d93974 > --- /dev/null > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -0,0 +1,408 @@ [...] > + host->rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, NUL= L); > + if (IS_ERR(host->rst) && PTR_ERR(host->rst) =3D=3D -EPROBE_DEFER) { > + ret =3D -EPROBE_DEFER; > + dev_err(&pdev->dev, "Failed to get reset: %d\n", ret); > + return ret; > + } Please don't ignore errors. For example: if (IS_ERR(host->rst)) return dev_err_probe(&pdev->dev, PTR_ERR(host->rst), "Failed to get reset\n"); devm_reset_control_get_optional_exclusive() will return NULL if no reset is specified in the device tree. > + if (!IS_ERR(host->rst)) > + reset_control_deassert(host->rst); Then this is not necessary. Just use: reset_control_deassert(host->rst); regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83724C48BDF for ; Tue, 15 Jun 2021 19:39:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36A8261105 for ; Tue, 15 Jun 2021 19:39:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A8261105 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xRFkfbq/QQQE6GKxSy0ETQUrrt2SoDqzZccpqx/6kJ4=; b=L9ANJhgHorS3jH lzB4TKX/ZqEKnd1GPn3idkH8Cfre8fqz4Lukm1Um1p5QmmkM0XGdx3kYl3jF/k7cyhXL9GacRuUOH b+pJqV3oktJJSHdDi6QdvupGhhK5vXA3e/Wr+/9NjvtBAu/zihr7NtaowMOQwBnE1G+UHK/RGhHt0 1eOIr9ws8Jm1fekSQszef/9PjJ78SJSVra+EJNOVWWqvWwLiVIH0sc2/Ki/P3naVLmT9H8pcDFj+E iRdUzX7bX3yiOIheAzcfk6l9guuaPW+LYu3Kk8+jDeGbAuuORwfmoM14W0NKI+oVJtZrGlgiq/U/6 p5CVy3iIPvRx6Ke4eDNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltEre-002UpW-AI; Tue, 15 Jun 2021 19:36:46 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9Bt-000ByJ-K9 for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:33:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=VZuaVhTOB/k9n6Vus9BpDba/ZPWI4HgLV9kV9uqczzM=; b=RVRPnPG4LDkizP/eK4OnRx8h78 RBjDYxWPzBzDd5/DqMpED9OeUEbHDmYZCFwsNnWPaBhhVaVm+U72zScHRVKTnOrT4+XROvrv+FNr/ u6tigbboN21DBr8+zPOuiGhn//tXvHW1Y/oCVhMgrW8FUNMe8/UpVqu1CGHpS+ej29qSVP7a/yxuX lu8MWA9mDd0QzREcygzNkRYyZjaaOvgr6WcxWgWvFWqf/OFSxGJCkubHF3HAreVexauRUifxZpZvw pEqPZFELkwvgGuz6nX0SAuosMO/WAzNThrRuIYWfOVoWLT4aOvscSB15RNzpO8tjfE4zmcBxYsj0x brsrwVIg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt8xa-007up4-2W for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 13:18:38 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lt8xD-0007qa-D2; Tue, 15 Jun 2021 15:18:07 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1lt8xB-0000Sh-75; Tue, 15 Jun 2021 15:18:05 +0200 Message-ID: <2e369015776577c6c32ec2f7d05e35f796edf713.camel@pengutronix.de> Subject: Re: [PATCH 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver From: Philipp Zabel To: Ban Tao , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mripard@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, krzk@kernel.org Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Date: Tue, 15 Jun 2021 15:18:05 +0200 In-Reply-To: <20210615130326.2044-1-fengzheng923@gmail.com> References: <20210615130326.2044-1-fengzheng923@gmail.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_141836_957438_C395958A X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ban, On Tue, 2021-06-15 at 21:03 +0800, Ban Tao wrote: > The Allwinner H6 and later SoCs have an DMIC block > which is capable of capture. > > Signed-off-by: Ban Tao [...] > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c > new file mode 100644 > index 000000000000..78d512d93974 > --- /dev/null > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -0,0 +1,408 @@ [...] > + host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); > + if (IS_ERR(host->rst) && PTR_ERR(host->rst) == -EPROBE_DEFER) { > + ret = -EPROBE_DEFER; > + dev_err(&pdev->dev, "Failed to get reset: %d\n", ret); > + return ret; > + } Please don't ignore errors. For example: if (IS_ERR(host->rst)) return dev_err_probe(&pdev->dev, PTR_ERR(host->rst), "Failed to get reset\n"); devm_reset_control_get_optional_exclusive() will return NULL if no reset is specified in the device tree. > + if (!IS_ERR(host->rst)) > + reset_control_deassert(host->rst); Then this is not necessary. Just use: reset_control_deassert(host->rst); regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel