From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7372C433F5 for ; Tue, 19 Apr 2022 09:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348043AbiDSJUd (ORCPT ); Tue, 19 Apr 2022 05:20:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231799AbiDSJUc (ORCPT ); Tue, 19 Apr 2022 05:20:32 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96CDC26AC9; Tue, 19 Apr 2022 02:17:50 -0700 (PDT) Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 19 Apr 2022 17:17:48 +0800 Message-ID: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Date: Tue, 19 Apr 2022 17:17:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> From: Liang Yang In-Reply-To: <20220419102629.1c77aa2a@xps13> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Miquel, On 2022/4/19 16:26, Miquel Raynal wrote: > [ EXTERNAL EMAIL ] > > Hello, > > liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800: > >> Hi Miquel, >> >> i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points: >> a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work. > > I don't get what you mean here, sorry. I believe there is a new way to > describe this clock but grabbing the one from the MMC still works, does > not it? > No, it doesn't. after the NFC driver using the MMC sub clock framework was merged into the mainline of kernel, we didn't continue to submit the series of patches about MMC sub clock after v9. when i found that, we made a discussion to decide whether to recover the series of patches about MMC sub clock framework, finally, see the description from cover letter, we plan to abandon it and adopt the new clock scheme in this series of patches. Thanks. >> b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init(). > > Yes, probably. > >> do we still need to avoid break DT compatibility? > > We should try our best to avoid breaking the DT, yes. > >> >> Thanks. >> >> On 2022/4/11 10:40, Liang Yang wrote: >>>>>       nfc->dev = dev; >>>>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>>>> -    nfc->reg_base = devm_ioremap_resource(dev, res); >>>>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); >>>> >>>> This change seems unrelated. >>> >>> To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?> >>>>>       if (IS_ERR(nfc->reg_base)) >>>>>           return PTR_ERR(nfc->reg_base); >>>>> -    nfc->reg_clk = >>>>> -        syscon_regmap_lookup_by_phandle(dev->of_node, >>>>> -                        "amlogic,mmc-syscon"); >>>>> -    if (IS_ERR(nfc->reg_clk)) { >>>>> -        dev_err(dev, "Failed to lookup clock base\n"); >>>>> -        return PTR_ERR(nfc->reg_clk); >>>>> -    } >>>>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc"); >>>>> +    if (IS_ERR(nfc->sd_emmc_clock)) >>>>> +        return PTR_ERR(nfc->sd_emmc_clock); >>>> >>>> While I agree this is much better than the previous solution, we cannot >>>> break DT compatibility, so you need to try getting the emmc clock, but >>>> if it fails you should fallback to the regmap lookup. >>> >>> ok, i will fix it next version. thanks. >>> >>>> >>>>>       irq = platform_get_irq(pdev, 0); > > > Thanks, > Miquèl > > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56A52C433F5 for ; Tue, 19 Apr 2022 09:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vhr7O79nJ46r7/EjnpeFjE7knsd8zDzDioOdGXnC8Y=; b=0PeSiCfQ3zKF2G aQTZdyxTgI6cPFdgSWmZbhtfY0qCGGhIvynDQVkM4RYxaledAPPOin42G9TOcNlv6vFcm8wKwl7nl tOJ+NPb0iVXx+LaBTBtRRQVtYxuEKLoz/+OptSYk5UmyHH4lQzA8QvpjXxMnl69Qzmv+XhE3A7tlD 9XUuOvH9ZzPI+1h19gDS2DOBMcp4wMOmpNxDU+yt+crpU7seFpDO3FENUoHUtWqDe4Bm8pWdHMlqi NTLjFH2EqEjpoocLKVImh4CRtEYe6IKcjr6ted1UF06UZlwT+/smfiakBuNYLjn6KWVp/Xo4nvU38 LICZmoZU3xhGsv4SyYWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjzs-002WQB-3w; Tue, 19 Apr 2022 09:18:08 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjzf-002WLF-5N; Tue, 19 Apr 2022 09:17:56 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 19 Apr 2022 17:17:48 +0800 Message-ID: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Date: Tue, 19 Apr 2022 17:17:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> From: Liang Yang In-Reply-To: <20220419102629.1c77aa2a@xps13> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_021755_256746_69C636F3 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8gTWlxdWVsLAoKT24gMjAyMi80LzE5IDE2OjI2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ IFsgRVhURVJOQUwgRU1BSUwgXQo+IAo+IEhlbGxvLAo+IAo+IGxpYW5nLnlhbmdAYW1sb2dpYy5j b20gd3JvdGUgb24gTW9uLCAxOCBBcHIgMjAyMiAxMTo0MDoxMCArMDgwMDoKPiAKPj4gSGkgTWlx dWVsLAo+Pgo+PiBpIGhhdmUgc29tZSBjb25mdXNpb24gd2hlbiBpIHByZXBhcmUgdGhlIHBhdGNo ZXMuIGZvciBEVCBjb21wYXRpYmlsaXR5LCBpdCBmYWxscyBiYWNrIHRvIHRoZSBvbGQgRFQgd2hl biBmYWlsZWQgdG8gZ2V0IHJlc291cmNlIGJ5IHRoZSBuZXcgRFQsIGJ1dCB0aGVyZSBpcyBzb21l IHBvaW50czoKPj4gYS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1 dCBpdCBuZXZlciBiZSBtZXJnZWQsIHNvIGl0IGNhbid0IHdvcmsuCj4gCj4gSSBkb24ndCBnZXQg d2hhdCB5b3UgbWVhbiBoZXJlLCBzb3JyeS4gSSBiZWxpZXZlIHRoZXJlIGlzIGEgbmV3IHdheSB0 bwo+IGRlc2NyaWJlIHRoaXMgY2xvY2sgYnV0IGdyYWJiaW5nIHRoZSBvbmUgZnJvbSB0aGUgTU1D IHN0aWxsIHdvcmtzLCBkb2VzCj4gbm90IGl0Pwo+IAoKTm8sIGl0IGRvZXNuJ3QuIGFmdGVyIHRo ZSBORkMgZHJpdmVyIHVzaW5nIHRoZSBNTUMgc3ViIGNsb2NrIGZyYW1ld29yayAKd2FzIG1lcmdl ZCBpbnRvIHRoZSBtYWlubGluZSBvZiBrZXJuZWwsIHdlIGRpZG4ndCBjb250aW51ZSB0byBzdWJt aXQgdGhlIApzZXJpZXMgb2YgcGF0Y2hlcyBhYm91dCBNTUMgc3ViIGNsb2NrIGFmdGVyIHY5LiB3 aGVuIGkgZm91bmQgdGhhdCwgd2UgCm1hZGUgYSBkaXNjdXNzaW9uIHRvIGRlY2lkZSB3aGV0aGVy IHRvIHJlY292ZXIgdGhlIHNlcmllcyBvZiBwYXRjaGVzIAphYm91dCBNTUMgc3ViIGNsb2NrIGZy YW1ld29yaywgZmluYWxseSwgc2VlIHRoZSBkZXNjcmlwdGlvbiBmcm9tIGNvdmVyIApsZXR0ZXIs IHdlIHBsYW4gdG8gYWJhbmRvbiBpdCBhbmQgYWRvcHQgdGhlIG5ldyBjbG9jayBzY2hlbWUgaW4g dGhpcyAKc2VyaWVzIG9mIHBhdGNoZXMuCgpUaGFua3MuCgo+PiBiLiBpZiBpdCBmYWxscyBiYWNr IHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywgaXQgc2VlbXMg dGhhdCB3ZSBoYXZlIHRvIHByZXNlcnZlIHRoZSBjb2RlIG9mIHRoZSBvbGQgY2xvY2sgc2V0dGlu ZyBpbiBuZmNfY2xrX2luaXQoKS4KPiAKPiBZZXMsIHByb2JhYmx5Lgo+IAo+PiBkbyB3ZSBzdGls bCBuZWVkIHRvIGF2b2lkIGJyZWFrIERUIGNvbXBhdGliaWxpdHk/Cj4gCj4gV2Ugc2hvdWxkIHRy eSBvdXIgYmVzdCB0byBhdm9pZCBicmVha2luZyB0aGUgRFQsIHllcy4KPiAKPj4KPj4gVGhhbmtz Lgo+Pgo+PiBPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlhbmcgd3JvdGU6Cj4+Pj4+ICDCoMKg wqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+Pj4+PiAtwqDCoMKgIHJlcyA9IHBsYXRmb3JtX2dldF9y ZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7Cj4+Pj4+IC3CoMKgwqAgbmZjLT5yZWdf YmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7Cj4+Pj4+ICvCoMKgwqAgbmZj LT5yZWdfYmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9ieW5hbWUocGRldiwg Im5mYyIpOwo+Pj4+Cj4+Pj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdW5yZWxhdGVkLgo+Pj4KPj4+IFRv IGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUgZm9sbG93aW5nID4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFw X3Jlc291cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdlID4gZG9u J3QgbmVlZCBpdD8+Cj4+Pj4+ICDCoMKgwqDCoMKgIGlmIChJU19FUlIobmZjLT5yZWdfYmFzZSkp Cj4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfYmFzZSk7 Cj4+Pj4+IC3CoMKgwqAgbmZjLT5yZWdfY2xrID0KPj4+Pj4gLcKgwqDCoMKgwqDCoMKgIHN5c2Nv bl9yZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUoZGV2LT5vZl9ub2RlLAo+Pj4+PiAtwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiYW1sb2dpYyxtbWMtc3lzY29u Iik7Cj4+Pj4+IC3CoMKgwqAgaWYgKElTX0VSUihuZmMtPnJlZ19jbGspKSB7Cj4+Pj4+IC3CoMKg wqDCoMKgwqDCoCBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBsb29rdXAgY2xvY2sgYmFzZVxuIik7 Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihuZmMtPnJlZ19jbGspOwo+Pj4+ PiAtwqDCoMKgIH0KPj4+Pj4gK8KgwqDCoCBuZmMtPnNkX2VtbWNfY2xvY2sgPSBkZXZtX3BsYXRm b3JtX2lvcmVtYXBfcmVzb3VyY2VfYnluYW1lKHBkZXYsID4+PiAiZW1tYyIpOwo+Pj4+PiArwqDC oMKgIGlmIChJU19FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKSkKPj4+Pj4gK8KgwqDCoMKgwqDCoMKg IHJldHVybiBQVFJfRVJSKG5mYy0+c2RfZW1tY19jbG9jayk7Cj4+Pj4KPj4+PiBXaGlsZSBJIGFn cmVlIHRoaXMgaXMgbXVjaCBiZXR0ZXIgdGhhbiB0aGUgcHJldmlvdXMgc29sdXRpb24sIHdlIGNh bm5vdAo+Pj4+IGJyZWFrIERUIGNvbXBhdGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0 aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQKPj4+PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxi YWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLgo+Pj4KPj4+IG9rLCBpIHdpbGwgZml4IGl0IG5leHQg dmVyc2lvbi4gdGhhbmtzLgo+Pj4gICAgCj4+Pj4gICAKPj4+Pj4gIMKgwqDCoMKgwqAgaXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKPiAKPiAKPiBUaGFua3MsCj4gTWlxdcOobAo+IAo+ IC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E18BC433F5 for ; Tue, 19 Apr 2022 09:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kI4nmmDuEAqoBjIg2NMBYy9T3EP9ay8fPtxHIO3D+mw=; b=JC02cE3Gna94Z3 eiEYdXkpb8mDKOC6Kky4F2KbBPf2IIayjeoEMdLQlodiPSbax2HmDDPuNc5189kSEu4JuZ8T7KzhQ UeHjpaQEbcHSOg0WWLqEP2HfuCmfv3j7sHReON7W+iES/dQ4CI63QoEKTXX/lvLwiwBkxY6RgLk5Q zSuc5cu+a77KzH5mLRL8VGEHYBR7M+t/rKkLkXMRK+wVDpJ2f7gGQXqxHInqBhzuzlWiIvpAT+Sul 87lxR14+q05rTbdUpwKvSJ2hGS+lpeMnv9T17BXg0BnK5LH0lLo5R8V1v5xTSIF0LhX5T58rTt29z mizaMNeu7AP3FkxfiA8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjzj-002WNu-GA; Tue, 19 Apr 2022 09:17:59 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjzf-002WLF-5N; Tue, 19 Apr 2022 09:17:56 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 19 Apr 2022 17:17:48 +0800 Message-ID: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Date: Tue, 19 Apr 2022 17:17:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> From: Liang Yang In-Reply-To: <20220419102629.1c77aa2a@xps13> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_021755_256746_69C636F3 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gTWlxdWVsLAoKT24gMjAyMi80LzE5IDE2OjI2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ IFsgRVhURVJOQUwgRU1BSUwgXQo+IAo+IEhlbGxvLAo+IAo+IGxpYW5nLnlhbmdAYW1sb2dpYy5j b20gd3JvdGUgb24gTW9uLCAxOCBBcHIgMjAyMiAxMTo0MDoxMCArMDgwMDoKPiAKPj4gSGkgTWlx dWVsLAo+Pgo+PiBpIGhhdmUgc29tZSBjb25mdXNpb24gd2hlbiBpIHByZXBhcmUgdGhlIHBhdGNo ZXMuIGZvciBEVCBjb21wYXRpYmlsaXR5LCBpdCBmYWxscyBiYWNrIHRvIHRoZSBvbGQgRFQgd2hl biBmYWlsZWQgdG8gZ2V0IHJlc291cmNlIGJ5IHRoZSBuZXcgRFQsIGJ1dCB0aGVyZSBpcyBzb21l IHBvaW50czoKPj4gYS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1 dCBpdCBuZXZlciBiZSBtZXJnZWQsIHNvIGl0IGNhbid0IHdvcmsuCj4gCj4gSSBkb24ndCBnZXQg d2hhdCB5b3UgbWVhbiBoZXJlLCBzb3JyeS4gSSBiZWxpZXZlIHRoZXJlIGlzIGEgbmV3IHdheSB0 bwo+IGRlc2NyaWJlIHRoaXMgY2xvY2sgYnV0IGdyYWJiaW5nIHRoZSBvbmUgZnJvbSB0aGUgTU1D IHN0aWxsIHdvcmtzLCBkb2VzCj4gbm90IGl0Pwo+IAoKTm8sIGl0IGRvZXNuJ3QuIGFmdGVyIHRo ZSBORkMgZHJpdmVyIHVzaW5nIHRoZSBNTUMgc3ViIGNsb2NrIGZyYW1ld29yayAKd2FzIG1lcmdl ZCBpbnRvIHRoZSBtYWlubGluZSBvZiBrZXJuZWwsIHdlIGRpZG4ndCBjb250aW51ZSB0byBzdWJt aXQgdGhlIApzZXJpZXMgb2YgcGF0Y2hlcyBhYm91dCBNTUMgc3ViIGNsb2NrIGFmdGVyIHY5LiB3 aGVuIGkgZm91bmQgdGhhdCwgd2UgCm1hZGUgYSBkaXNjdXNzaW9uIHRvIGRlY2lkZSB3aGV0aGVy IHRvIHJlY292ZXIgdGhlIHNlcmllcyBvZiBwYXRjaGVzIAphYm91dCBNTUMgc3ViIGNsb2NrIGZy YW1ld29yaywgZmluYWxseSwgc2VlIHRoZSBkZXNjcmlwdGlvbiBmcm9tIGNvdmVyIApsZXR0ZXIs IHdlIHBsYW4gdG8gYWJhbmRvbiBpdCBhbmQgYWRvcHQgdGhlIG5ldyBjbG9jayBzY2hlbWUgaW4g dGhpcyAKc2VyaWVzIG9mIHBhdGNoZXMuCgpUaGFua3MuCgo+PiBiLiBpZiBpdCBmYWxscyBiYWNr IHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywgaXQgc2VlbXMg dGhhdCB3ZSBoYXZlIHRvIHByZXNlcnZlIHRoZSBjb2RlIG9mIHRoZSBvbGQgY2xvY2sgc2V0dGlu ZyBpbiBuZmNfY2xrX2luaXQoKS4KPiAKPiBZZXMsIHByb2JhYmx5Lgo+IAo+PiBkbyB3ZSBzdGls bCBuZWVkIHRvIGF2b2lkIGJyZWFrIERUIGNvbXBhdGliaWxpdHk/Cj4gCj4gV2Ugc2hvdWxkIHRy eSBvdXIgYmVzdCB0byBhdm9pZCBicmVha2luZyB0aGUgRFQsIHllcy4KPiAKPj4KPj4gVGhhbmtz Lgo+Pgo+PiBPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlhbmcgd3JvdGU6Cj4+Pj4+ICDCoMKg wqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+Pj4+PiAtwqDCoMKgIHJlcyA9IHBsYXRmb3JtX2dldF9y ZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7Cj4+Pj4+IC3CoMKgwqAgbmZjLT5yZWdf YmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7Cj4+Pj4+ICvCoMKgwqAgbmZj LT5yZWdfYmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9ieW5hbWUocGRldiwg Im5mYyIpOwo+Pj4+Cj4+Pj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdW5yZWxhdGVkLgo+Pj4KPj4+IFRv IGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUgZm9sbG93aW5nID4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFw X3Jlc291cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdlID4gZG9u J3QgbmVlZCBpdD8+Cj4+Pj4+ICDCoMKgwqDCoMKgIGlmIChJU19FUlIobmZjLT5yZWdfYmFzZSkp Cj4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfYmFzZSk7 Cj4+Pj4+IC3CoMKgwqAgbmZjLT5yZWdfY2xrID0KPj4+Pj4gLcKgwqDCoMKgwqDCoMKgIHN5c2Nv bl9yZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUoZGV2LT5vZl9ub2RlLAo+Pj4+PiAtwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiYW1sb2dpYyxtbWMtc3lzY29u Iik7Cj4+Pj4+IC3CoMKgwqAgaWYgKElTX0VSUihuZmMtPnJlZ19jbGspKSB7Cj4+Pj4+IC3CoMKg wqDCoMKgwqDCoCBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBsb29rdXAgY2xvY2sgYmFzZVxuIik7 Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihuZmMtPnJlZ19jbGspOwo+Pj4+ PiAtwqDCoMKgIH0KPj4+Pj4gK8KgwqDCoCBuZmMtPnNkX2VtbWNfY2xvY2sgPSBkZXZtX3BsYXRm b3JtX2lvcmVtYXBfcmVzb3VyY2VfYnluYW1lKHBkZXYsID4+PiAiZW1tYyIpOwo+Pj4+PiArwqDC oMKgIGlmIChJU19FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKSkKPj4+Pj4gK8KgwqDCoMKgwqDCoMKg IHJldHVybiBQVFJfRVJSKG5mYy0+c2RfZW1tY19jbG9jayk7Cj4+Pj4KPj4+PiBXaGlsZSBJIGFn cmVlIHRoaXMgaXMgbXVjaCBiZXR0ZXIgdGhhbiB0aGUgcHJldmlvdXMgc29sdXRpb24sIHdlIGNh bm5vdAo+Pj4+IGJyZWFrIERUIGNvbXBhdGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0 aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQKPj4+PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxi YWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLgo+Pj4KPj4+IG9rLCBpIHdpbGwgZml4IGl0IG5leHQg dmVyc2lvbi4gdGhhbmtzLgo+Pj4gICAgCj4+Pj4gICAKPj4+Pj4gIMKgwqDCoMKgwqAgaXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKPiAKPiAKPiBUaGFua3MsCj4gTWlxdcOobAo+IAo+ IC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 540AEC433FE for ; Tue, 19 Apr 2022 09:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xlUp6YPp6MHbj54g1TqY05VR8LQb02VBha2SeEwM8dA=; b=Lz4zVaciMVtclV no2EDtmk+BdI9oD4KyQoBsDHnQRKMWdnWIMlY7BQUPsmRTk0iy0p3W0ahSjIChsvko81nw/4j54ig nnIp5+JGpIGoEERR71AW9wzBEpq3/UDsN2G6qF8iHbODdus64MW5TJM+ZylvynHU+wwIFzjdLLPLE uq6ludFlO5l5bP0vwxjhSnOagEUcLvISAHaOhB0Y024UO75YQjQMKBKWSzUUBHbVZ9BhliEQYJiSo XQT6my325OwncgVRs7BdaA4urdeX6+IJB5//14p6Ob++ebmLngHpjoyy4gXlS6uANjOrt6jWuN7f3 8FiHL4vWFu//8pXwaizg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjzi-002WNj-CS; Tue, 19 Apr 2022 09:17:58 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjzf-002WLF-5N; Tue, 19 Apr 2022 09:17:56 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 19 Apr 2022 17:17:48 +0800 Message-ID: <2e382e3e-c231-c9e4-73a1-0637288fcd4f@amlogic.com> Date: Tue, 19 Apr 2022 17:17:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> <20220419102629.1c77aa2a@xps13> From: Liang Yang In-Reply-To: <20220419102629.1c77aa2a@xps13> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_021755_256746_69C636F3 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGVsbG8gTWlxdWVsLAoKT24gMjAyMi80LzE5IDE2OjI2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ IFsgRVhURVJOQUwgRU1BSUwgXQo+IAo+IEhlbGxvLAo+IAo+IGxpYW5nLnlhbmdAYW1sb2dpYy5j b20gd3JvdGUgb24gTW9uLCAxOCBBcHIgMjAyMiAxMTo0MDoxMCArMDgwMDoKPiAKPj4gSGkgTWlx dWVsLAo+Pgo+PiBpIGhhdmUgc29tZSBjb25mdXNpb24gd2hlbiBpIHByZXBhcmUgdGhlIHBhdGNo ZXMuIGZvciBEVCBjb21wYXRpYmlsaXR5LCBpdCBmYWxscyBiYWNrIHRvIHRoZSBvbGQgRFQgd2hl biBmYWlsZWQgdG8gZ2V0IHJlc291cmNlIGJ5IHRoZSBuZXcgRFQsIGJ1dCB0aGVyZSBpcyBzb21l IHBvaW50czoKPj4gYS4gb2xkIERUIGRlcGVuZHMgb24gTU1DIHN1YiBjbG9jayBkcml2ZXIsIGJ1 dCBpdCBuZXZlciBiZSBtZXJnZWQsIHNvIGl0IGNhbid0IHdvcmsuCj4gCj4gSSBkb24ndCBnZXQg d2hhdCB5b3UgbWVhbiBoZXJlLCBzb3JyeS4gSSBiZWxpZXZlIHRoZXJlIGlzIGEgbmV3IHdheSB0 bwo+IGRlc2NyaWJlIHRoaXMgY2xvY2sgYnV0IGdyYWJiaW5nIHRoZSBvbmUgZnJvbSB0aGUgTU1D IHN0aWxsIHdvcmtzLCBkb2VzCj4gbm90IGl0Pwo+IAoKTm8sIGl0IGRvZXNuJ3QuIGFmdGVyIHRo ZSBORkMgZHJpdmVyIHVzaW5nIHRoZSBNTUMgc3ViIGNsb2NrIGZyYW1ld29yayAKd2FzIG1lcmdl ZCBpbnRvIHRoZSBtYWlubGluZSBvZiBrZXJuZWwsIHdlIGRpZG4ndCBjb250aW51ZSB0byBzdWJt aXQgdGhlIApzZXJpZXMgb2YgcGF0Y2hlcyBhYm91dCBNTUMgc3ViIGNsb2NrIGFmdGVyIHY5LiB3 aGVuIGkgZm91bmQgdGhhdCwgd2UgCm1hZGUgYSBkaXNjdXNzaW9uIHRvIGRlY2lkZSB3aGV0aGVy IHRvIHJlY292ZXIgdGhlIHNlcmllcyBvZiBwYXRjaGVzIAphYm91dCBNTUMgc3ViIGNsb2NrIGZy YW1ld29yaywgZmluYWxseSwgc2VlIHRoZSBkZXNjcmlwdGlvbiBmcm9tIGNvdmVyIApsZXR0ZXIs IHdlIHBsYW4gdG8gYWJhbmRvbiBpdCBhbmQgYWRvcHQgdGhlIG5ldyBjbG9jayBzY2hlbWUgaW4g dGhpcyAKc2VyaWVzIG9mIHBhdGNoZXMuCgpUaGFua3MuCgo+PiBiLiBpZiBpdCBmYWxscyBiYWNr IHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywgaXQgc2VlbXMg dGhhdCB3ZSBoYXZlIHRvIHByZXNlcnZlIHRoZSBjb2RlIG9mIHRoZSBvbGQgY2xvY2sgc2V0dGlu ZyBpbiBuZmNfY2xrX2luaXQoKS4KPiAKPiBZZXMsIHByb2JhYmx5Lgo+IAo+PiBkbyB3ZSBzdGls bCBuZWVkIHRvIGF2b2lkIGJyZWFrIERUIGNvbXBhdGliaWxpdHk/Cj4gCj4gV2Ugc2hvdWxkIHRy eSBvdXIgYmVzdCB0byBhdm9pZCBicmVha2luZyB0aGUgRFQsIHllcy4KPiAKPj4KPj4gVGhhbmtz Lgo+Pgo+PiBPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlhbmcgd3JvdGU6Cj4+Pj4+ICDCoMKg wqDCoMKgIG5mYy0+ZGV2ID0gZGV2Owo+Pj4+PiAtwqDCoMKgIHJlcyA9IHBsYXRmb3JtX2dldF9y ZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7Cj4+Pj4+IC3CoMKgwqAgbmZjLT5yZWdf YmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7Cj4+Pj4+ICvCoMKgwqAgbmZj LT5yZWdfYmFzZSA9IGRldm1fcGxhdGZvcm1faW9yZW1hcF9yZXNvdXJjZV9ieW5hbWUocGRldiwg Im5mYyIpOwo+Pj4+Cj4+Pj4gVGhpcyBjaGFuZ2Ugc2VlbXMgdW5yZWxhdGVkLgo+Pj4KPj4+IFRv IGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUgZm9sbG93aW5nID4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFw X3Jlc291cmNlX2J5bmFtZShwZGV2LCAiZW1tYyIpLiBkbyB5b3UgbWVhbiB0aGF0IHdlID4gZG9u J3QgbmVlZCBpdD8+Cj4+Pj4+ICDCoMKgwqDCoMKgIGlmIChJU19FUlIobmZjLT5yZWdfYmFzZSkp Cj4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfYmFzZSk7 Cj4+Pj4+IC3CoMKgwqAgbmZjLT5yZWdfY2xrID0KPj4+Pj4gLcKgwqDCoMKgwqDCoMKgIHN5c2Nv bl9yZWdtYXBfbG9va3VwX2J5X3BoYW5kbGUoZGV2LT5vZl9ub2RlLAo+Pj4+PiAtwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiYW1sb2dpYyxtbWMtc3lzY29u Iik7Cj4+Pj4+IC3CoMKgwqAgaWYgKElTX0VSUihuZmMtPnJlZ19jbGspKSB7Cj4+Pj4+IC3CoMKg wqDCoMKgwqDCoCBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBsb29rdXAgY2xvY2sgYmFzZVxuIik7 Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gUFRSX0VSUihuZmMtPnJlZ19jbGspOwo+Pj4+ PiAtwqDCoMKgIH0KPj4+Pj4gK8KgwqDCoCBuZmMtPnNkX2VtbWNfY2xvY2sgPSBkZXZtX3BsYXRm b3JtX2lvcmVtYXBfcmVzb3VyY2VfYnluYW1lKHBkZXYsID4+PiAiZW1tYyIpOwo+Pj4+PiArwqDC oMKgIGlmIChJU19FUlIobmZjLT5zZF9lbW1jX2Nsb2NrKSkKPj4+Pj4gK8KgwqDCoMKgwqDCoMKg IHJldHVybiBQVFJfRVJSKG5mYy0+c2RfZW1tY19jbG9jayk7Cj4+Pj4KPj4+PiBXaGlsZSBJIGFn cmVlIHRoaXMgaXMgbXVjaCBiZXR0ZXIgdGhhbiB0aGUgcHJldmlvdXMgc29sdXRpb24sIHdlIGNh bm5vdAo+Pj4+IGJyZWFrIERUIGNvbXBhdGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0 aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQKPj4+PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxi YWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLgo+Pj4KPj4+IG9rLCBpIHdpbGwgZml4IGl0IG5leHQg dmVyc2lvbi4gdGhhbmtzLgo+Pj4gICAgCj4+Pj4gICAKPj4+Pj4gIMKgwqDCoMKgwqAgaXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKPiAKPiAKPiBUaGFua3MsCj4gTWlxdcOobAo+IAo+ IC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK