From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N7dws-00038w-T7 for mharc-grub-devel@gnu.org; Mon, 09 Nov 2009 18:47:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7dwr-00038G-AV for grub-devel@gnu.org; Mon, 09 Nov 2009 18:47:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7dwl-00037R-TR for grub-devel@gnu.org; Mon, 09 Nov 2009 18:47:00 -0500 Received: from [199.232.76.173] (port=52395 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7dwl-00037O-Nj for grub-devel@gnu.org; Mon, 09 Nov 2009 18:46:55 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:47458) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7dwl-0001bW-A2 for grub-devel@gnu.org; Mon, 09 Nov 2009 18:46:55 -0500 Received: by bwz7 with SMTP id 7so4185882bwz.26 for ; Mon, 09 Nov 2009 15:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=/X6CiDr68EuIBhpk81Oxb4ST+uyPONulg7PVu62ntLk=; b=A4M3+5e1prfakITEHCWyXe4dC2Kf1OG8ykPg/AnvjNgR/pJ3JePDVAsKZMX0fpHMv2 4avNbm16nHMoGxuJjfWy32ahBukOpLdhQq6pgNrjUvSZbtjsHCya8bCFxyFVTeN1Yw3M ExvYIDsxRi68fOy10/vbkepN7C2nVreCww08c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=SgvYcnLbDEnONGev+10jYFllMgY8Z4T5CkySdgZs93hdNz03gBYBgpB2+Yl/Gl9C6E GTuhJzRkRxuPIlDyQ3XAyi9PPp7h2kc85CC61QQo2ZpzeuPOVLq5C2MFYhFzPJtni/Ow dZIHMj6+KB87/bRfkdlvaE4vDGcqjPCs1+Lnk= MIME-Version: 1.0 Received: by 10.239.237.193 with SMTP id k1mr861576hbp.173.1257810413359; Mon, 09 Nov 2009 15:46:53 -0800 (PST) In-Reply-To: <4AF89BC1.5040608@duboucher.eu> References: <4AF85568.7080105@duboucher.eu> <20091109182518.GA14767@thorin> <4AF86387.7090307@gmail.com> <4AF885EE.7000709@duboucher.eu> <4AF88AEF.8010102@gmail.com> <4AF88D14.2030108@duboucher.eu> <20091109220654.GA22226@thorin> <4AF89BC1.5040608@duboucher.eu> Date: Mon, 9 Nov 2009 17:46:53 -0600 Message-ID: <2e59e6970911091546u7f825fael4011542eedb37b6e@mail.gmail.com> From: "richardvoigt@gmail.com" To: The development of GNU GRUB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Imminent bugfix release (1.97.1) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 23:47:01 -0000 On Mon, Nov 9, 2009 at 4:46 PM, Duboucher Thomas wrot= e: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Robert Millan a =C3=A9crit : >> On Mon, Nov 09, 2009 at 10:43:48PM +0100, Duboucher Thomas wrote: >>> =C2=A0 =C2=A0 =C2=A0Well, the only way to solve that problem would be I= MHO to add a limit >>> to the size of s2, and use this maximum size as an end condition for th= e >>> 'for' statement. Any better idea? :) >> >> We have a maximum line read size anyway. =C2=A0If we do this, we might a= s >> well make that limit global so that the macro can be shared with >> this routine. >> > > Sounds good to me. :) > Any ideas for renaming s1 and s2? correct_key and attempted_key But there seems to still be potential for overflow on one of the strings. Are both strings in fixed-equal-length buffers? That should be clearly documented. > > Thomas. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAkr4m8EACgkQBV7eXqefhqj9SgCgjHomnoIkzzu5WuTCZQVcB/8t > cwcAn1EkevCL3PXGlIuhLzFPlER9fXD3 > =3DokR/ > -----END PGP SIGNATURE----- > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel >