From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD84C10F13 for ; Thu, 11 Apr 2019 19:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 742E32173C for ; Thu, 11 Apr 2019 19:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbfDKTRp (ORCPT ); Thu, 11 Apr 2019 15:17:45 -0400 Received: from foss.arm.com ([217.140.101.70]:48126 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbfDKTRo (ORCPT ); Thu, 11 Apr 2019 15:17:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15EEF374; Thu, 11 Apr 2019 12:17:44 -0700 (PDT) Received: from [192.168.1.123] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A2D43F59C; Thu, 11 Apr 2019 12:17:42 -0700 (PDT) Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs From: Robin Murphy To: Heiko Stuebner Cc: Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190321162244.10080-1-katsuhiro@katsuster.net> <14265087.Gbs4YZABJo@phil> <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> <2463729.IUJ8mRE5Ts@phil> <8d164cfe-c345-aa45-aaf3-11983f9142e5@arm.com> Message-ID: <2e5a1468-9a65-9cc5-f96c-272faeb92ec9@arm.com> Date: Thu, 11 Apr 2019 20:17:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <8d164cfe-c345-aa45-aaf3-11983f9142e5@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-04-11 2:48 pm, Robin Murphy wrote: > On 11/04/2019 13:46, Heiko Stuebner wrote: >> Hi Robin, >> >> Am Samstag, 30. März 2019, 00:24:16 CEST schrieb Robin Murphy: >>> On 2019-03-27 12:00 pm, Heiko Stuebner wrote: >>>> Hi, >>>> >>>> Am Dienstag, 26. März 2019, 14:49:16 CET schrieb Katsuhiro Suzuki: >>>>> Hello Robin, >>>>> >>>>> Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs, >>>>> please revert my patch if you need. >>>> >>>> I've dropped the patch from my queue now. >>>> >>>>> BTW, there are DMA properties in RK3328 device-tree like as this >>>>> patch. >>>>> RK3328 UART DMA could not work correctly too...?? >>>> >>>> I remember Rockcihip dma-controllers having issues with burst-sizes >>>> and flushing (there is a no-flushp option in pl330), so it's >>>> possible that all share the same error up to rk3399 and rk3328 >>>> >>>> But so far no-one has shouted regarding the rk3328. >>> >>> Let me be the first, then, I guess :) >>> >>> I found an easy way to observe the problem on my 3399, and I've just >>> fired up my 3328 box with a 5.0 distro kernel to find that it behaves >>> the same. Basically just dump a large pile of text into 'less' on the >>> serial console, and scroll through line-by-line - certain lines get >>> dropped except for a few characters at the end. >>> >>> I'll see if I can narrow it down a bit, starting with trying >>> broken-flushp... >> >> did you manage to find time for that test you wanted to do? > > Sadly not - I got somewhat distracted by the ethernet thing, and since > then I've had too much else going on to follow up on any of my 'for fun' > projects :( Urgh, and it turns out what I thought were dropped characters seems to just be my console handling line wrapping weirdly, so now I have no idea if RK3328 actually has an issue, and coming up with a reliable reproducer for RK3399 is going to take some thought... Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs Date: Thu, 11 Apr 2019 20:17:36 +0100 Message-ID: <2e5a1468-9a65-9cc5-f96c-272faeb92ec9@arm.com> References: <20190321162244.10080-1-katsuhiro@katsuster.net> <14265087.Gbs4YZABJo@phil> <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> <2463729.IUJ8mRE5Ts@phil> <8d164cfe-c345-aa45-aaf3-11983f9142e5@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8d164cfe-c345-aa45-aaf3-11983f9142e5@arm.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Heiko Stuebner Cc: Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxOS0wNC0xMSAyOjQ4IHBtLCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gT24gMTEvMDQvMjAx OSAxMzo0NiwgSGVpa28gU3R1ZWJuZXIgd3JvdGU6Cj4+IEhpIFJvYmluLAo+Pgo+PiBBbSBTYW1z dGFnLCAzMC4gTcOkcnogMjAxOSwgMDA6MjQ6MTYgQ0VTVCBzY2hyaWViIFJvYmluIE11cnBoeToK Pj4+IE9uIDIwMTktMDMtMjcgMTI6MDAgcG0sIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+Pj4+IEhp LAo+Pj4+Cj4+Pj4gQW0gRGllbnN0YWcsIDI2LiBNw6RyeiAyMDE5LCAxNDo0OToxNiBDRVQgc2No cmllYiBLYXRzdWhpcm8gU3V6dWtpOgo+Pj4+PiBIZWxsbyBSb2JpbiwKPj4+Pj4KPj4+Pj4gU29y cnkgZm9yIGluY29udmVuaWVuY2UuIFNpbmNlIEkgZG9uJ3QgYWRoZXJlIGVuYWJsaW5nIERNQSBm b3IgVUFSVHMsCj4+Pj4+IHBsZWFzZSByZXZlcnQgbXkgcGF0Y2ggaWYgeW91IG5lZWQuCj4+Pj4K Pj4+PiBJJ3ZlIGRyb3BwZWQgdGhlIHBhdGNoIGZyb20gbXkgcXVldWUgbm93Lgo+Pj4+Cj4+Pj4+ IEJUVywgdGhlcmUgYXJlIERNQSBwcm9wZXJ0aWVzIGluIFJLMzMyOCBkZXZpY2UtdHJlZSBsaWtl IGFzIHRoaXMgCj4+Pj4+IHBhdGNoLgo+Pj4+PiBSSzMzMjggVUFSVCBETUEgY291bGQgbm90IHdv cmsgY29ycmVjdGx5IHRvby4uLj8/Cj4+Pj4KPj4+PiBJIHJlbWVtYmVyIFJvY2tjaWhpcCBkbWEt Y29udHJvbGxlcnMgaGF2aW5nIGlzc3VlcyB3aXRoIGJ1cnN0LXNpemVzCj4+Pj4gYW5kIGZsdXNo aW5nICh0aGVyZSBpcyBhIG5vLWZsdXNocCBvcHRpb24gaW4gcGwzMzApLCBzbyBpdCdzCj4+Pj4g cG9zc2libGUgdGhhdCBhbGwgc2hhcmUgdGhlIHNhbWUgZXJyb3IgdXAgdG8gcmszMzk5IGFuZCBy azMzMjgKPj4+Pgo+Pj4+IEJ1dCBzbyBmYXIgbm8tb25lIGhhcyBzaG91dGVkIHJlZ2FyZGluZyB0 aGUgcmszMzI4Lgo+Pj4KPj4+IExldCBtZSBiZSB0aGUgZmlyc3QsIHRoZW4sIEkgZ3Vlc3MgOikK Pj4+Cj4+PiBJIGZvdW5kIGFuIGVhc3kgd2F5IHRvIG9ic2VydmUgdGhlIHByb2JsZW0gb24gbXkg MzM5OSwgYW5kIEkndmUganVzdAo+Pj4gZmlyZWQgdXAgbXkgMzMyOCBib3ggd2l0aCBhIDUuMCBk aXN0cm8ga2VybmVsIHRvIGZpbmQgdGhhdCBpdCBiZWhhdmVzCj4+PiB0aGUgc2FtZS4gQmFzaWNh bGx5IGp1c3QgZHVtcCBhIGxhcmdlIHBpbGUgb2YgdGV4dCBpbnRvICdsZXNzJyBvbiB0aGUKPj4+ IHNlcmlhbCBjb25zb2xlLCBhbmQgc2Nyb2xsIHRocm91Z2ggbGluZS1ieS1saW5lIC0gY2VydGFp biBsaW5lcyBnZXQKPj4+IGRyb3BwZWQgZXhjZXB0IGZvciBhIGZldyBjaGFyYWN0ZXJzIGF0IHRo ZSBlbmQuCj4+Pgo+Pj4gSSdsbCBzZWUgaWYgSSBjYW4gbmFycm93IGl0IGRvd24gYSBiaXQsIHN0 YXJ0aW5nIHdpdGggdHJ5aW5nCj4+PiBicm9rZW4tZmx1c2hwLi4uCj4+Cj4+IGRpZCB5b3UgbWFu YWdlIHRvIGZpbmQgdGltZSBmb3IgdGhhdCB0ZXN0IHlvdSB3YW50ZWQgdG8gZG8/Cj4gCj4gU2Fk bHkgbm90IC0gSSBnb3Qgc29tZXdoYXQgZGlzdHJhY3RlZCBieSB0aGUgZXRoZXJuZXQgdGhpbmcs IGFuZCBzaW5jZSAKPiB0aGVuIEkndmUgaGFkIHRvbyBtdWNoIGVsc2UgZ29pbmcgb24gdG8gZm9s bG93IHVwIG9uIGFueSBvZiBteSAnZm9yIGZ1bicgCj4gcHJvamVjdHMgOigKClVyZ2gsIGFuZCBp dCB0dXJucyBvdXQgd2hhdCBJIHRob3VnaHQgd2VyZSBkcm9wcGVkIGNoYXJhY3RlcnMgc2VlbXMg dG8gCmp1c3QgYmUgbXkgY29uc29sZSBoYW5kbGluZyBsaW5lIHdyYXBwaW5nIHdlaXJkbHksIHNv IG5vdyBJIGhhdmUgbm8gaWRlYSAKaWYgUkszMzI4IGFjdHVhbGx5IGhhcyBhbiBpc3N1ZSwgYW5k IGNvbWluZyB1cCB3aXRoIGEgcmVsaWFibGUgCnJlcHJvZHVjZXIgZm9yIFJLMzM5OSBpcyBnb2lu ZyB0byB0YWtlIHNvbWUgdGhvdWdodC4uLgoKUm9iaW4uCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==