All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Sumit Semwal <sumit.semwal@linaro.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: will.deacon@arm.com, panand@redhat.com, paul.elder@pitt.edu,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: breakpoints: fix compile error on breakpoint_test_arm64
Date: Wed, 1 Nov 2017 14:52:51 -0600	[thread overview]
Message-ID: <2e612e6a-8bf9-4852-d259-ec436f64d886@kernel.org> (raw)
In-Reply-To: <1508744542-11181-1-git-send-email-sumit.semwal@linaro.org>

On 10/23/2017 01:42 AM, Sumit Semwal wrote:
> The current mainline breakpoints test for arm64 fails to compile with
> 
> breakpoint_test_arm64.c: In function ‘set_watchpoint’:
> breakpoint_test_arm64.c:97:28: error: storage size of ‘dreg_state’ isn’t known
>   struct user_hwdebug_state dreg_state;
> 
> Adding a direct include for asm/ptrace.h helps it to build, and passes
> the test on mainline on hikey.
> 
> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
> ---
>  tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index 960d02100c26..2d95e5adde72 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -19,6 +19,7 @@
>  
>  #define _GNU_SOURCE
>  
> +#include <asm/ptrace.h>
>  #include <sys/types.h>
>  #include <sys/wait.h>
>  #include <sys/ptrace.h>
> 

Sumit,

Thanks for the patch. I will queue this up for 4.15-rc1.
This can be marked for stable I would assume?

thanks,
-- Shuah

  reply	other threads:[~2017-11-01 20:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23  7:42 [PATCH] selftests: breakpoints: fix compile error on breakpoint_test_arm64 Sumit Semwal
2017-11-01 20:52 ` Shuah Khan [this message]
2017-11-03  3:48   ` Sumit Semwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e612e6a-8bf9-4852-d259-ec436f64d886@kernel.org \
    --to=shuah@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=panand@redhat.com \
    --cc=paul.elder@pitt.edu \
    --cc=shuahkh@osg.samsung.com \
    --cc=sumit.semwal@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.