All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/2] ethdev: move log macro to header
Date: Wed, 2 May 2018 10:40:08 +0100	[thread overview]
Message-ID: <2e6566e2-3142-e240-d260-e511c7e7fbf4@intel.com> (raw)
In-Reply-To: <2051771.Q7AAqi1qgL@xps>

On 5/1/2018 7:56 PM, Thomas Monjalon wrote:
> 01/05/2018 19:28, Ferruh Yigit:
>> --- a/lib/librte_ethdev/rte_ethdev.c
>> +++ b/lib/librte_ethdev/rte_ethdev.c
>> -static int ethdev_logtype;
>> -
>> -#define ethdev_log(level, fmt, ...) \
>> -	rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ## __VA_ARGS__)
>> +int ethdev_logtype;
>>  
> [...]
>> --- a/lib/librte_ethdev/rte_ethdev.h
>> +++ b/lib/librte_ethdev/rte_ethdev.h
>> +extern int ethdev_logtype;
>> +
>> +#define RTE_ETHDEV_LOG(level, fmt, ...) \
>> +	rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ## __VA_ARGS__)
> 
> Why moving this macro in the header file? For using it in inline functions?
> Probably worth an explanation in the commit message.

Yes mainly for RTE_PMD_DEBUG_TRACE usage in header file. The ones in
RTE_ETH_VALID_PORTID_... macros and inline functions, which I didn't update in
this set.

I will update the commit log.

  reply	other threads:[~2018-05-02  9:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 17:28 [PATCH 1/2] ethdev: move log macro to header Ferruh Yigit
2018-05-01 17:28 ` [PATCH 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-05-01 18:56 ` [PATCH 1/2] ethdev: move log macro to header Thomas Monjalon
2018-05-02  9:40   ` Ferruh Yigit [this message]
2018-05-02 14:45     ` Stephen Hemminger
2018-05-09 14:24 ` [PATCH v2 " Ferruh Yigit
2018-05-09 14:24   ` [PATCH v2 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-05-14 15:56   ` [PATCH v3 1/2] ethdev: move log macro to header Ferruh Yigit
2018-05-14 15:56     ` [PATCH v3 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-06-19  1:04     ` [PATCH v4 1/3] ethdev: move log macro to header Ferruh Yigit
2018-06-19  1:04       ` [PATCH v4 2/3] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-06-19 13:11         ` Andrew Rybchenko
2018-06-19  1:04       ` [PATCH v4 3/3] eal: don't enable static log macro for ethdev Ferruh Yigit
2018-06-19 13:02       ` [PATCH v4 1/3] ethdev: move log macro to header Andrew Rybchenko
2018-06-26 11:41       ` Shahaf Shuler
2018-06-26 12:25         ` Thomas Monjalon
2018-06-26 15:52           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e6566e2-3142-e240-d260-e511c7e7fbf4@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.