From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E32C433DB for ; Mon, 22 Feb 2021 11:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E5D164E27 for ; Mon, 22 Feb 2021 11:44:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230041AbhBVLoB (ORCPT ); Mon, 22 Feb 2021 06:44:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:40388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229947AbhBVLn7 (ORCPT ); Mon, 22 Feb 2021 06:43:59 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1F3764ED6; Mon, 22 Feb 2021 11:43:16 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lE9cP-00FJBa-Ih; Mon, 22 Feb 2021 11:43:13 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 22 Feb 2021 11:43:13 +0000 From: Marc Zyngier To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, marcan@marcan.st, tglx@linutronix.de, will@kernel.org Subject: Re: [PATCH 5/8] arm64: irq: add a default handle_irq panic function In-Reply-To: <20210222112544.GB70951@C02TD0UTHF1T.local> References: <20210219113904.41736-1-mark.rutland@arm.com> <20210219113904.41736-6-mark.rutland@arm.com> <20210222095913.GA70951@C02TD0UTHF1T.local> <1d2c27d72b9b2cbdb83d25165a20559a@kernel.org> <20210222112544.GB70951@C02TD0UTHF1T.local> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <2e6a9659eabcccb355318ff7214c8d1f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, marcan@marcan.st, tglx@linutronix.de, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-02-22 11:25, Mark Rutland wrote: > On Mon, Feb 22, 2021 at 10:48:11AM +0000, Marc Zyngier wrote: >> On 2021-02-22 09:59, Mark Rutland wrote: >> > On Fri, Feb 19, 2021 at 11:39:01AM +0000, Mark Rutland wrote: >> > > +void (*handle_arch_irq)(struct pt_regs *) __ro_after_init = >> > > default_handle_irq; >> > > >> > > int __init set_handle_irq(void (*handle_irq)(struct pt_regs *)) >> > > { >> > > - if (handle_arch_irq) >> > > + if (handle_arch_irq != default_handle_irq) >> > > return -EBUSY; >> > > >> > > handle_arch_irq = handle_irq; >> > > @@ -87,7 +92,7 @@ void __init init_IRQ(void) >> > > init_irq_stacks(); >> > > init_irq_scs(); >> > > irqchip_init(); >> > > - if (!handle_arch_irq) >> > > + if (handle_arch_irq == default_handle_irq) >> > > panic("No interrupt controller found."); >> >> It also seems odd to have both default_handle_irq() that panics, >> and init_IRQ that panics as well. Not a big deal, but maybe >> we should just drop this altogether and get the firework on the >> first interrupt. > > My gut feeling was that both were useful, and served slightly different > cases: > > * The panic in default_handle_irq() helps if we unexpectedly unmask IRQ > too early. This is mostly a nicety over the current behaviour of > branching to NULL in this case. > > * The panic in init_IRQ() gives us a consistent point at which we can > note the absence of a root IRQ controller even if all IRQs are > quiescent. This is a bit nicer to debug than seeing a load of driver > probes fail their request_irq() or whatever. > > ... so I'd err on the side of keeping both, but if you think otherwise > I'm happy to change this. As I said, it's not a big deal. I doubt that we'll see default_handle_irq() exploding in practice. But the real nit here is the difference of treatment between IRQ and FIQ. *IF* we ever get a system that only signals its interrupt as FIQ (and I don't see why we'd forbid that), then we would To be clear, I don't think we should care too much either way, and I'm fine with the code as is. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B313C433E0 for ; Mon, 22 Feb 2021 11:44:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAC1D64E27 for ; Mon, 22 Feb 2021 11:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAC1D64E27 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wMEb6eFNgXn6U/HAGEG6X8JubQf2icJmcyzMAooLg7s=; b=snQr7kHaSYn0PuehgU1TzcHN/ g+Grvu7f8FL17HbXvM3Ft7G7m8aH0Pn1/yAywEFUIgOmkn/yKkVzg5bDB7H5evGNho/So8tt0TDio CI0MVBiJUc/tqULN6iN++R/g010rWvLm0kA9DcWv5fLZRZuoFquu9DM3hxn/Oven1/QX3QTRXxuYP oTjCr6ew8UfIEHAWYFENGEstwZUbvnWRssnXAiEo4HnT9v5r8fmzZuzWjalK10wVuc91nxDK/nPUU CQzTQOg8SmKdlI67mVDEjRim9EIRz9Q5exfxlD7sTMCRS9vnNcI0JyuOZ+meL1b7pMxLYxLFDVFgn 2U+VYWWag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE9cW-0006vf-Ri; Mon, 22 Feb 2021 11:43:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE9cU-0006v0-C5 for linux-arm-kernel@lists.infradead.org; Mon, 22 Feb 2021 11:43:19 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1F3764ED6; Mon, 22 Feb 2021 11:43:16 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lE9cP-00FJBa-Ih; Mon, 22 Feb 2021 11:43:13 +0000 MIME-Version: 1.0 Date: Mon, 22 Feb 2021 11:43:13 +0000 From: Marc Zyngier To: Mark Rutland Subject: Re: [PATCH 5/8] arm64: irq: add a default handle_irq panic function In-Reply-To: <20210222112544.GB70951@C02TD0UTHF1T.local> References: <20210219113904.41736-1-mark.rutland@arm.com> <20210219113904.41736-6-mark.rutland@arm.com> <20210222095913.GA70951@C02TD0UTHF1T.local> <1d2c27d72b9b2cbdb83d25165a20559a@kernel.org> <20210222112544.GB70951@C02TD0UTHF1T.local> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <2e6a9659eabcccb355318ff7214c8d1f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, james.morse@arm.com, marcan@marcan.st, tglx@linutronix.de, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210222_064318_531179_818C7B22 X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, james.morse@arm.com, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-02-22 11:25, Mark Rutland wrote: > On Mon, Feb 22, 2021 at 10:48:11AM +0000, Marc Zyngier wrote: >> On 2021-02-22 09:59, Mark Rutland wrote: >> > On Fri, Feb 19, 2021 at 11:39:01AM +0000, Mark Rutland wrote: >> > > +void (*handle_arch_irq)(struct pt_regs *) __ro_after_init = >> > > default_handle_irq; >> > > >> > > int __init set_handle_irq(void (*handle_irq)(struct pt_regs *)) >> > > { >> > > - if (handle_arch_irq) >> > > + if (handle_arch_irq != default_handle_irq) >> > > return -EBUSY; >> > > >> > > handle_arch_irq = handle_irq; >> > > @@ -87,7 +92,7 @@ void __init init_IRQ(void) >> > > init_irq_stacks(); >> > > init_irq_scs(); >> > > irqchip_init(); >> > > - if (!handle_arch_irq) >> > > + if (handle_arch_irq == default_handle_irq) >> > > panic("No interrupt controller found."); >> >> It also seems odd to have both default_handle_irq() that panics, >> and init_IRQ that panics as well. Not a big deal, but maybe >> we should just drop this altogether and get the firework on the >> first interrupt. > > My gut feeling was that both were useful, and served slightly different > cases: > > * The panic in default_handle_irq() helps if we unexpectedly unmask IRQ > too early. This is mostly a nicety over the current behaviour of > branching to NULL in this case. > > * The panic in init_IRQ() gives us a consistent point at which we can > note the absence of a root IRQ controller even if all IRQs are > quiescent. This is a bit nicer to debug than seeing a load of driver > probes fail their request_irq() or whatever. > > ... so I'd err on the side of keeping both, but if you think otherwise > I'm happy to change this. As I said, it's not a big deal. I doubt that we'll see default_handle_irq() exploding in practice. But the real nit here is the difference of treatment between IRQ and FIQ. *IF* we ever get a system that only signals its interrupt as FIQ (and I don't see why we'd forbid that), then we would To be clear, I don't think we should care too much either way, and I'm fine with the code as is. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel