From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810EBC48BE0 for ; Fri, 11 Jun 2021 10:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FBD5613DE for ; Fri, 11 Jun 2021 10:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231598AbhFKKT3 (ORCPT ); Fri, 11 Jun 2021 06:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbhFKKT2 (ORCPT ); Fri, 11 Jun 2021 06:19:28 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60506C061574 for ; Fri, 11 Jun 2021 03:17:22 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id c5so5450198wrq.9 for ; Fri, 11 Jun 2021 03:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I5tKlQRifKHe2gTRaDd3qimWqkGR/5Q+9YE8hRfMOFE=; b=x71CK+AWs8dBYH4/oH8dY8Z3xpmlOkUVNy4TXzSv4euJ3AmJmGAB26bbUtngVNHqnn GQyWclnY0NyEWUTxAr6GKE7rpelXeFsT3niaTzNuGXC/DShBT5iZ/vo6p1qJ6toflHxr uUKPyPcGx873ePEQCH0slgFPoxPy1Qgh2QJzhv2QSZ6RYsqbzpzLlA7BazHWSTI1xJva KPuekCWeLWWI+eYpQ015qQ1OW8OBzl9mlaveRta+Fm9V2Lhmt3mjQW6wQMq0V9H+g3LB zAqgbiO/J52YKHakEtqF/No8pGELTQB6W3BO4j6trM+a5HtwoU1FOTZMe3798//WJDx/ yboA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I5tKlQRifKHe2gTRaDd3qimWqkGR/5Q+9YE8hRfMOFE=; b=Qgiwb4euNGwN6bfWE9DG+VuncgwmBhUAZjW31RTUOFKf6eXKDjxTi0cb4HoI3motL8 ZsAvowEe7O8flU+opjGipDsjlRgvAzIGwJQgIFpg7Q0Pnl3bNX2uM6eQvHYX25w8UHIB 3z5Y+8KBIF9vTm7elcDQeSB0tiQUbNOm50zFQlU5ukhvPOW5bDgnu+vNe4dkaqu0dOy+ 5uwnXwY02+W9Uhsts265v/KAFj9LBn+ffVFzJnuNYdT6llFtHXvrtkYqs5Rg/wqxVTQf X3R4pppexlMMFz0NpZj0g1qyo9aBYq1JQ8NCuE3CIKIelAhZ3+BDSKZmokJUUNxuMrKc yQxA== X-Gm-Message-State: AOAM531eKOv/bqEzDzC/Rt0uoQ6XFkAFK6RpooCCg/2sgMK4C2afSnt+ B1AWIf9zhYVxHKQid1I2JFVUgA== X-Google-Smtp-Source: ABdhPJypcf6Z6Gvwg4C0r7rXpd7oDghk0GBffhYcniRydvzWIEB0tPvn6x7AEagg9pfTpLjdEjl+YQ== X-Received: by 2002:adf:f207:: with SMTP id p7mr3085756wro.275.1623406641036; Fri, 11 Jun 2021 03:17:21 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id k5sm6838745wrv.85.2021.06.11.03.17.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jun 2021 03:17:20 -0700 (PDT) Subject: Re: [PATCH 4/9] nvmem: sprd: Fix an error message To: Greg KH Cc: linux-kernel@vger.kernel.org, Christophe JAILLET , Chunyan Zhang References: <20210611083348.20170-1-srinivas.kandagatla@linaro.org> <20210611083348.20170-5-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla Message-ID: <2e81821d-5b4d-925d-9d15-7a7ebd6d649d@linaro.org> Date: Fri, 11 Jun 2021 11:17:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2021 10:48, Greg KH wrote: > On Fri, Jun 11, 2021 at 11:45:25AM +0200, Greg KH wrote: >> On Fri, Jun 11, 2021 at 11:17:50AM +0200, Greg KH wrote: >>> On Fri, Jun 11, 2021 at 10:05:40AM +0100, Srinivas Kandagatla wrote: >>>> >>>> >>>> On 11/06/2021 09:56, Greg KH wrote: >>>>> On Fri, Jun 11, 2021 at 09:33:43AM +0100, Srinivas Kandagatla wrote: >>>>>> From: Christophe JAILLET >>>>>> >>>>>> 'ret' is known to be 0 here. >>>>>> The expected error status is stored in 'status', so use it instead. >>>>>> >>>>>> Also change %d in %u, because status is an u32, not a int. >>>>>> >>>>>> Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support") >>>>>> Signed-off-by: Christophe JAILLET >>>>>> Acked-by: Chunyan Zhang >>>>>> Signed-off-by: Srinivas Kandagatla >>>>>> --- >>>>>> drivers/nvmem/sprd-efuse.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c >>>>>> index 5d394559edf2..e3e721d4c205 100644 >>>>>> --- a/drivers/nvmem/sprd-efuse.c >>>>>> +++ b/drivers/nvmem/sprd-efuse.c >>>>>> @@ -234,7 +234,7 @@ static int sprd_efuse_raw_prog(struct sprd_efuse *efuse, u32 blk, bool doub, >>>>>> status = readl(efuse->base + SPRD_EFUSE_ERR_FLAG); >>>>>> if (status) { >>>>>> dev_err(efuse->dev, >>>>>> - "write error status %d of block %d\n", ret, blk); >>>>>> + "write error status %u of block %d\n", status, blk); >>>>> >>>>> Shouldn't this be %pe and not %u? >>>> >>>> This is not error pointer its status value read back from a register. >>>> >>>> I think %u should be good here. >>> >>> Argh, you are right, my fault. For some reason I thought this worked >>> for integers as well. Don't we have such a printk modifier somewhere to >>> turn error values into strings? Let me dig... >> >> Ah, errname() will do it. >> >> Looks like no one uses it, so nevermind, sorry for the noise. I'll go >> apply this one now. > > Does not apply to my tree :( Looks like its already in your tree since May 7th. --srini >