From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10B1C43381 for ; Mon, 25 Feb 2019 19:47:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 732302084D for ; Mon, 25 Feb 2019 19:47:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Srg7xlOd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727174AbfBYTrV (ORCPT ); Mon, 25 Feb 2019 14:47:21 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:35569 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfBYTrV (ORCPT ); Mon, 25 Feb 2019 14:47:21 -0500 Received: by mail-pl1-f196.google.com with SMTP id p19so4980020plo.2; Mon, 25 Feb 2019 11:47:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qQHMEF0T6nFBZ3uL8DF15gBELDockbIZxCoHf6XLRTE=; b=Srg7xlOdRt9mvSZDC1Ycc8YOz+j1syhSbgQR1k7hhX3zKTBr2zZqRk4PhZTNzOEmfn Z/U9pLcGANDchX7qU+MiUYq9t2mgGy0vvADBZJ+0S5JPsqG3eGL3esM+iVIx11jg+57e NEwtE2KytxDuC0xdNE7pEmdgViowpdLXoGeT1osAQhlIq/EYxJbtLeuN3pgSZ4LUUCyz 6gkSSiWIz3b5OIkm99vkIrsAtkC0ilOhu9455cfQ89vxYh15Tyg/VX3wO+HL3VD22Kff rCjLV6hDw5yctXqzuDRpIlJKLGECeG7/ENSMT7kDRJca1+r0IzoFpehamjsIiKuTMbq6 8y3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qQHMEF0T6nFBZ3uL8DF15gBELDockbIZxCoHf6XLRTE=; b=c9Qo20DQ8brZd3F4RPv+NynScK+O0kfJPr72d3QwOrgObj7Qpu0eAFWjZYO/s2qw7e 4bKMmzRxlcuz2XgROUqMDpqwHCCF9HBuN5dUhROFbP/3lc86UnQyNi2fASmj+r7DSH0k LRdWebWzR2T2oVyTb5GXv3O8rgkgUAZBxW+tYkmgJiEY4d1arXxVAMP90GVtdp/HZ3JL IoSUE6WKnrAu8J8UGkAbVGK8aNtnvi/FG5sIyCX+3xa3S8DvBK9mmQ66pBwyRTR6gIns Pq8U6iE7Xe/epPpQ48SwC2N8TgavtI5U8NRMVwoCSbF3tK0oNfaun+8IX3Lrqoxh5nNE ZjEw== X-Gm-Message-State: AHQUAuZzxX4ADwbDTabTJMNop76lKVMtxvhUT4btx0WqUn9MnJE6ujvd cdh2srvlgbxENKQrZeFBOCA= X-Google-Smtp-Source: AHgI3IY3Rw1kcKAcODrw8XvlF0PBDdCuH1d6IOfe1oC/sfX7TNFkMTqJq1dDySXOZ4u4rxQyUx7Umg== X-Received: by 2002:a17:902:14e:: with SMTP id 72mr22060247plb.287.1551124039352; Mon, 25 Feb 2019 11:47:19 -0800 (PST) Received: from [10.67.50.0] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id p2sm21431013pfi.95.2019.02.25.11.47.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:47:18 -0800 (PST) Subject: Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "David S. Miller" , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" , Jiri Pirko , "andrew@lunn.ch" , "vivien.didelot@gmail.com" References: <20190222235927.10295-1-f.fainelli@gmail.com> <20190222235927.10295-8-f.fainelli@gmail.com> <20190223103207.GA13070@splinter> <20190225094940.GA15128@splinter> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <2e91b708-a092-3839-4979-2712145a9951@gmail.com> Date: Mon, 25 Feb 2019 11:47:12 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190225094940.GA15128@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/25/19 1:49 AM, Ido Schimmel wrote: > On Sun, Feb 24, 2019 at 08:47:27AM -0800, Florian Fainelli wrote: >> Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : >>> On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >>>> - if (attr->flags & SWITCHDEV_F_NO_RECURSE) >>>> + if (attr & SWITCHDEV_F_DEFER) >>>> + rc = call_switchdev_blocking_notifiers(nt, dev, >>>> + &attr_info.info, NULL); >>>> + else >>>> + rc = call_switchdev_notifiers(nt, dev, &attr_info.info, NULL); >>> >>> I don't believe this is needed. You're calling this function from >>> switchdev_port_attr_set_now() which is always called from process >>> context. switchdev_port_attr_set() takes care of that. Similar to >>> switchdev_port_obj_add(). >> >> Except for net/bridge/br_switchdev.c when we check the bridge port's >> flags support with PRE_BRIDGE_FLAGS. In that case we are executing from >> the caller (atomic) context and we can't defer otherwise that trumps the >> whole idea of being able to do a quick check and return that to the >> caller that we cannot support specific flags. How would you recommend >> approaching that? > > In this case you can invoke call_switchdev_notifiers() directly from > br_switchdev_set_port_flag(). Eventually switchdev_port_attr_set() will > be gone and bridge code will invoke the notifiers directly. That can be done, but it still requires the target driver (mlxsw, ocelot, dsa, etc.) to support attribute notification from blocking and non-blocking context. Are you fine with that? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qQHMEF0T6nFBZ3uL8DF15gBELDockbIZxCoHf6XLRTE=; b=Srg7xlOdRt9mvSZDC1Ycc8YOz+j1syhSbgQR1k7hhX3zKTBr2zZqRk4PhZTNzOEmfn Z/U9pLcGANDchX7qU+MiUYq9t2mgGy0vvADBZJ+0S5JPsqG3eGL3esM+iVIx11jg+57e NEwtE2KytxDuC0xdNE7pEmdgViowpdLXoGeT1osAQhlIq/EYxJbtLeuN3pgSZ4LUUCyz 6gkSSiWIz3b5OIkm99vkIrsAtkC0ilOhu9455cfQ89vxYh15Tyg/VX3wO+HL3VD22Kff rCjLV6hDw5yctXqzuDRpIlJKLGECeG7/ENSMT7kDRJca1+r0IzoFpehamjsIiKuTMbq6 8y3g== References: <20190222235927.10295-1-f.fainelli@gmail.com> <20190222235927.10295-8-f.fainelli@gmail.com> <20190223103207.GA13070@splinter> <20190225094940.GA15128@splinter> From: Florian Fainelli Message-ID: <2e91b708-a092-3839-4979-2712145a9951@gmail.com> Date: Mon, 25 Feb 2019 11:47:12 -0800 MIME-Version: 1.0 In-Reply-To: <20190225094940.GA15128@splinter> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Bridge] [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: "open list:STAGING SUBSYSTEM" , "andrew@lunn.ch" , "netdev@vger.kernel.org" , "moderated list:ETHERNET BRIDGE" , open list , "vivien.didelot@gmail.com" , Jiri Pirko , "David S. Miller" On 2/25/19 1:49 AM, Ido Schimmel wrote: > On Sun, Feb 24, 2019 at 08:47:27AM -0800, Florian Fainelli wrote: >> Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : >>> On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >>>> - if (attr->flags & SWITCHDEV_F_NO_RECURSE) >>>> + if (attr & SWITCHDEV_F_DEFER) >>>> + rc = call_switchdev_blocking_notifiers(nt, dev, >>>> + &attr_info.info, NULL); >>>> + else >>>> + rc = call_switchdev_notifiers(nt, dev, &attr_info.info, NULL); >>> >>> I don't believe this is needed. You're calling this function from >>> switchdev_port_attr_set_now() which is always called from process >>> context. switchdev_port_attr_set() takes care of that. Similar to >>> switchdev_port_obj_add(). >> >> Except for net/bridge/br_switchdev.c when we check the bridge port's >> flags support with PRE_BRIDGE_FLAGS. In that case we are executing from >> the caller (atomic) context and we can't defer otherwise that trumps the >> whole idea of being able to do a quick check and return that to the >> caller that we cannot support specific flags. How would you recommend >> approaching that? > > In this case you can invoke call_switchdev_notifiers() directly from > br_switchdev_set_port_flag(). Eventually switchdev_port_attr_set() will > be gone and bridge code will invoke the notifiers directly. That can be done, but it still requires the target driver (mlxsw, ocelot, dsa, etc.) to support attribute notification from blocking and non-blocking context. Are you fine with that? -- Florian