From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andi Shyti <andi.shyti@kernel.org>,
Abhinav Jain <jain.abhinav177@gmail.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"javier.carrasco.cruz@gmail.com" <javier.carrasco.cruz@gmail.com>,
"Julia Lawall" <julia.lawall@inria.fr>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup
Date: Tue, 16 Apr 2024 03:59:13 +0000 [thread overview]
Message-ID: <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> (raw)
In-Reply-To: <vegjt4pcl2x2wmwso6ajbihqc6rpbup5knycnz76jz3zfbfpp4@opxek6apu3w4>
On 16/04/24 08:54, Andi Shyti wrote:
> Hi Abhinav,
>
>> /* Enable I2C interrupts for mpc5121 */
>> - node_ctrl = of_find_compatible_node(NULL, NULL,
>> - "fsl,mpc5121-i2c-ctrl");
>> + struct device_node *node_ctrl __free(device_node) =
> How have you tested this?
I'm not sure I know anyone that still has a mpc5121. Maybe someone on
linuxppc-dev?
I did try to take the patch for a spin on my T2081RDB but I'm having
some userland issues on it for some reason (unrelated to this change).
The kernel boot does discover a few peripherals hanging of the I2C
interface but I'm not in a position to offer up a Tested-by and I've run
out of time to debug why my board is unhappy.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andi Shyti <andi.shyti@kernel.org>,
Abhinav Jain <jain.abhinav177@gmail.com>
Cc: "javier.carrasco.cruz@gmail.com" <javier.carrasco.cruz@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup
Date: Tue, 16 Apr 2024 03:59:13 +0000 [thread overview]
Message-ID: <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> (raw)
In-Reply-To: <vegjt4pcl2x2wmwso6ajbihqc6rpbup5knycnz76jz3zfbfpp4@opxek6apu3w4>
On 16/04/24 08:54, Andi Shyti wrote:
> Hi Abhinav,
>
>> /* Enable I2C interrupts for mpc5121 */
>> - node_ctrl = of_find_compatible_node(NULL, NULL,
>> - "fsl,mpc5121-i2c-ctrl");
>> + struct device_node *node_ctrl __free(device_node) =
> How have you tested this?
I'm not sure I know anyone that still has a mpc5121. Maybe someone on
linuxppc-dev?
I did try to take the patch for a spin on my T2081RDB but I'm having
some userland issues on it for some reason (unrelated to this change).
The kernel boot does discover a few peripherals hanging of the I2C
interface but I'm not in a position to offer up a Tested-by and I've run
out of time to debug why my board is unhappy.
next prev parent reply other threads:[~2024-04-16 3:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 16:12 [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Abhinav Jain
2024-04-15 20:54 ` Andi Shyti
2024-04-16 3:59 ` Chris Packham [this message]
2024-04-16 3:59 ` Chris Packham
2024-04-16 14:07 ` Andi Shyti
2024-04-16 14:07 ` Andi Shyti
2024-04-16 14:09 ` Andi Shyti
2024-04-16 14:09 ` Andi Shyti
2024-04-19 7:22 ` Michael Ellerman
2024-04-19 7:22 ` Michael Ellerman
2024-04-16 4:00 ` Chris Packham
2024-04-16 22:46 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andi.shyti@kernel.org \
--cc=jain.abhinav177@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.