From: "Shankar, Uma" <uma.shankar@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [v6 0/2] Re-enable FBC on TGL
Date: Wed, 2 Dec 2020 13:09:34 +0000 [thread overview]
Message-ID: <2ea42ef4e7274832b81c2c3c6791c944@intel.com> (raw)
In-Reply-To: <589b1215583ae4dc934021c17d3488b7fee32cdb.camel@intel.com>
> -----Original Message-----
> From: Souza, Jose <jose.souza@intel.com>
> Sent: Wednesday, December 2, 2020 12:01 AM
> To: Shankar, Uma <uma.shankar@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: ville.syrjala@linux.intel.com
> Subject: Re: [v6 0/2] Re-enable FBC on TGL
>
> LGTM, thanks for doing the changes.
Pushed the series to dinq.
Thanks Jose and Ville for the review and feedback.
Regards,
Uma Shankar
> On Wed, 2020-12-02 at 00:34 +0530, Uma Shankar wrote:
> > FBC was disabled on TGL due to random underruns. It has been
> > determined that FBC will not work reliably with PSR2.
> > This series re-enables fbc along with taking care of the
> > PSR2 limitations for TGL.
> >
> > Bspec: 50422 HSD: 14010260002
> >
> > v2: Addressed review comments and added bspec links
> >
> > v3: Addressed Ville's review comments
> >
> > v4: Change the WA as per Jose's recommendation.
> >
> > v5: Addressed Jose's review comments.
> >
> > v6: Added Jose and Ville RB's. Fixed a minor review comment.
> >
> > Uma Shankar (2):
> > drm/i915/display/tgl: Disable FBC with PSR2
> > Revert "drm/i915/display/fbc: Disable fbc by default on TGL"
> >
> > drivers/gpu/drm/i915/display/intel_fbc.c | 19 ++++++++++++-------
> > drivers/gpu/drm/i915/i915_drv.h | 1 +
> > 2 files changed, 13 insertions(+), 7 deletions(-)
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-02 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 19:04 [Intel-gfx] [v6 0/2] Re-enable FBC on TGL Uma Shankar
2020-12-01 18:31 ` Souza, Jose
2020-12-02 13:09 ` Shankar, Uma [this message]
2020-12-04 11:54 ` Chris Wilson
2020-12-04 13:52 ` Saarinen, Jani
2020-12-01 19:04 ` [Intel-gfx] [v6 1/2] drm/i915/display/tgl: Disable FBC with PSR2 Uma Shankar
2020-12-01 19:04 ` [Intel-gfx] [v6 2/2] Revert "drm/i915/display/fbc: Disable fbc by default on TGL" Uma Shankar
2020-12-01 21:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Re-enable FBC on TGL (rev6) Patchwork
2020-12-01 22:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-02 2:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea42ef4e7274832b81c2c3c6791c944@intel.com \
--to=uma.shankar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.