From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 0/8] mbuf: structure reorganization
Date: Fri, 14 Apr 2017 14:10:33 +0100
Message-ID: <2ead9890-5759-5c31-1805-588967c7cbf2@intel.com>
References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com>
 <20170404162807.20157-1-olivier.matz@6wind.com> <2948467.vjfs1XSdfO@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com,
 mb@smartsharesystems.com, andrey.chilikin@intel.com, jblunck@infradead.org,
 nelio.laranjeiro@6wind.com, arybchenko@solarflare.com,
 jerin.jacob@caviumnetworks.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id B740C2BB1
 for <dev@dpdk.org>; Fri, 14 Apr 2017 15:10:37 +0200 (CEST)
In-Reply-To: <2948467.vjfs1XSdfO@xps13>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/5/2017 10:37 AM, Thomas Monjalon wrote:
> 2017-04-04 18:27, Olivier Matz:
>> Based on discussions done in [1] and in this thread, this patchset reorganizes
>> the mbuf.
>>
>> The main changes are:
>> - reorder structure to increase vector performance on some non-ia
>>   platforms.
>> - add a 64bits timestamp field in the 1st cache line. This timestamp
>>   is not normalized, i.e. no unit or time reference is enforced. A
>>   library may be added to do this job in the future.
>> - m->next, m->nb_segs, and m->refcnt are always initialized for mbufs
>>   in the pool, avoiding the need of setting m->next (located in the
>>   2nd cache line) in the Rx path for mono-segment packets.
>> - change port and nb_segs to 16 bits
>> - move seqn in the 2nd cache line
> 
> Applied, thanks for the long work
> 

<...>

>> Once this patchset is pushed, the Rx path of drivers could be optimized a bit,
>> by removing writes to m->next, m->nb_segs and m->refcnt. The patch 4/8 gives an
>> idea of what could be done.

Hi Olivier,

Some driver patches already received for this update, but not all yet.

Can you please describe what changes are required in PMDs after this
patch? And what will be effect of doing changes or not?

Later we can circulate this information through the PMD maintainers to
be sure proper updates done.

Thanks,
ferruh

> 
> Yes drivers patches are welcome :)
> Please target RC2 for these changes.
>