From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CABC4361A for ; Thu, 3 Dec 2020 15:41:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B999820798 for ; Thu, 3 Dec 2020 15:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731047AbgLCPlk (ORCPT ); Thu, 3 Dec 2020 10:41:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgLCPlj (ORCPT ); Thu, 3 Dec 2020 10:41:39 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 078FAC061A4F for ; Thu, 3 Dec 2020 07:40:58 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id g185so4346446wmf.3 for ; Thu, 03 Dec 2020 07:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kCQS8T9IzaK7qsrPFGKkQow9sRMix1gp13CfkJxVIA0=; b=VXideQU4m746yyi4UAyDiWJeEJZT5L3Vw5k/xn06MXy3jlMwGBHa+GGn7QqEtNPCER FDdVWuKd+KJClvrz0z+GKBzLzpx8ZWuHikTch0FrWWRcqlwY7DqoY/6iVFSHbOJPMxqP 6OXWx6S0Hb13t0jCiI+Tugt06DUWS8vDj5G6LhXFoMBi3LaIxKfNDpqhOwTIj6au4KWH OP/ndNlq6g46XazbTSibOJlf6GcDeLIkDHGClUaaKQGlHWXDg+0KbY20RPNdp/ZrfUak 7qzNy098gY1pCT+PZXnk6/8Mu8jcP+oFn62Pt8LGdy2t3oZBmhPp2RyTaC4NP6EW2fF6 2Zwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kCQS8T9IzaK7qsrPFGKkQow9sRMix1gp13CfkJxVIA0=; b=cvelBZ7uZF4hy54jA+m/+lnjwi7YjGI2nvLP+oOp3rUhdGu5/vtYejLzeZrJMgEKZR F+u8Jo5okTpI8OZ+4V0erl7cIu/WqpG4ULAw6DTrmZmiS+BRqcn1NvmLDvPNDO0wos9/ vlOjLM8jUoDDKGT5ihoLxhPxpbIaR8MUG0hhWTcSHpmHZtUIFoen3b4wco9cfOFW33Rx tuuncfLA42Mrn4LeFsxKPUPI+N0pYTs+5hxlDAwQmRizmPC/cAIdDYkVAHKclrm6diby F8d+qDaHFv/nV31YJy+1/+sj5bHilRio4NSqt/L23NvawH+Z3e7ue441K0bBXMvCwOdH n67Q== X-Gm-Message-State: AOAM533CX9kb8mF3l+7BY63FE5aEO2yB5iJz9EKSv+izB0uhi0kX7ykj NR+iN3KfCHw13Twa1GwBkF/mSg== X-Google-Smtp-Source: ABdhPJzLB9zF1QadPDaL6kyXpahnC6RjyhmYQddcNPWEmYzU80qn43ICc2D9JRNcwrSz4Uv2vjnDsA== X-Received: by 2002:a1c:5605:: with SMTP id k5mr3976889wmb.99.1607010057394; Thu, 03 Dec 2020 07:40:57 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:1c7d:2d7a:9709:b9a2? ([2a01:e34:ed2f:f020:1c7d:2d7a:9709:b9a2]) by smtp.googlemail.com with ESMTPSA id e27sm2710605wrc.9.2020.12.03.07.40.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 07:40:56 -0800 (PST) Subject: Re: [PATCH v2 3/5] thermal: devfreq_cooling: add new registration functions with Energy Model To: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com, orjan.eide@arm.com, robh@kernel.org, alyssa.rosenzweig@collabora.com, steven.price@arm.com, airlied@linux.ie, daniel@ffwll.ch, ionela.voinescu@arm.com References: <20201118120358.17150-1-lukasz.luba@arm.com> <20201118120358.17150-4-lukasz.luba@arm.com> From: Daniel Lezcano Message-ID: <2eb16ccf-f635-af2d-616f-9cd0cec88ca0@linaro.org> Date: Thu, 3 Dec 2020 16:40:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118120358.17150-4-lukasz.luba@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2020 13:03, Lukasz Luba wrote: > The Energy Model (EM) framework supports devices such as Devfreq. Create > new registration functions which automatically register EM for the thermal > devfreq_cooling devices. This patch prepares the code for coming changes > which are going to replace old power model with the new EM. > > Signed-off-by: Lukasz Luba > --- > drivers/thermal/devfreq_cooling.c | 99 ++++++++++++++++++++++++++++++- > include/linux/devfreq_cooling.h | 22 +++++++ > 2 files changed, 120 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c > index 925523694462..b354271742c5 100644 > --- a/drivers/thermal/devfreq_cooling.c > +++ b/drivers/thermal/devfreq_cooling.c > @@ -50,6 +50,8 @@ static DEFINE_IDA(devfreq_ida); > * @capped_state: index to cooling state with in dynamic power budget > * @req_max_freq: PM QoS request for limiting the maximum frequency > * of the devfreq device. > + * @em: Energy Model for the associated Devfreq device > + * @em_registered: Devfreq cooling registered the EM and should free it. > */ > struct devfreq_cooling_device { > int id; > @@ -63,6 +65,8 @@ struct devfreq_cooling_device { > u32 res_util; > int capped_state; > struct dev_pm_qos_request req_max_freq; > + struct em_perf_domain *em; This pointer is not needed, it is in the struct device. > + bool em_registered; The boolean em_registered is not needed because of the test in the function em_dev_unregister_perf_domain(): if (IS_ERR_OR_NULL(dev) || !dev->em_pd) return; Logically if the 'em' was not initialized, it must be NULL, the corresponding struct device was zero-allocated. > }; > > static int devfreq_cooling_get_max_state(struct thermal_cooling_device *cdev, > @@ -583,22 +587,115 @@ struct thermal_cooling_device *devfreq_cooling_register(struct devfreq *df) > } > EXPORT_SYMBOL_GPL(devfreq_cooling_register); > > +/** > + * devfreq_cooling_em_register_power() - Register devfreq cooling device with > + * power information and attempt to register Energy Model (EM) > + * @df: Pointer to devfreq device. > + * @dfc_power: Pointer to devfreq_cooling_power. > + * @em_cb: Callback functions providing the data of the EM > + * > + * Register a devfreq cooling device and attempt to register Energy Model. The > + * available OPPs must be registered for the device. > + * > + * If @dfc_power is provided, the cooling device is registered with the > + * power extensions. If @em_cb is provided it will be called for each OPP to > + * calculate power value and cost. If @em_cb is not provided then simple Energy > + * Model is going to be used, which requires "dynamic-power-coefficient" a > + * devicetree property. > + */ > +struct thermal_cooling_device * > +devfreq_cooling_em_register_power(struct devfreq *df, > + struct devfreq_cooling_power *dfc_power, > + struct em_data_callback *em_cb) > +{ > + struct thermal_cooling_device *cdev; > + struct devfreq_cooling_device *dfc; > + struct device_node *np = NULL; > + struct device *dev; > + int nr_opp, ret; > + > + if (IS_ERR_OR_NULL(df)) > + return ERR_PTR(-EINVAL); > + > + dev = df->dev.parent; Why the parent ? > + > + if (em_cb) { > + nr_opp = dev_pm_opp_get_opp_count(dev); > + if (nr_opp <= 0) { > + dev_err(dev, "No valid OPPs found\n"); > + return ERR_PTR(-EINVAL); > + } > + > + ret = em_dev_register_perf_domain(dev, nr_opp, em_cb, NULL, false); > + } else { > + ret = dev_pm_opp_of_register_em(dev, NULL); > + } > + > + if (ret) > + dev_warn(dev, "Unable to register EM for devfreq cooling device (%d)\n", > + ret); > + > + if (dev->of_node) > + np = of_node_get(dev->of_node); > + > + cdev = of_devfreq_cooling_register_power(np, df, dfc_power); > + > + if (np) > + of_node_put(np);> + > + if (IS_ERR_OR_NULL(cdev)) { > + if (!ret) > + em_dev_unregister_perf_domain(dev); > + } else { > + dfc = cdev->devdata; > + dfc->em_registered = !ret; > + } > + > + return cdev; > +} > +EXPORT_SYMBOL_GPL(devfreq_cooling_em_register_power); > + > +/** > + * devfreq_cooling_em_register() - Register devfreq cooling device together > + * with Energy Model. > + * @df: Pointer to devfreq device. > + * @em_cb: Callback functions providing the data of the Energy Model > + * > + * This function attempts to register Energy Model for devfreq device and then > + * register the devfreq cooling device. > + */ > +struct thermal_cooling_device * > +devfreq_cooling_em_register(struct devfreq *df, struct em_data_callback *em_cb) > +{ > + return devfreq_cooling_em_register_power(df, NULL, em_cb); > +} > +EXPORT_SYMBOL_GPL(devfreq_cooling_em_register); > + > /** > * devfreq_cooling_unregister() - Unregister devfreq cooling device. > * @cdev: Pointer to devfreq cooling device to unregister. > + * > + * Unregisters devfreq cooling device and related Energy Model if it was > + * present. > */ > void devfreq_cooling_unregister(struct thermal_cooling_device *cdev) > { > struct devfreq_cooling_device *dfc; > + struct device *dev; > > - if (!cdev) > + if (IS_ERR_OR_NULL(cdev)) Why this additional IS_ERR check ? > return; > > dfc = cdev->devdata; > + dev = dfc->devfreq->dev.parent; > > thermal_cooling_device_unregister(dfc->cdev); > ida_simple_remove(&devfreq_ida, dfc->id); > dev_pm_qos_remove_request(&dfc->req_max_freq); > + > + if (dfc->em_registered) > + em_dev_unregister_perf_domain(dev); > + As stated before it can be called unconditionally > kfree(dfc->power_table); > kfree(dfc->freq_table); > > diff --git a/include/linux/devfreq_cooling.h b/include/linux/devfreq_cooling.h > index 9df2dfca68dd..19868fb922f1 100644 > --- a/include/linux/devfreq_cooling.h > +++ b/include/linux/devfreq_cooling.h > @@ -11,6 +11,7 @@ > #define __DEVFREQ_COOLING_H__ > > #include > +#include > #include > > > @@ -65,6 +66,13 @@ struct thermal_cooling_device * > of_devfreq_cooling_register(struct device_node *np, struct devfreq *df); > struct thermal_cooling_device *devfreq_cooling_register(struct devfreq *df); > void devfreq_cooling_unregister(struct thermal_cooling_device *dfc); > +struct thermal_cooling_device * > +devfreq_cooling_em_register_power(struct devfreq *df, > + struct devfreq_cooling_power *dfc_power, > + struct em_data_callback *em_cb); > +struct thermal_cooling_device * > +devfreq_cooling_em_register(struct devfreq *df, > + struct em_data_callback *em_cb); > > #else /* !CONFIG_DEVFREQ_THERMAL */ > > @@ -87,6 +95,20 @@ devfreq_cooling_register(struct devfreq *df) > return ERR_PTR(-EINVAL); > } > > +static inline struct thermal_cooling_device * > +devfreq_cooling_em_register_power(struct devfreq *df, > + struct devfreq_cooling_power *dfc_power, > + struct em_data_callback *em_cb) > +{ > + return ERR_PTR(-EINVAL); > +} > + > +static inline struct thermal_cooling_device * > +devfreq_cooling_em_register(struct devfreq *df, struct em_data_callback *em_cb) > +{ > + return ERR_PTR(-EINVAL); > +} > + > static inline void > devfreq_cooling_unregister(struct thermal_cooling_device *dfc) > { > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A03CC4361B for ; Fri, 4 Dec 2020 08:34:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45E9422515 for ; Fri, 4 Dec 2020 08:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45E9422515 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DA3A6EC78; Fri, 4 Dec 2020 08:33:53 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03D0F6E02F for ; Thu, 3 Dec 2020 15:40:58 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id c198so3184639wmd.0 for ; Thu, 03 Dec 2020 07:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kCQS8T9IzaK7qsrPFGKkQow9sRMix1gp13CfkJxVIA0=; b=VXideQU4m746yyi4UAyDiWJeEJZT5L3Vw5k/xn06MXy3jlMwGBHa+GGn7QqEtNPCER FDdVWuKd+KJClvrz0z+GKBzLzpx8ZWuHikTch0FrWWRcqlwY7DqoY/6iVFSHbOJPMxqP 6OXWx6S0Hb13t0jCiI+Tugt06DUWS8vDj5G6LhXFoMBi3LaIxKfNDpqhOwTIj6au4KWH OP/ndNlq6g46XazbTSibOJlf6GcDeLIkDHGClUaaKQGlHWXDg+0KbY20RPNdp/ZrfUak 7qzNy098gY1pCT+PZXnk6/8Mu8jcP+oFn62Pt8LGdy2t3oZBmhPp2RyTaC4NP6EW2fF6 2Zwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kCQS8T9IzaK7qsrPFGKkQow9sRMix1gp13CfkJxVIA0=; b=QzgKQRManb9ZLYP0BttYltp/8vsQZUUgYLS62fVgc1wbHwKXs2oBAjQ4bZZa4l78cc W5FW9YbigOOshMOGd9059tjl4lm2RmaEYfb/ZRSlRO6E4/zIEtSVhL/CaCsj2vf6Jc/y bOoC/SicW0Ni0s7EzAnIyi1SihwQ1eXk6QYQgej1dlHxrm5nHYS0KYgPK8jrjB5+oTzv Dff4yJPqvUTyvJL9vJ6f6oOxWzf0jUnt432VkDGw68DzMpCBE7C7qtXFLsgLZx0R0YqI wzNNefWu8jsu7dvW1uNW4wKOmymQX+C0zM25kXVpXb2F5KJpk++HZOsevUrJQl/WgINz vxUg== X-Gm-Message-State: AOAM530YcH5Npd+wAWBtPVOr26NliC1zKos5XLhmZGdDzIHFXTwZg8f7 qNU+u+HRAsqtGDWQ7mXRXPLCQw== X-Google-Smtp-Source: ABdhPJzLB9zF1QadPDaL6kyXpahnC6RjyhmYQddcNPWEmYzU80qn43ICc2D9JRNcwrSz4Uv2vjnDsA== X-Received: by 2002:a1c:5605:: with SMTP id k5mr3976889wmb.99.1607010057394; Thu, 03 Dec 2020 07:40:57 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:1c7d:2d7a:9709:b9a2? ([2a01:e34:ed2f:f020:1c7d:2d7a:9709:b9a2]) by smtp.googlemail.com with ESMTPSA id e27sm2710605wrc.9.2020.12.03.07.40.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Dec 2020 07:40:56 -0800 (PST) Subject: Re: [PATCH v2 3/5] thermal: devfreq_cooling: add new registration functions with Energy Model To: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20201118120358.17150-1-lukasz.luba@arm.com> <20201118120358.17150-4-lukasz.luba@arm.com> From: Daniel Lezcano Message-ID: <2eb16ccf-f635-af2d-616f-9cd0cec88ca0@linaro.org> Date: Thu, 3 Dec 2020 16:40:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201118120358.17150-4-lukasz.luba@arm.com> Content-Language: en-US X-Mailman-Approved-At: Fri, 04 Dec 2020 08:33:34 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kucheria@verdurent.com, airlied@linux.ie, steven.price@arm.com, alyssa.rosenzweig@collabora.com, rui.zhang@intel.com, ionela.voinescu@arm.com, orjan.eide@arm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMTgvMTEvMjAyMCAxMzowMywgTHVrYXN6IEx1YmEgd3JvdGU6Cj4gVGhlIEVuZXJneSBNb2Rl bCAoRU0pIGZyYW1ld29yayBzdXBwb3J0cyBkZXZpY2VzIHN1Y2ggYXMgRGV2ZnJlcS4gQ3JlYXRl Cj4gbmV3IHJlZ2lzdHJhdGlvbiBmdW5jdGlvbnMgd2hpY2ggYXV0b21hdGljYWxseSByZWdpc3Rl ciBFTSBmb3IgdGhlIHRoZXJtYWwKPiBkZXZmcmVxX2Nvb2xpbmcgZGV2aWNlcy4gVGhpcyBwYXRj aCBwcmVwYXJlcyB0aGUgY29kZSBmb3IgY29taW5nIGNoYW5nZXMKPiB3aGljaCBhcmUgZ29pbmcg dG8gcmVwbGFjZSBvbGQgcG93ZXIgbW9kZWwgd2l0aCB0aGUgbmV3IEVNLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IEx1a2FzeiBMdWJhIDxsdWthc3oubHViYUBhcm0uY29tPgo+IC0tLQo+ICBkcml2ZXJz L3RoZXJtYWwvZGV2ZnJlcV9jb29saW5nLmMgfCA5OSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKystCj4gIGluY2x1ZGUvbGludXgvZGV2ZnJlcV9jb29saW5nLmggICB8IDIyICsrKysrKysK PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMjAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3RoZXJtYWwvZGV2ZnJlcV9jb29saW5nLmMgYi9kcml2ZXJz L3RoZXJtYWwvZGV2ZnJlcV9jb29saW5nLmMKPiBpbmRleCA5MjU1MjM2OTQ0NjIuLmIzNTQyNzE3 NDJjNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3RoZXJtYWwvZGV2ZnJlcV9jb29saW5nLmMKPiAr KysgYi9kcml2ZXJzL3RoZXJtYWwvZGV2ZnJlcV9jb29saW5nLmMKPiBAQCAtNTAsNiArNTAsOCBA QCBzdGF0aWMgREVGSU5FX0lEQShkZXZmcmVxX2lkYSk7Cj4gICAqIEBjYXBwZWRfc3RhdGU6CWlu ZGV4IHRvIGNvb2xpbmcgc3RhdGUgd2l0aCBpbiBkeW5hbWljIHBvd2VyIGJ1ZGdldAo+ICAgKiBA cmVxX21heF9mcmVxOglQTSBRb1MgcmVxdWVzdCBmb3IgbGltaXRpbmcgdGhlIG1heGltdW0gZnJl cXVlbmN5Cj4gICAqCQkJb2YgdGhlIGRldmZyZXEgZGV2aWNlLgo+ICsgKiBAZW06CQlFbmVyZ3kg TW9kZWwgZm9yIHRoZSBhc3NvY2lhdGVkIERldmZyZXEgZGV2aWNlCj4gKyAqIEBlbV9yZWdpc3Rl cmVkOglEZXZmcmVxIGNvb2xpbmcgcmVnaXN0ZXJlZCB0aGUgRU0gYW5kIHNob3VsZCBmcmVlIGl0 Lgo+ICAgKi8KPiAgc3RydWN0IGRldmZyZXFfY29vbGluZ19kZXZpY2Ugewo+ICAJaW50IGlkOwo+ IEBAIC02Myw2ICs2NSw4IEBAIHN0cnVjdCBkZXZmcmVxX2Nvb2xpbmdfZGV2aWNlIHsKPiAgCXUz MiByZXNfdXRpbDsKPiAgCWludCBjYXBwZWRfc3RhdGU7Cj4gIAlzdHJ1Y3QgZGV2X3BtX3Fvc19y ZXF1ZXN0IHJlcV9tYXhfZnJlcTsKPiArCXN0cnVjdCBlbV9wZXJmX2RvbWFpbiAqZW07CgpUaGlz IHBvaW50ZXIgaXMgbm90IG5lZWRlZCwgaXQgaXMgaW4gdGhlIHN0cnVjdCBkZXZpY2UuCgo+ICsJ Ym9vbCBlbV9yZWdpc3RlcmVkOwoKVGhlIGJvb2xlYW4gZW1fcmVnaXN0ZXJlZCBpcyBub3QgbmVl ZGVkIGJlY2F1c2Ugb2YgdGhlIHRlc3QgaW4gdGhlCmZ1bmN0aW9uIGVtX2Rldl91bnJlZ2lzdGVy X3BlcmZfZG9tYWluKCk6CgppZiAoSVNfRVJSX09SX05VTEwoZGV2KSB8fCAhZGV2LT5lbV9wZCkK ICAgICAgICAgICAgICAgIHJldHVybjsKCkxvZ2ljYWxseSBpZiB0aGUgJ2VtJyB3YXMgbm90IGlu aXRpYWxpemVkLCBpdCBtdXN0IGJlIE5VTEwsIHRoZQpjb3JyZXNwb25kaW5nIHN0cnVjdCBkZXZp Y2Ugd2FzIHplcm8tYWxsb2NhdGVkLgoKCj4gIH07Cj4gIAo+ICBzdGF0aWMgaW50IGRldmZyZXFf Y29vbGluZ19nZXRfbWF4X3N0YXRlKHN0cnVjdCB0aGVybWFsX2Nvb2xpbmdfZGV2aWNlICpjZGV2 LAo+IEBAIC01ODMsMjIgKzU4NywxMTUgQEAgc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2Ug KmRldmZyZXFfY29vbGluZ19yZWdpc3RlcihzdHJ1Y3QgZGV2ZnJlcSAqZGYpCj4gIH0KPiAgRVhQ T1JUX1NZTUJPTF9HUEwoZGV2ZnJlcV9jb29saW5nX3JlZ2lzdGVyKTsKPiAgCj4gKy8qKgo+ICsg KiBkZXZmcmVxX2Nvb2xpbmdfZW1fcmVnaXN0ZXJfcG93ZXIoKSAtIFJlZ2lzdGVyIGRldmZyZXEg Y29vbGluZyBkZXZpY2Ugd2l0aAo+ICsgKgkJcG93ZXIgaW5mb3JtYXRpb24gYW5kIGF0dGVtcHQg dG8gcmVnaXN0ZXIgRW5lcmd5IE1vZGVsIChFTSkKPiArICogQGRmOgkJUG9pbnRlciB0byBkZXZm cmVxIGRldmljZS4KPiArICogQGRmY19wb3dlcjoJUG9pbnRlciB0byBkZXZmcmVxX2Nvb2xpbmdf cG93ZXIuCj4gKyAqIEBlbV9jYjoJQ2FsbGJhY2sgZnVuY3Rpb25zIHByb3ZpZGluZyB0aGUgZGF0 YSBvZiB0aGUgRU0KPiArICoKPiArICogUmVnaXN0ZXIgYSBkZXZmcmVxIGNvb2xpbmcgZGV2aWNl IGFuZCBhdHRlbXB0IHRvIHJlZ2lzdGVyIEVuZXJneSBNb2RlbC4gVGhlCj4gKyAqIGF2YWlsYWJs ZSBPUFBzIG11c3QgYmUgcmVnaXN0ZXJlZCBmb3IgdGhlIGRldmljZS4KPiArICoKPiArICogSWYg QGRmY19wb3dlciBpcyBwcm92aWRlZCwgdGhlIGNvb2xpbmcgZGV2aWNlIGlzIHJlZ2lzdGVyZWQg d2l0aCB0aGUKPiArICogcG93ZXIgZXh0ZW5zaW9ucy4gSWYgQGVtX2NiIGlzIHByb3ZpZGVkIGl0 IHdpbGwgYmUgY2FsbGVkIGZvciBlYWNoIE9QUCB0bwo+ICsgKiBjYWxjdWxhdGUgcG93ZXIgdmFs dWUgYW5kIGNvc3QuIElmIEBlbV9jYiBpcyBub3QgcHJvdmlkZWQgdGhlbiBzaW1wbGUgRW5lcmd5 Cj4gKyAqIE1vZGVsIGlzIGdvaW5nIHRvIGJlIHVzZWQsIHdoaWNoIHJlcXVpcmVzICJkeW5hbWlj LXBvd2VyLWNvZWZmaWNpZW50IiBhCj4gKyAqIGRldmljZXRyZWUgcHJvcGVydHkuCj4gKyAqLwo+ ICtzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAqCj4gK2RldmZyZXFfY29vbGluZ19lbV9y ZWdpc3Rlcl9wb3dlcihzdHJ1Y3QgZGV2ZnJlcSAqZGYsCj4gKwkJCQkgIHN0cnVjdCBkZXZmcmVx X2Nvb2xpbmdfcG93ZXIgKmRmY19wb3dlciwKPiArCQkJCSAgc3RydWN0IGVtX2RhdGFfY2FsbGJh Y2sgKmVtX2NiKQo+ICt7Cj4gKwlzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAqY2RldjsK PiArCXN0cnVjdCBkZXZmcmVxX2Nvb2xpbmdfZGV2aWNlICpkZmM7Cj4gKwlzdHJ1Y3QgZGV2aWNl X25vZGUgKm5wID0gTlVMTDsKPiArCXN0cnVjdCBkZXZpY2UgKmRldjsKPiArCWludCBucl9vcHAs IHJldDsKPiArCj4gKwlpZiAoSVNfRVJSX09SX05VTEwoZGYpKQo+ICsJCXJldHVybiBFUlJfUFRS KC1FSU5WQUwpOwo+ICsKPiArCWRldiA9IGRmLT5kZXYucGFyZW50OwoKV2h5IHRoZSBwYXJlbnQg PwoKPiArCj4gKwlpZiAoZW1fY2IpIHsKPiArCQlucl9vcHAgPSBkZXZfcG1fb3BwX2dldF9vcHBf Y291bnQoZGV2KTsKPiArCQlpZiAobnJfb3BwIDw9IDApIHsKPiArCQkJZGV2X2VycihkZXYsICJO byB2YWxpZCBPUFBzIGZvdW5kXG4iKTsKPiArCQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4g KwkJfQo+ICsKPiArCQlyZXQgPSBlbV9kZXZfcmVnaXN0ZXJfcGVyZl9kb21haW4oZGV2LCBucl9v cHAsIGVtX2NiLCBOVUxMLCBmYWxzZSk7Cj4gKwl9IGVsc2Ugewo+ICsJCXJldCA9IGRldl9wbV9v cHBfb2ZfcmVnaXN0ZXJfZW0oZGV2LCBOVUxMKTsKPiArCX0KPiArCj4gKwlpZiAocmV0KQo+ICsJ CWRldl93YXJuKGRldiwgIlVuYWJsZSB0byByZWdpc3RlciBFTSBmb3IgZGV2ZnJlcSBjb29saW5n IGRldmljZSAoJWQpXG4iLAo+ICsJCQkgcmV0KTsKPiArCj4gKwlpZiAoZGV2LT5vZl9ub2RlKQo+ ICsJCW5wID0gb2Zfbm9kZV9nZXQoZGV2LT5vZl9ub2RlKTsKPiArCj4gKwljZGV2ID0gb2ZfZGV2 ZnJlcV9jb29saW5nX3JlZ2lzdGVyX3Bvd2VyKG5wLCBkZiwgZGZjX3Bvd2VyKTsKPiArCj4gKwlp ZiAobnApCj4gKwkJb2Zfbm9kZV9wdXQobnApOz4gKwo+ICsJaWYgKElTX0VSUl9PUl9OVUxMKGNk ZXYpKSB7Cj4gKwkJaWYgKCFyZXQpCj4gKwkJCWVtX2Rldl91bnJlZ2lzdGVyX3BlcmZfZG9tYWlu KGRldik7Cj4gKwl9IGVsc2Ugewo+ICsJCWRmYyA9IGNkZXYtPmRldmRhdGE7Cj4gKwkJZGZjLT5l bV9yZWdpc3RlcmVkID0gIXJldDsKPiArCX0KPiArCj4gKwlyZXR1cm4gY2RldjsKPiArfQo+ICtF WFBPUlRfU1lNQk9MX0dQTChkZXZmcmVxX2Nvb2xpbmdfZW1fcmVnaXN0ZXJfcG93ZXIpOwo+ICsK PiArLyoqCj4gKyAqIGRldmZyZXFfY29vbGluZ19lbV9yZWdpc3RlcigpIC0gUmVnaXN0ZXIgZGV2 ZnJlcSBjb29saW5nIGRldmljZSB0b2dldGhlcgo+ICsgKgkJCQl3aXRoIEVuZXJneSBNb2RlbC4K PiArICogQGRmOgkJUG9pbnRlciB0byBkZXZmcmVxIGRldmljZS4KPiArICogQGVtX2NiOglDYWxs YmFjayBmdW5jdGlvbnMgcHJvdmlkaW5nIHRoZSBkYXRhIG9mIHRoZSBFbmVyZ3kgTW9kZWwKPiAr ICoKPiArICogVGhpcyBmdW5jdGlvbiBhdHRlbXB0cyB0byByZWdpc3RlciBFbmVyZ3kgTW9kZWwg Zm9yIGRldmZyZXEgZGV2aWNlIGFuZCB0aGVuCj4gKyAqIHJlZ2lzdGVyIHRoZSBkZXZmcmVxIGNv b2xpbmcgZGV2aWNlLgo+ICsgKi8KPiArc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKgo+ ICtkZXZmcmVxX2Nvb2xpbmdfZW1fcmVnaXN0ZXIoc3RydWN0IGRldmZyZXEgKmRmLCBzdHJ1Y3Qg ZW1fZGF0YV9jYWxsYmFjayAqZW1fY2IpCj4gK3sKPiArCXJldHVybiBkZXZmcmVxX2Nvb2xpbmdf ZW1fcmVnaXN0ZXJfcG93ZXIoZGYsIE5VTEwsIGVtX2NiKTsKPiArfQo+ICtFWFBPUlRfU1lNQk9M X0dQTChkZXZmcmVxX2Nvb2xpbmdfZW1fcmVnaXN0ZXIpOwo+ICsKPiAgLyoqCj4gICAqIGRldmZy ZXFfY29vbGluZ191bnJlZ2lzdGVyKCkgLSBVbnJlZ2lzdGVyIGRldmZyZXEgY29vbGluZyBkZXZp Y2UuCj4gICAqIEBjZGV2OiBQb2ludGVyIHRvIGRldmZyZXEgY29vbGluZyBkZXZpY2UgdG8gdW5y ZWdpc3Rlci4KPiArICoKPiArICogVW5yZWdpc3RlcnMgZGV2ZnJlcSBjb29saW5nIGRldmljZSBh bmQgcmVsYXRlZCBFbmVyZ3kgTW9kZWwgaWYgaXQgd2FzCj4gKyAqIHByZXNlbnQuCj4gICAqLwo+ ICB2b2lkIGRldmZyZXFfY29vbGluZ191bnJlZ2lzdGVyKHN0cnVjdCB0aGVybWFsX2Nvb2xpbmdf ZGV2aWNlICpjZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZGV2ZnJlcV9jb29saW5nX2RldmljZSAqZGZj Owo+ICsJc3RydWN0IGRldmljZSAqZGV2Owo+ICAKPiAtCWlmICghY2RldikKPiArCWlmIChJU19F UlJfT1JfTlVMTChjZGV2KSkKCldoeSB0aGlzIGFkZGl0aW9uYWwgSVNfRVJSIGNoZWNrID8KCj4g IAkJcmV0dXJuOwo+ICAKPiAgCWRmYyA9IGNkZXYtPmRldmRhdGE7Cj4gKwlkZXYgPSBkZmMtPmRl dmZyZXEtPmRldi5wYXJlbnQ7Cj4gIAo+ICAJdGhlcm1hbF9jb29saW5nX2RldmljZV91bnJlZ2lz dGVyKGRmYy0+Y2Rldik7Cj4gIAlpZGFfc2ltcGxlX3JlbW92ZSgmZGV2ZnJlcV9pZGEsIGRmYy0+ aWQpOwo+ICAJZGV2X3BtX3Fvc19yZW1vdmVfcmVxdWVzdCgmZGZjLT5yZXFfbWF4X2ZyZXEpOwo+ ICsKPiArCWlmIChkZmMtPmVtX3JlZ2lzdGVyZWQpCj4gKwkJZW1fZGV2X3VucmVnaXN0ZXJfcGVy Zl9kb21haW4oZGV2KTsKPiArCgpBcyBzdGF0ZWQgYmVmb3JlIGl0IGNhbiBiZSBjYWxsZWQgdW5j b25kaXRpb25hbGx5Cgo+ICAJa2ZyZWUoZGZjLT5wb3dlcl90YWJsZSk7Cj4gIAlrZnJlZShkZmMt PmZyZXFfdGFibGUpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9kZXZmcmVxX2Nv b2xpbmcuaCBiL2luY2x1ZGUvbGludXgvZGV2ZnJlcV9jb29saW5nLmgKPiBpbmRleCA5ZGYyZGZj YTY4ZGQuLjE5ODY4ZmI5MjJmMSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L2RldmZyZXFf Y29vbGluZy5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9kZXZmcmVxX2Nvb2xpbmcuaAo+IEBAIC0x MSw2ICsxMSw3IEBACj4gICNkZWZpbmUgX19ERVZGUkVRX0NPT0xJTkdfSF9fCj4gIAo+ICAjaW5j bHVkZSA8bGludXgvZGV2ZnJlcS5oPgo+ICsjaW5jbHVkZSA8bGludXgvZW5lcmd5X21vZGVsLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC90aGVybWFsLmg+Cj4gIAo+ICAKPiBAQCAtNjUsNiArNjYsMTMg QEAgc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKgo+ICBvZl9kZXZmcmVxX2Nvb2xpbmdf cmVnaXN0ZXIoc3RydWN0IGRldmljZV9ub2RlICpucCwgc3RydWN0IGRldmZyZXEgKmRmKTsKPiAg c3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKmRldmZyZXFfY29vbGluZ19yZWdpc3Rlcihz dHJ1Y3QgZGV2ZnJlcSAqZGYpOwo+ICB2b2lkIGRldmZyZXFfY29vbGluZ191bnJlZ2lzdGVyKHN0 cnVjdCB0aGVybWFsX2Nvb2xpbmdfZGV2aWNlICpkZmMpOwo+ICtzdHJ1Y3QgdGhlcm1hbF9jb29s aW5nX2RldmljZSAqCj4gK2RldmZyZXFfY29vbGluZ19lbV9yZWdpc3Rlcl9wb3dlcihzdHJ1Y3Qg ZGV2ZnJlcSAqZGYsCj4gKwkJCQkgIHN0cnVjdCBkZXZmcmVxX2Nvb2xpbmdfcG93ZXIgKmRmY19w b3dlciwKPiArCQkJCSAgc3RydWN0IGVtX2RhdGFfY2FsbGJhY2sgKmVtX2NiKTsKPiArc3RydWN0 IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKgo+ICtkZXZmcmVxX2Nvb2xpbmdfZW1fcmVnaXN0ZXIo c3RydWN0IGRldmZyZXEgKmRmLAo+ICsJCQkgICAgc3RydWN0IGVtX2RhdGFfY2FsbGJhY2sgKmVt X2NiKTsKPiAgCj4gICNlbHNlIC8qICFDT05GSUdfREVWRlJFUV9USEVSTUFMICovCj4gIAo+IEBA IC04Nyw2ICs5NSwyMCBAQCBkZXZmcmVxX2Nvb2xpbmdfcmVnaXN0ZXIoc3RydWN0IGRldmZyZXEg KmRmKQo+ICAJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbmxp bmUgc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKgo+ICtkZXZmcmVxX2Nvb2xpbmdfZW1f cmVnaXN0ZXJfcG93ZXIoc3RydWN0IGRldmZyZXEgKmRmLAo+ICsJCQkJICBzdHJ1Y3QgZGV2ZnJl cV9jb29saW5nX3Bvd2VyICpkZmNfcG93ZXIsCj4gKwkJCQkgIHN0cnVjdCBlbV9kYXRhX2NhbGxi YWNrICplbV9jYikKPiArewo+ICsJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gK30KPiArCj4g K3N0YXRpYyBpbmxpbmUgc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKgo+ICtkZXZmcmVx X2Nvb2xpbmdfZW1fcmVnaXN0ZXIoc3RydWN0IGRldmZyZXEgKmRmLAlzdHJ1Y3QgZW1fZGF0YV9j YWxsYmFjayAqZW1fY2IpCj4gK3sKPiArCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ICt9Cj4g Kwo+ICBzdGF0aWMgaW5saW5lIHZvaWQKPiAgZGV2ZnJlcV9jb29saW5nX3VucmVnaXN0ZXIoc3Ry dWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKmRmYykKPiAgewo+IAoKCi0tIAo8aHR0cDovL3d3 dy5saW5hcm8ub3JnLz4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFS TSBTb0NzCgpGb2xsb3cgTGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJvb2suY29tL3BhZ2VzL0xp bmFybz4gRmFjZWJvb2sgfAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4gVHdpdHRl ciB8CjxodHRwOi8vd3d3LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBCbG9nCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=