From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: FW: [Resource Leak] Suggesting patch for tcp_close Date: Tue, 27 Nov 2018 20:58:19 -0800 Message-ID: <2eb8a518-1a84-5782-b0e2-c78fe88dfe4b@gmail.com> References: <20181123072258epcms1p8c41425598751be28f8cc05b91c7ac4b5@epcms1p8> <20181128010903epcms1p7ef44541625212f6af3fc2d3e0d7eb390@epcms1p7> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: =?UTF-8?B?7Jyg6riI7ZmY?= To: soukjin.bae@samsung.com, "netdev@vger.kernel.org" , "lorenzo@google.com" Return-path: Received: from mail-pl1-f178.google.com ([209.85.214.178]:39712 "EHLO mail-pl1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbeK1P6j (ORCPT ); Wed, 28 Nov 2018 10:58:39 -0500 Received: by mail-pl1-f178.google.com with SMTP id 101so10480404pld.6 for ; Tue, 27 Nov 2018 20:58:21 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/27/2018 08:57 PM, Eric Dumazet wrote: > > > On 11/27/2018 05:09 PM, 배석진 wrote: >> Hello all, >> >> nobody concern about this? minor problem? :( >> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK. > > These sessions should have a timer, and eventually disappear. > > Do you have a test to demonstrate the issue ? > > I know Lorenzo wrote tests, so presumably new tests are needed. BTW your patch title is confusing. You are changing tcp_abort(), not tcp_close()