From: Petre Ovidiu PIRCALABU <ppircalabu@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Tamas K Lengyel <tamas@tklengyel.com>,
Alexandru Stefan ISAILA <aisaila@bitdefender.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH v2 05/10] vm_event: Move struct vm_event_domain to vm_event.c
Date: Wed, 17 Jul 2019 12:26:54 +0000 [thread overview]
Message-ID: <2ebf4ff471c2e4f093bf76e366b17036b4daea23.camel@bitdefender.com> (raw)
In-Reply-To: <fa5b2ba3-ac7c-2d29-4a6e-4eba61b3963f@suse.com>
On Wed, 2019-07-17 at 09:31 +0000, Jan Beulich wrote:
> On 16.07.2019 19:06, Petre Pircalabu wrote:
> > The vm_event_domain members are not accessed outside vm_event.c so
> > it's
> > better to hide de implementation details.
> >
> > Signed-off-by: Petre Pircalabu <ppircalabu@bitdefender.com>
> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Acked-by: Tamas K Lengyel <tamas@tklengyel.com>
> > ---
> > xen/common/vm_event.c | 26 ++++++++++++++++++++++++++
> > xen/include/xen/sched.h | 26 +-------------------------
> > 2 files changed, 27 insertions(+), 25 deletions(-)
>
> Ah, here it comes. This would better have been ahead of the other
> change (where I did comment).
>
> Jan
I will reorder the patches in the next iteration.
Many thanks for your comments,
Petre
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-17 12:27 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 17:06 [Xen-devel] [PATCH v2 00/10] Per vcpu vm_event channels Petre Pircalabu
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 01/10] vm_event: Define VM_EVENT type Petre Pircalabu
2019-07-16 20:59 ` Tamas K Lengyel
2019-07-17 7:59 ` Petre Ovidiu PIRCALABU
2019-07-17 8:49 ` Alexandru Stefan ISAILA
2019-07-17 9:57 ` Petre Ovidiu PIRCALABU
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 02/10] vm_event: Remove "ring" suffix from vm_event_check_ring Petre Pircalabu
2019-07-17 9:11 ` Alexandru Stefan ISAILA
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 03/10] vm_event: Add 'struct domain' backpointer to vm_event_domain Petre Pircalabu
2019-07-16 21:02 ` Tamas K Lengyel
2019-07-17 9:28 ` Jan Beulich
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 04/10] vm_event: Simplify vm_event interface Petre Pircalabu
2019-07-16 21:04 ` Tamas K Lengyel
2019-07-17 11:13 ` Alexandru Stefan ISAILA
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 05/10] vm_event: Move struct vm_event_domain to vm_event.c Petre Pircalabu
2019-07-17 9:31 ` Jan Beulich
2019-07-17 12:26 ` Petre Ovidiu PIRCALABU [this message]
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 06/10] vm_event: Decouple implementation details from interface Petre Pircalabu
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 07/10] vm_event: Add vm_event_ng interface Petre Pircalabu
2019-07-16 21:13 ` Tamas K Lengyel
2019-07-17 12:13 ` Petre Ovidiu PIRCALABU
2019-07-17 10:06 ` Jan Beulich
2019-07-17 12:38 ` Tamas K Lengyel
2019-07-17 13:12 ` Jan Beulich
2019-07-17 14:41 ` Petre Ovidiu PIRCALABU
2019-07-17 16:32 ` Jan Beulich
2019-07-17 18:42 ` Paul Durrant
2019-07-18 13:59 ` Petre Ovidiu PIRCALABU
2019-07-18 14:44 ` Jan Beulich
2019-07-18 14:55 ` Petre Ovidiu PIRCALABU
2019-07-31 12:53 ` Petre Ovidiu PIRCALABU
2019-07-31 13:09 ` Jan Beulich
2019-07-19 7:56 ` Paul Durrant
2019-07-19 8:22 ` Jan Beulich
2019-07-19 8:26 ` Paul Durrant
2019-07-19 11:23 ` Petre Ovidiu PIRCALABU
2019-07-19 12:11 ` Paul Durrant
2019-07-19 12:32 ` Jan Beulich
2019-07-19 12:37 ` Paul Durrant
2019-07-19 12:59 ` Jan Beulich
2019-07-19 17:40 ` Petre Ovidiu PIRCALABU
2019-07-22 7:58 ` Paul Durrant
2019-07-22 7:59 ` Jan Beulich
2019-07-22 10:44 ` Petre Ovidiu PIRCALABU
2019-07-17 13:42 ` Alexandru Stefan ISAILA
2019-07-17 14:46 ` Petre Ovidiu PIRCALABU
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 08/10] xen-access: Use getopt_long for cmdline parsing Petre Pircalabu
2019-07-16 21:09 ` Tamas K Lengyel
2019-07-17 11:16 ` Alexandru Stefan ISAILA
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 09/10] xen-access: Code cleanup Petre Pircalabu
2019-07-16 21:07 ` Tamas K Lengyel
2019-07-17 11:18 ` Alexandru Stefan ISAILA
2019-07-16 17:06 ` [Xen-devel] [PATCH v2 10/10] xen-access: Add support for vm_event_ng interface Petre Pircalabu
2019-07-16 20:45 ` [Xen-devel] [PATCH v2 00/10] Per vcpu vm_event channels Tamas K Lengyel
2019-07-17 9:14 ` Petre Ovidiu PIRCALABU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ebf4ff471c2e4f093bf76e366b17036b4daea23.camel@bitdefender.com \
--to=ppircalabu@bitdefender.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.