From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02F2C433F5 for ; Wed, 29 Sep 2021 11:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93BCA613D3 for ; Wed, 29 Sep 2021 11:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245654AbhI2LPx (ORCPT ); Wed, 29 Sep 2021 07:15:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54153 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245644AbhI2LPw (ORCPT ); Wed, 29 Sep 2021 07:15:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632914050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t2qm0hCzWxCCkmN0krux7HAVAkutvn7TaWklAankZlA=; b=KK89QK7VIX1EDWh9/WyFGtptF4lwUqR3DpyiQVBLysd2BcMKQm10shUsshZ4vbOxeBP5JX VJAfXLOBdEoT3ycG14Juf7PZUMwkJpYJbDoCuayRKrqYsHfruObRKJ6NaUzDUWLGAKLPqW 87vHfy3joooqBZryqmfzzgg8fIA8ZKo= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-fxyU5qqzP6asPjMV5mqHIg-1; Wed, 29 Sep 2021 07:14:09 -0400 X-MC-Unique: fxyU5qqzP6asPjMV5mqHIg-1 Received: by mail-ed1-f69.google.com with SMTP id 1-20020a508741000000b003da559ba1eeso2028892edv.13 for ; Wed, 29 Sep 2021 04:14:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=t2qm0hCzWxCCkmN0krux7HAVAkutvn7TaWklAankZlA=; b=m4DuEbaMCpQOZwQi3g8ih6+2z9rTCHB//pwNVTVWw4KmZxrsWy4liSPX9xId6QNT7h IVjw+4Bn9c9MpG6k16sqRUCUMriLJj64+J1/FShDjsx5I06H5ec8lMOcrKx03t5FeFpe wgMtCw5MKt1LmrLJyTWPylWLZaqHE7AQnlR0aRoE14kkYuHZkBChZbh+o/GwJ2gwe5bE FVx+7JzwmPU9IstNoHfAMwoZaYySR8Lb6NtBqMvsA8TAFrfxc7dglg3afIGZcpX0tHCb +0wlH6z3/op7shFzpUg1Mo2RMlS9pE5NTCYVNICrikbag4OmhjNWncvNsd9Jl2r8tGNO uF2A== X-Gm-Message-State: AOAM530yUaoZr9uzMPWvOD1s5rCgkcJIyYZYu81Z8NZH18fXMp69ESsj TrWZoqzVFEFqIWGTqbqdfUJmNBzwRhlgqYTOpqvl6+5VMyE4e697ao/Nyxzm9nafGMfuMoFb53o Mxv4JsHtdQHHrvwq81S4Nfg5E X-Received: by 2002:a17:906:1706:: with SMTP id c6mr13420345eje.343.1632914048400; Wed, 29 Sep 2021 04:14:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0xzNd3p3tUScVs7zgoHxcssecqfrmDnLfZ9bb6/8V3tpSWfOP7Z4wDUQW7OXzcoz/ymHWmQ== X-Received: by 2002:a17:906:1706:: with SMTP id c6mr13420322eje.343.1632914048184; Wed, 29 Sep 2021 04:14:08 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id b27sm1219844ejq.34.2021.09.29.04.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 04:14:07 -0700 (PDT) Message-ID: <2ecaca21-fa8f-f4c1-db2b-8eee86719f6f@redhat.com> Date: Wed, 29 Sep 2021 13:13:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3 02/31] KVM: MMU: Introduce struct kvm_page_fault Content-Language: en-US To: David Matlack Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, seanjc@google.com, Isaku Yamahata References: <20210924163152.289027-1-pbonzini@redhat.com> <20210924163152.289027-3-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/21 01:25, David Matlack wrote: >> +struct kvm_page_fault { >> + /* arguments to kvm_mmu_do_page_fault. */ >> + const gpa_t addr; >> + const u32 error_code; >> + const bool prefault; > This is somewhat tangential to your change but... I notice KVM uses > "prefetch" and "prefault" interchangably. If we changed prefault to > prefetch here and in kvm_mmu_do_page_fault then that would make the > naming consistent throughout KVM ("prefetch" for everything). > Sounds good. Paolo