From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus recovery Date: Thu, 28 Sep 2017 13:54:55 +0300 Message-ID: <2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com> References: <1504073857-122449-1-git-send-email-preid@electromag.com.au> <1504073857-122449-2-git-send-email-preid@electromag.com.au> <1506595483.16112.137.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:18492 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbdI1Ky6 (ORCPT ); Thu, 28 Sep 2017 06:54:58 -0400 In-Reply-To: <1506595483.16112.137.camel@linux.intel.com> Content-Language: en-US Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Andy Shevchenko , Phil Reid , mika.westerberg@linux.intel.com, wsa@the-dreams.de, tim@krieglstein.org, linux-i2c@vger.kernel.org On 09/28/2017 01:44 PM, Andy Shevchenko wrote: >> interface. This will allow individual driver to be updated and tested >> individual to switch to using the gpiod interface. > >> int scl_gpio; >> int sda_gpio; >> + struct gpio_desc *scl_gpiod; >> + struct gpio_desc *sda_gpiod; > > I think we even could get rid of plain integers completely. > In case some call needs it we can derive it still from the descriptor. > I guess it's still worth to split that into multiple patches and those driver conversion and integer removal can be follow up patches somewhere in the future? -- Jarkko