From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47803)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1fOOpA-0000gj-PS
	for qemu-devel@nongnu.org; Thu, 31 May 2018 10:45:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1fOOp7-0004ib-NJ
	for qemu-devel@nongnu.org; Thu, 31 May 2018 10:45:08 -0400
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57540 helo=mx1.redhat.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <eblake@redhat.com>) id 1fOOp7-0004iE-J5
	for qemu-devel@nongnu.org; Thu, 31 May 2018 10:45:05 -0400
References: <20180531051641.8473-1-peterx@redhat.com>
	<20180531051641.8473-4-peterx@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <2ed65040-ddce-653e-c7c5-1d0b02c91e08@redhat.com>
Date: Thu, 31 May 2018 09:44:46 -0500
MIME-Version: 1.0
In-Reply-To: <20180531051641.8473-4-peterx@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob",
 turn oob on by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, "Daniel P . Berrange" <berrange@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Eric Auger <eric.auger@redhat.com>, John Snow <jsnow@redhat.com>, Markus Armbruster <armbru@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>

On 05/31/2018 12:16 AM, Peter Xu wrote:
> There was a regression reported by Eric Auger before with OOB:
> 
>    http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
> 
> The fix is 951702f39c ("monitor: bind dispatch bh to iohandler context",
> 2018-04-10), which is in master already.

s/, which is in master already//

(when reading the git log, it can be assumed that any commit id 
referenced is already in master)

> 
> For the bug, we turned Out-Of-Band feature of monitors off for 2.12
> release.  Now we turn that on again after the 2.12 release.
> 
> This patch partly reverts be933ffc23 (monitor: new parameter "x-oob"),
> meanwhile turn it on again by default for non-MUX QMPs.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   include/monitor/monitor.h |  1 -
>   monitor.c                 | 17 +----------------
>   tests/qmp-test.c          |  2 +-
>   vl.c                      |  5 -----
>   4 files changed, 2 insertions(+), 23 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org