From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FC3CC00144 for ; Mon, 1 Aug 2022 18:59:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1425683FA1; Mon, 1 Aug 2022 20:59:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qkd8NhPy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8AE9C84027; Mon, 1 Aug 2022 20:59:46 +0200 (CEST) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 56BFF83F82 for ; Mon, 1 Aug 2022 20:59:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ed1-x52f.google.com with SMTP id b96so4650226edf.0 for ; Mon, 01 Aug 2022 11:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OU3aCDj+Y6Yn+Kh1zInmcE4nI9D43TGaDoG1cr+J/jU=; b=qkd8NhPyyCNG4nYBHq5Mt5U4dlzrKxGc9cMgGHbjSrgVJH42gaHTtOnn1ZPQsT+9Gr henHjnDVINQiugAo4pquCLEKXrFMc8cuHlfyUAp0vD9qBB705/29dewy0v1645vXAdO5 UliQaNSovYqPJANq8byIl0MDAHsK5SV9cWIk9niLSphttFiN6VGBH3IbT/lzoXEFpWWQ Yix1Oqqk8cx62IGhMIl/myP8Hxv2HWkiYA7EX8LuTNHlRkA0kZrqpfPeU2KuAUOkdz95 W/EJ6QFUV+/H0rVmgkBkwDaWr3AFF1CBi9/5mWDwKNOmfQe3WG1WlJ3onX6qd3HToXMn ynYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OU3aCDj+Y6Yn+Kh1zInmcE4nI9D43TGaDoG1cr+J/jU=; b=7WN1lZYQHrFnNO2bjHhuq3tA4mFXbxw43q/gdj8bECM6EKXi38tt9pvmNhtUnzWPrk DPE1Pln9KgpBdnqJO9p7m7Kbq3xuDzfo76/C6hCJqRYnVVGwHcOXDOfP9PfA7gVW2OVl QPCwulz+TyPFXHn1CQBLrCqYkCao0jMUPtNaUtt9TL6ij/LEODv+sNzqbcBTGnj8PhNS Pdq0VVrCb7CVpVbwpndXX+Qe3KUizONYD9iPC1rpTBZsQ1kY/uqm9SBgCPdh1ObMcnkU 8tsYKGgrY+xSR+WOg+jEUWeHjFz/suhDy+z1PIzTzCJBRgWdt+Gy34m+BHYYJ511dLRw 0FWg== X-Gm-Message-State: AJIora/3DiY+QsFa2OYT7vbrl1kDVFEHlKyvILlnvbGa1D9Fgx5PjfYx c1AUxKa/s22oYk1cZiCTT+k= X-Google-Smtp-Source: AGRyM1sOv4VLUTCajosN/g1TmAuH2Dhhm86HPQOYxEAmULV79tNvBa47K7S1yIs/49yvzHbmj3m7LA== X-Received: by 2002:a05:6402:149:b0:431:7dde:9b59 with SMTP id s9-20020a056402014900b004317dde9b59mr17071596edu.339.1659380383889; Mon, 01 Aug 2022 11:59:43 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id s11-20020a056402014b00b0043cc66d7accsm7188960edu.36.2022.08.01.11.59.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Aug 2022 11:59:43 -0700 (PDT) Message-ID: <2ede24c8-ab44-e1b2-1f31-dd100ea84f28@gmail.com> Date: Mon, 1 Aug 2022 20:59:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 3/8] rockchip: remove binman temporary files when cleaning Content-Language: en-US To: Quentin Schulz Cc: bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, jagan@amarulasolutions.com, alpernebiyasak@gmail.com, xypron.glpk@gmx.de, heiko.thiery@gmail.com, u-boot@lists.denx.de, Quentin Schulz References: <20220801160610.2330151-1-foss+uboot@0leil.net> <20220801160610.2330151-4-foss+uboot@0leil.net> From: Johan Jonker In-Reply-To: <20220801160610.2330151-4-foss+uboot@0leil.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Quentin, Beside removing the "real" annoyance is that these files popup when adding with "git add ." and are blocking branch changing with "git branch ...". Maybe add to ".gitignore" as well or delete immediately. What's the use to keep them around? Johan On 8/1/22 18:06, Quentin Schulz wrote: > From: Quentin Schulz > > Binman mkimage entry generates temporary files so let's remove them > when calling `make clean`. > > Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry") > Cc: Quentin Schulz > Reported-by: Johan Jonker > Signed-off-by: Quentin Schulz > --- > > added in v3 > > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index ff25f92974..bbb2a4c088 100644 > --- a/Makefile > +++ b/Makefile > @@ -2220,7 +2220,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h \ > lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \ > idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \ > mkimage-out.spl.mkimage mkimage.spl.mkimage imx-boot.map \ > - itb.fit.fit itb.fit.itb itb.map spl.map > + itb.fit.fit itb.fit.itb itb.map spl.map mkimage-out.rom.mkimage \ > + mkimage.rom.mkimage rom.map simple-bin.map > > # Directories & files removed with 'make mrproper' > MRPROPER_DIRS += include/config include/generated spl tpl \