Re: [PATCH v7 1/4] m68k: Kconfig - select core PCMCIA support module for Amiga PCMCIA

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Geert,

On 04/09/21 02:14, Geert Uytterhoeven wrote:
> Hi Michael,
>> How do I make sure CONFIG_PCMCIA gets selected as module as well? I can
>> select this when CONFIG_APNE is set, from
>> drivers/net/ethernet/8390/Kconfig, but I'd then have to protect the
>> cftable parse hook in amiga/pcmcia.c against the case where CONFIG_APNE
>> is not selected.
>
> That will be fixed automatically by making AMIGA_PCMCIA tristate.
> Select from a modular symbol will make the target modular, too.

Maybe when starting from a new .config - if no one had these set on m68k 
before, we're OK.

>
>> Not to mention we need to rename amiga/pcmcia.c to avoid a module naming
>> conflict.

No objection? Anything in particular to be careful about when renaming a 
file?

>>
>> Just including cistpl.o as a module is not an option unfortunately - too
>> many dependencies.
>>
>> And I don't think we need CONFIG_PCMCIA_PROBE=Y?
>
> No idea if we need that...

It's about IRQ probing, so yechhh .... OTOH, it doesn't hurt as we'll 
never call the IRQ probe hooks, so we can just as well leave it active.

> -default y if ISA && !ARCH_SA1100 && !PARISC
> +default y if ISA && !ARCH_SA1100 && !PARISC && !AMIGA_PCMCIA
>
> (wondering how many platforms that can use PCMCIA are left, and if
>  this can be converted into positive logic?)

You're welcome to open that discussion. Hope it won't backfire...

Cheers,

	Michael

>
> Gr{oetje,eeting}s,
>
>                         Geert
>