From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Wu Date: Sat, 9 May 2020 14:33:55 +0800 Subject: [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional In-Reply-To: <5ac75ce6-03f1-899f-0231-5f8bf0fc29e1@wwwdotorg.org> References: <20200430103656.29728-1-david.wu@rock-chips.com> <20200430104343.30843-1-david.wu@rock-chips.com> <5ac75ce6-03f1-899f-0231-5f8bf0fc29e1@wwwdotorg.org> Message-ID: <2ee7ff5d-9cd5-1a6d-6f4e-5cf17d0a1c05@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stephen, ? 2020/5/1 ??6:45, Stephen Warren ??: > Oh... Judging by your email, you're trying to make this driver work on a > Rockchip system. However, you're editing an STM32-specific probe > function. You should introduce a new probe function for Rockchip if it > needs to work differently to the existing STM32 code. > > Also, mac_clk_rx isn't a valid DT property name; they aren't supposed to > have _ in them. I don't see mac_clk_rx or mac-clk-rx in the DT binding > file in Documentation/bindings/net/rockchip-dwmac.txt the kernel. That > should probably be submitted/reviewed/applied before using the binding... If necessary, I can rewrite a function to obtain resources, but I think the function of rockchip and stm should be very similar, and can be shared.