On 09/20/2016 10:19 AM, Ian Jackson wrote: > Boris Ostrovsky writes ("Re: [PATCH v4 02/21] acpi: Prevent GPL-only code from seeping into non-GPL binaries"): >> But yes, I can split dsdt.asl as well. Should we keep _S5 definition as >> GPL-only? > I think once we're going down this route there is no benefit in trying > to argue for individual bits of code-that-was-once-Lenovo's that there > is no copyright interest. > > So I would split those lines out as well. That will mean multiple > includes. > > Does iasl have a suitable conditional include syntax or are you going > to use `cat' or something in the Makefile ? iasl has -I option but I don't see a conditional. (And I have very vague understanding of ASL syntax in case there is something that can be done in the language itself). I ran a quick test with 'cat' and it seems to work OK. Besides, we are already using 'cat' implicitly: we append mk_dsdt output to existing *asl file. -boris