From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v4 02/21] acpi: Prevent GPL-only code from
 seeping into non-GPL binaries
Date: Tue, 20 Sep 2016 10:58:16 -0400
Message-ID: <2ee995c7-ed69-30ba-e35a-4df946d1df9b@oracle.com>
References: <1474330779-10645-1-git-send-email-boris.ostrovsky@oracle.com>
 <1474330779-10645-3-git-send-email-boris.ostrovsky@oracle.com>
 <22497.3069.664514.929595@mariner.uk.xensource.com>
 <477f3aeb-fa46-1363-8e43-5f4b3f3d275b@oracle.com>
 <22497.17802.638667.384644@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3482553137694096194=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22497.17802.638667.384644@mariner.uk.xensource.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Lars Kurth <lars.kurth@citrix.com>, wei.liu2@citrix.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org, julien.grall@arm.com, jbeulich@suse.com, zhaoshenglong@huawei.com, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============3482553137694096194==
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="kSX9rdmAoTCwOu8Ft0P3PQWJkRfukBttp"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--kSX9rdmAoTCwOu8Ft0P3PQWJkRfukBttp
Content-Type: multipart/mixed; boundary="4pB6LrOwrvKD15CK7H7xlCWB3h47TShJi";
 protected-headers="v1"
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org, jbeulich@suse.com, andrew.cooper3@citrix.com,
 wei.liu2@citrix.com, zhaoshenglong@huawei.com, julien.grall@arm.com,
 roger.pau@citrix.com, Lars Kurth <lars.kurth@citrix.com>
Message-ID: <2ee995c7-ed69-30ba-e35a-4df946d1df9b@oracle.com>
Subject: Re: [PATCH v4 02/21] acpi: Prevent GPL-only code from seeping into
 non-GPL binaries
References: <1474330779-10645-1-git-send-email-boris.ostrovsky@oracle.com>
 <1474330779-10645-3-git-send-email-boris.ostrovsky@oracle.com>
 <22497.3069.664514.929595@mariner.uk.xensource.com>
 <477f3aeb-fa46-1363-8e43-5f4b3f3d275b@oracle.com>
 <22497.17802.638667.384644@mariner.uk.xensource.com>
In-Reply-To: <22497.17802.638667.384644@mariner.uk.xensource.com>

--4pB6LrOwrvKD15CK7H7xlCWB3h47TShJi
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 09/20/2016 10:19 AM, Ian Jackson wrote:
> Boris Ostrovsky writes ("Re: [PATCH v4 02/21] acpi: Prevent GPL-only co=
de from seeping into non-GPL binaries"):
>> But yes, I can split dsdt.asl as well. Should we keep _S5 definition a=
s
>> GPL-only?
> I think once we're going down this route there is no benefit in trying
> to argue for individual bits of code-that-was-once-Lenovo's that there
> is no copyright interest.
>
> So I would split those lines out as well.  That will mean multiple
> includes.
>
> Does iasl have a suitable conditional include syntax or are you going
> to use `cat' or something in the Makefile ?


iasl has -I<path> option but I don't see a conditional. (And I have very
vague understanding of ASL syntax in case there is something that can be
done in the language itself).

I ran a quick test with 'cat' and it seems to work OK. Besides, we are
already using 'cat' implicitly: we append mk_dsdt output to existing
*asl file.


-boris


--4pB6LrOwrvKD15CK7H7xlCWB3h47TShJi--

--kSX9rdmAoTCwOu8Ft0P3PQWJkRfukBttp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJX4U6SAAoJEIredpCGysGytmwP/inSnjJZYx33FimFBPbT3MLC
C9nDqIYFbwW4xhpb+UObnHVdHAbaqQYXuSRpvB5hgscVllI3MPI8yZB+ZAkfJ7/I
eaP+qGOGHT1/2BhLkf7XIeaHNWtV7fXGnKU5Hfy8LW0L8K+nW5g3Gud7c8GavM/O
kzEH9Mc98TOwilbjN5lctWCMVxdzZfM5lgKAsGVzXPvj247BsQ1AkP6I/HcwIjJb
jtBuvCKHC8tTyNj9JPKQ5hZTYWGQ+nYqqqp00jFgBfvL/vQClxbopkqc9tJBCDn4
81sG7dscZaOdm/QjRt6m0hMF/J4ptXIZntwfYROneCymAnXah6vsMmyZVLbbb0CI
4f1G4b/cqXldGjxENNri38OQWkQCyFfOh8gGsD9aXc+SVdVOTHfXtoUYGmsU3asc
RMQIcntVQFzbYtuWJIMYmWVIQKVF5/RfV64xK7K+SItY7Fox7yc9buZktxosOvKR
ays7VWzRNg+Ov2cyUbtWWToYpG+Jou7Kc0/gLO0iKS5A56GGiPyLT7O+bp9naY+T
3PBWWaFwpek45EpAPOBSk5p/0wmS6iA7lSUs7DsvYc5bFfyRC+c1GJmGGEyf9Fg4
bzsEQ3Urg8S5uwsJzGBkpklgwDtW/Eyy2MOEthR9M0UKZKDdS30Sr8HVEK6WD/aH
97E4YtRnmjQYil11T022
=UD3e
-----END PGP SIGNATURE-----

--kSX9rdmAoTCwOu8Ft0P3PQWJkRfukBttp--


--===============3482553137694096194==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============3482553137694096194==--