From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Katarzyna Dec <katarzyna.dec@intel.com>
Cc: igt-dev@lists.freedesktop.org, Matthew Auld <matthew.auld@intel.com>
Subject: Re: [igt-dev] [RFT v4 3/6] igt/lib: Add wrapper to check if gtt mapping is available
Date: Tue, 16 Apr 2019 09:43:32 -0700 [thread overview]
Message-ID: <2eefd88f-141b-afef-f55f-304b14f37b18@intel.com> (raw)
In-Reply-To: <155542129718.25605.9359331065905834660@skylake-alporthouse-com>
On 16/04/19 06:28, Chris Wilson wrote:
> Quoting Katarzyna Dec (2019-04-16 14:25:28)
>> Sorry Antonio for entering this patchset discussion so late :).
>>
>> On Mon, Mar 25, 2019 at 04:20:40PM -0700, Antonio Argenziano wrote:
>>> +static int gem_mmap__gtt_version(int fd)
>>> +{
>>> + static int gtt_version = ~0;
>> What is the reason that you are using '~0' value here and not -1?
I use -1 for when there is no mappable aperture.
>
> The real question is why is it still a static int at all.
Ops, I guess I forgot about that.
Antonio
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-16 16:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 23:20 [igt-dev] [RFT v4 1/6] lib/i915/gem_mman: Remove static variables Antonio Argenziano
2019-03-25 23:20 ` [igt-dev] [RFT v4 2/6] lib/i915: Add mmap_offset support Antonio Argenziano
2019-03-25 23:20 ` [igt-dev] [RFT v4 3/6] igt/lib: Add wrapper to check if gtt mapping is available Antonio Argenziano
2019-04-16 13:25 ` Katarzyna Dec
2019-04-16 13:28 ` Chris Wilson
2019-04-16 16:43 ` Antonio Argenziano [this message]
2019-03-25 23:20 ` [igt-dev] [RFT v4 4/6] igt/i915: Require GTT mapping to be available when needed Antonio Argenziano
2019-03-25 23:36 ` Chris Wilson
2019-03-27 21:05 ` Antonio Argenziano
2019-03-27 21:19 ` Chris Wilson
2019-04-11 18:13 ` Antonio Argenziano
2019-04-11 20:07 ` Chris Wilson
2019-04-11 21:27 ` Antonio Argenziano
2019-03-27 21:24 ` Chris Wilson
2019-04-05 18:00 ` Antonio Argenziano
2019-04-05 18:04 ` Chris Wilson
2019-04-11 18:13 ` Antonio Argenziano
2019-04-11 20:08 ` Chris Wilson
2019-04-16 14:38 ` Katarzyna Dec
2019-03-25 23:20 ` [igt-dev] [RFT v4 5/6] Coherency tests that need to be using WC + sync Antonio Argenziano
2019-04-16 14:43 ` Katarzyna Dec
2019-03-25 23:20 ` [igt-dev] [RFT v4 6/6] igt/lib: If mappable aperture is missing return 0 size Antonio Argenziano
2019-04-17 9:55 ` Katarzyna Dec
2019-03-26 9:39 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [RFT,v4,1/6] lib/i915/gem_mman: Remove static variables Patchwork
2019-04-16 13:27 ` [igt-dev] [RFT v4 1/6] " Katarzyna Dec
2019-04-16 15:29 ` Antonio Argenziano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eefd88f-141b-afef-f55f-304b14f37b18@intel.com \
--to=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.