[PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

They can't be built without opengl in DISTRO_FEATURES.
[snip]
|webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
fatal error: GL/gl.h: No such file or directory
[snip]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
index a528c5d..93d74bb 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
@@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
 
 inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
 
-# depends on libxt
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
            gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
-- 
2.7.4

[PATCH 2/2] weston: fix build failure with --disable-egl

[Hongxu Jia]

Backport a patch from upstream to fix build failure
with --disable-egl
[snip]
|weston-4.0.0/clients/simple-dmabuf-drm.c:783:30: error:
'EGL_NO_DISPLAY' undeclared (first use in this function)
[snip]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 ...ple-dmabuf-drm-fix-build-with-disable-egl.patch | 71 ++++++++++++++++++++++
 meta/recipes-graphics/wayland/weston_4.0.0.bb      |  1 +
 2 files changed, 72 insertions(+)
 create mode 100644 meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch

diff --git a/meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch b/meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch
new file mode 100644
index 0000000..4820124
--- /dev/null
+++ b/meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch
@@ -0,0 +1,71 @@
+From 2b2d911ef088c430e9bdd135daadf1123d474b24 Mon Sep 17 00:00:00 2001
+From: Emilio Pozuelo Monfort <pochu27@gmail.com>
+Date: Mon, 3 Sep 2018 15:42:10 +0800
+Subject: [PATCH] simple-dmabuf-drm: fix build with --disable-egl
+
+Just rely on getting the supported formats through the dmabuf
+extension.
+
+Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
+Reviewed-by: Daniel Stone <daniels@collabora.com>
+
+Upstream-Status: Backport [https://anongit.freedesktop.org/git/wayland/weston.git]
+
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+---
+ clients/simple-dmabuf-drm.c | 11 -----------
+ configure.ac                |  2 +-
+ 2 files changed, 1 insertion(+), 12 deletions(-)
+
+diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c
+index 2975f3a..88ec451 100644
+--- a/clients/simple-dmabuf-drm.c
++++ b/clients/simple-dmabuf-drm.c
+@@ -53,7 +53,6 @@
+ 
+ #include <wayland-client.h>
+ #include "shared/zalloc.h"
+-#include "shared/platform.h"
+ #include "xdg-shell-unstable-v6-client-protocol.h"
+ #include "fullscreen-shell-unstable-v1-client-protocol.h"
+ #include "linux-dmabuf-unstable-v1-client-protocol.h"
+@@ -763,7 +762,6 @@ static struct display *
+ create_display(int opts, int format)
+ {
+ 	struct display *display;
+-	const char *extensions;
+ 
+ 	display = malloc(sizeof *display);
+ 	if (display == NULL) {
+@@ -776,15 +774,6 @@ create_display(int opts, int format)
+ 	display->req_dmabuf_immediate = opts & OPT_IMMEDIATE;
+ 	display->req_dmabuf_modifiers = (format == DRM_FORMAT_NV12);
+ 
+-	/*
+-	 * hard code format if the platform egl doesn't support format
+-	 * querying / advertising.
+-	 */
+-	extensions = eglQueryString(EGL_NO_DISPLAY, EGL_EXTENSIONS);
+-	if (extensions && !weston_check_egl_extension(extensions,
+-				"EGL_EXT_image_dma_buf_import_modifiers"))
+-		display->xrgb8888_format_found = 1;
+-
+ 	display->registry = wl_display_get_registry(display->display);
+ 	wl_registry_add_listener(display->registry,
+ 				 &registry_listener, display);
+diff --git a/configure.ac b/configure.ac
+index 48cf5cb..e6e9a3f 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -386,7 +386,7 @@ AC_ARG_ENABLE(simple-dmabuf-drm-client,
+                              [do not build the simple dmabuf drm client]),,
+               enable_simple_dmabuf_drm_client="auto")
+ if ! test "x$enable_simple_dmabuf_drm_client" = "xno"; then
+-  PKG_CHECK_MODULES(SIMPLE_DMABUF_DRM_CLIENT, [wayland-client libdrm egl], [have_simple_dmabuf_libs=yes],
++  PKG_CHECK_MODULES(SIMPLE_DMABUF_DRM_CLIENT, [wayland-client libdrm], [have_simple_dmabuf_libs=yes],
+ 		    [have_simple_dmabuf_libs=no])
+ 
+   PKG_CHECK_MODULES(LIBDRM_PLATFORM_FREEDRENO, [libdrm_freedreno],
+-- 
+2.7.4
+
diff --git a/meta/recipes-graphics/wayland/weston_4.0.0.bb b/meta/recipes-graphics/wayland/weston_4.0.0.bb
index 3d192cf..61e2881 100644
--- a/meta/recipes-graphics/wayland/weston_4.0.0.bb
+++ b/meta/recipes-graphics/wayland/weston_4.0.0.bb
@@ -11,6 +11,7 @@ SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
            file://0001-make-error-portable.patch \
            file://xwayland.weston-start \
            file://0001-weston-launch-Provide-a-default-version-that-doesn-t.patch \
+           file://0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch \
 "
 SRC_URI[md5sum] = "33709aa4d5916f89643fca0fc0064b39"
 SRC_URI[sha256sum] = "a0fc0ae7ef83dfbed12abfe9b8096a24a7dd00705e86fa0db1e619ded18b4b58"
-- 
2.7.4

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Alexander Kanavin]

2018-09-03 11:35 GMT+02:00 Hongxu Jia <hongxu.jia@windriver.com>:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]

Apologies, but NAK.

Webkit recipe already has the necessary configuration to handle this:

PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
'x11', 'wayland' ,d)} \
                   ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
'webgl opengl', '' ,d)} \

PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
PACKAGECONFIG[opengl] = "-DENABLE_OPENGL=ON,-DENABLE_OPENGL=OFF,virtual/libgl"


If disabling opengl does not work, then you should look closer into
why, instead of just requiring opengl to be present always.

Alex

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Khem Raj]

On Mon, Sep 3, 2018 at 2:35 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>

whichever source file is including OpenGLShims.h should ensure that
openGL is enabled
before including this header. you can check that with #if USE(OPENGL)
and keep in mind
that webkit has enable_opengl which means both openGL and openGLES support but
use_opengl and use_opengles are mutually exclusive. So if the
component where its failing
might be only supported with opengles2 then we need to ensure that we
check for that before
including the above header  e.g.

if !USE(OPENGL_ES_2)
 #include "OpenGLShims.h"
 #endif



> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> index a528c5d..93d74bb 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
>
>  inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>
>  DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>             gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
> --
> 2.7.4
>

Re: [PATCH 2/2] weston: fix build failure with --disable-egl

[Khem Raj]

On Mon, Sep 3, 2018 at 2:35 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> Backport a patch from upstream to fix build failure
> with --disable-egl
> [snip]
> |weston-4.0.0/clients/simple-dmabuf-drm.c:783:30: error:
> 'EGL_NO_DISPLAY' undeclared (first use in this function)
> [snip]
>

LGTM

> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  ...ple-dmabuf-drm-fix-build-with-disable-egl.patch | 71 ++++++++++++++++++++++
>  meta/recipes-graphics/wayland/weston_4.0.0.bb      |  1 +
>  2 files changed, 72 insertions(+)
>  create mode 100644 meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch
>
> diff --git a/meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch b/meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch
> new file mode 100644
> index 0000000..4820124
> --- /dev/null
> +++ b/meta/recipes-graphics/wayland/weston/0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch
> @@ -0,0 +1,71 @@
> +From 2b2d911ef088c430e9bdd135daadf1123d474b24 Mon Sep 17 00:00:00 2001
> +From: Emilio Pozuelo Monfort <pochu27@gmail.com>
> +Date: Mon, 3 Sep 2018 15:42:10 +0800
> +Subject: [PATCH] simple-dmabuf-drm: fix build with --disable-egl
> +
> +Just rely on getting the supported formats through the dmabuf
> +extension.
> +
> +Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
> +Reviewed-by: Daniel Stone <daniels@collabora.com>
> +
> +Upstream-Status: Backport [https://anongit.freedesktop.org/git/wayland/weston.git]
> +
> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> +---
> + clients/simple-dmabuf-drm.c | 11 -----------
> + configure.ac                |  2 +-
> + 2 files changed, 1 insertion(+), 12 deletions(-)
> +
> +diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c
> +index 2975f3a..88ec451 100644
> +--- a/clients/simple-dmabuf-drm.c
> ++++ b/clients/simple-dmabuf-drm.c
> +@@ -53,7 +53,6 @@
> +
> + #include <wayland-client.h>
> + #include "shared/zalloc.h"
> +-#include "shared/platform.h"
> + #include "xdg-shell-unstable-v6-client-protocol.h"
> + #include "fullscreen-shell-unstable-v1-client-protocol.h"
> + #include "linux-dmabuf-unstable-v1-client-protocol.h"
> +@@ -763,7 +762,6 @@ static struct display *
> + create_display(int opts, int format)
> + {
> +       struct display *display;
> +-      const char *extensions;
> +
> +       display = malloc(sizeof *display);
> +       if (display == NULL) {
> +@@ -776,15 +774,6 @@ create_display(int opts, int format)
> +       display->req_dmabuf_immediate = opts & OPT_IMMEDIATE;
> +       display->req_dmabuf_modifiers = (format == DRM_FORMAT_NV12);
> +
> +-      /*
> +-       * hard code format if the platform egl doesn't support format
> +-       * querying / advertising.
> +-       */
> +-      extensions = eglQueryString(EGL_NO_DISPLAY, EGL_EXTENSIONS);
> +-      if (extensions && !weston_check_egl_extension(extensions,
> +-                              "EGL_EXT_image_dma_buf_import_modifiers"))
> +-              display->xrgb8888_format_found = 1;
> +-
> +       display->registry = wl_display_get_registry(display->display);
> +       wl_registry_add_listener(display->registry,
> +                                &registry_listener, display);
> +diff --git a/configure.ac b/configure.ac
> +index 48cf5cb..e6e9a3f 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -386,7 +386,7 @@ AC_ARG_ENABLE(simple-dmabuf-drm-client,
> +                              [do not build the simple dmabuf drm client]),,
> +               enable_simple_dmabuf_drm_client="auto")
> + if ! test "x$enable_simple_dmabuf_drm_client" = "xno"; then
> +-  PKG_CHECK_MODULES(SIMPLE_DMABUF_DRM_CLIENT, [wayland-client libdrm egl], [have_simple_dmabuf_libs=yes],
> ++  PKG_CHECK_MODULES(SIMPLE_DMABUF_DRM_CLIENT, [wayland-client libdrm], [have_simple_dmabuf_libs=yes],
> +                   [have_simple_dmabuf_libs=no])
> +
> +   PKG_CHECK_MODULES(LIBDRM_PLATFORM_FREEDRENO, [libdrm_freedreno],
> +--
> +2.7.4
> +
> diff --git a/meta/recipes-graphics/wayland/weston_4.0.0.bb b/meta/recipes-graphics/wayland/weston_4.0.0.bb
> index 3d192cf..61e2881 100644
> --- a/meta/recipes-graphics/wayland/weston_4.0.0.bb
> +++ b/meta/recipes-graphics/wayland/weston_4.0.0.bb
> @@ -11,6 +11,7 @@ SRC_URI = "https://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
>             file://0001-make-error-portable.patch \
>             file://xwayland.weston-start \
>             file://0001-weston-launch-Provide-a-default-version-that-doesn-t.patch \
> +           file://0001-simple-dmabuf-drm-fix-build-with-disable-egl.patch \
>  "
>  SRC_URI[md5sum] = "33709aa4d5916f89643fca0fc0064b39"
>  SRC_URI[sha256sum] = "a0fc0ae7ef83dfbed12abfe9b8096a24a7dd00705e86fa0db1e619ded18b4b58"
> --
> 2.7.4
>

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

On 2018年09月03日 17:54, Alexander Kanavin wrote:
> 2018-09-03 11:35 GMT+02:00 Hongxu Jia <hongxu.jia@windriver.com>:
>> They can't be built without opengl in DISTRO_FEATURES.
>> [snip]
>> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
>> fatal error: GL/gl.h: No such file or directory
>> [snip]
> Apologies, but NAK.
>
> Webkit recipe already has the necessary configuration to handle this:
>
> PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
> 'x11', 'wayland' ,d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
> 'webgl opengl', '' ,d)} \
>
> PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
> PACKAGECONFIG[opengl] = "-DENABLE_OPENGL=ON,-DENABLE_OPENGL=OFF,virtual/libgl"
>
>
> If disabling opengl does not work, then you should look closer into
> why, instead of just requiring opengl to be present always.
I am afraid whether opengl or not, it always requires virtual/libql
just like Ubuntu/Fedora does.

[Fedora webkitgtk.spec]
BuildRequires:  mesa-libGL-devel
[Fedora webkitgtk.spec]

[Ubuntu debian/control]
Build-Depends: libgl1-mesa-dev [!armel !armhf !arm64]
[Ubuntu debian/control]

I tried to move `virtual/libgl' from PACKAGECONFIG to DEPENDS,
but unfortunately, the provider of `virtual/libgl' -- mesa/mesa-ql,
they require `opengl 'or `vulkan' in distro features check.

//Hongxu

> Alex

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Alexander Kanavin]

2018-09-04 15:29 GMT+02:00 Hongxu Jia <hongxu.jia@windriver.com>:
>>> They can't be built without opengl in DISTRO_FEATURES.
>>> [snip]

> I am afraid whether opengl or not, it always requires virtual/libql
> just like Ubuntu/Fedora does.
>
> [Fedora webkitgtk.spec]
> BuildRequires:  mesa-libGL-devel
> [Fedora webkitgtk.spec]
>
> [Ubuntu debian/control]
> Build-Depends: libgl1-mesa-dev [!armel !armhf !arm64]
> [Ubuntu debian/control]

Fedora and Ubuntu have elected to enable opengl in their distros, that
does not in itself mean it cannot be disabled. So please disable it,
and inspect the source code for reasons it breaks the build. That
header file you cited  in particular is guarded by ENABLE_OPENGL
conditional, which should be false when opengl is switched off.


Alex

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[ChenQi]

ping

I think webkitgtk does require the 'opengl' distro feature.

Best Regards,
Chen Qi

On 09/03/2018 05:35 PM, Hongxu Jia wrote:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> index a528c5d..93d74bb 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
>   
>   inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>   
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>   
>   DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>              gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[ChenQi]

ping

I think webkitgtk does require the 'opengl' distro feature.

We have in mesa.inc:
PACKAGECONFIG ??= ".... \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 
'opengl egl gles gbm dri', '', d)} \
                    ..."

PROVIDES = " \
     ${@bb.utils.contains('PACKAGECONFIG', 'opengl', 'virtual/libgl', 
'', d)} \
     ${@bb.utils.contains('PACKAGECONFIG', 'gles', 'virtual/libgles1 
virtual/libgles2', '', d)} \
     ..."

And webkitgtk's source codes are like:
#if USE(LIBEPOXY)
// libepoxy headers have to be included before <ANGLE/ShaderLang.h> in 
order to avoid
// picking up khrplatform.h inclusion that's done in ANGLE.
#include <epoxy/gl.h>
#endif

#include <ANGLE/ShaderLang.h>
#include <wtf/text/WTFString.h>

#if PLATFORM(IOS)
#import <OpenGLES/ES2/glext.h>
#elif PLATFORM(MAC)
#include <OpenGL/gl.h>
#elif PLATFORM(WIN)
#include "OpenGLESShims.h"
#elif USE(LIBEPOXY)
// <epoxy/gl.h> already included above.
#elif USE(OPENGL_ES_2)
#include <GLES2/gl2.h>
#else
#include "OpenGLShims.h"
#endif

And libepoxy is wrapper around libgl.

So I think we can conclude 'opengl' is required distro feature for 
webkitgkt? At least this is the current situation in OE.

Best Regards,
Chen Qi

On 09/03/2018 05:35 PM, Hongxu Jia wrote:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> index a528c5d..93d74bb 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
>   
>   inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>   
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>   
>   DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>              gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Khem Raj]

On Mon, Oct 8, 2018 at 6:47 PM ChenQi <Qi.Chen@windriver.com> wrote:
>
> ping
>
> I think webkitgtk does require the 'opengl' distro feature.
>
> We have in mesa.inc:
> PACKAGECONFIG ??= ".... \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
> 'opengl egl gles gbm dri', '', d)} \
>                     ..."
>
> PROVIDES = " \
>      ${@bb.utils.contains('PACKAGECONFIG', 'opengl', 'virtual/libgl',
> '', d)} \
>      ${@bb.utils.contains('PACKAGECONFIG', 'gles', 'virtual/libgles1
> virtual/libgles2', '', d)} \
>      ..."
>
> And webkitgtk's source codes are like:
> #if USE(LIBEPOXY)
> // libepoxy headers have to be included before <ANGLE/ShaderLang.h> in
> order to avoid
> // picking up khrplatform.h inclusion that's done in ANGLE.
> #include <epoxy/gl.h>
> #endif
>
> #include <ANGLE/ShaderLang.h>
> #include <wtf/text/WTFString.h>
>
> #if PLATFORM(IOS)
> #import <OpenGLES/ES2/glext.h>
> #elif PLATFORM(MAC)
> #include <OpenGL/gl.h>
> #elif PLATFORM(WIN)
> #include "OpenGLESShims.h"
> #elif USE(LIBEPOXY)
> // <epoxy/gl.h> already included above.
> #elif USE(OPENGL_ES_2)
> #include <GLES2/gl2.h>
> #else
> #include "OpenGLShims.h"
> #endif
>
> And libepoxy is wrapper around libgl.
>
> So I think we can conclude 'opengl' is required distro feature for
> webkitgkt? At least this is the current situation in OE.

some sort of GL is needed yes. We indicate that with opengl losely
in OE

>
> Best Regards,
> Chen Qi
>
> On 09/03/2018 05:35 PM, Hongxu Jia wrote:
> > They can't be built without opengl in DISTRO_FEATURES.
> > [snip]
> > |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> > fatal error: GL/gl.h: No such file or directory
> > [snip]
> >
> > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> > ---
> >   meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> > index a528c5d..93d74bb 100644
> > --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> > @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
> >
> >   inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
> >
> > -# depends on libxt
> > -REQUIRED_DISTRO_FEATURES = "x11"
> > +REQUIRED_DISTRO_FEATURES = "x11 opengl"
> >
> >   DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
> >              gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

On 2018年10月09日 09:53, Khem Raj wrote:
> On Mon, Oct 8, 2018 at 6:47 PM ChenQi <Qi.Chen@windriver.com> wrote:
>> ping
>>
>> I think webkitgtk does require the 'opengl' distro feature.
>>
>> We have in mesa.inc:
>> PACKAGECONFIG ??= ".... \
>>                      ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
>> 'opengl egl gles gbm dri', '', d)} \
>>                      ..."
>>
>> PROVIDES = " \
>>       ${@bb.utils.contains('PACKAGECONFIG', 'opengl', 'virtual/libgl',
>> '', d)} \
>>       ${@bb.utils.contains('PACKAGECONFIG', 'gles', 'virtual/libgles1
>> virtual/libgles2', '', d)} \
>>       ..."
>>
>> And webkitgtk's source codes are like:
>> #if USE(LIBEPOXY)
>> // libepoxy headers have to be included before <ANGLE/ShaderLang.h> in
>> order to avoid
>> // picking up khrplatform.h inclusion that's done in ANGLE.
>> #include <epoxy/gl.h>
>> #endif
>>
>> #include <ANGLE/ShaderLang.h>
>> #include <wtf/text/WTFString.h>
>>
>> #if PLATFORM(IOS)
>> #import <OpenGLES/ES2/glext.h>
>> #elif PLATFORM(MAC)
>> #include <OpenGL/gl.h>
>> #elif PLATFORM(WIN)
>> #include "OpenGLESShims.h"
>> #elif USE(LIBEPOXY)
>> // <epoxy/gl.h> already included above.
>> #elif USE(OPENGL_ES_2)
>> #include <GLES2/gl2.h>
>> #else
>> #include "OpenGLShims.h"
>> #endif
>>
>> And libepoxy is wrapper around libgl.
>>
>> So I think we can conclude 'opengl' is required distro feature for
>> webkitgkt? At least this is the current situation in OE.
> some sort of GL is needed yes. We indicate that with opengl losely
> in OE
>
OK, I will send V2 since webkitgtk is upgraded to 2.20.5

and the weston backport fix is obsolete since weston is upgraded to 5.0

//Hongxu

>> Best Regards,
>> Chen Qi
>>
>> On 09/03/2018 05:35 PM, Hongxu Jia wrote:
>>> They can't be built without opengl in DISTRO_FEATURES.
>>> [snip]
>>> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
>>> fatal error: GL/gl.h: No such file or directory
>>> [snip]
>>>
>>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>>> ---
>>>    meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
>>> index a528c5d..93d74bb 100644
>>> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
>>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
>>> @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
>>>
>>>    inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>>>
>>> -# depends on libxt
>>> -REQUIRED_DISTRO_FEATURES = "x11"
>>> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>>>
>>>    DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>>>               gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[PATCH V2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

They can't be built without opengl in DISTRO_FEATURES.
[snip]
|webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
fatal error: GL/gl.h: No such file or directory
[snip]

Some sort of GL is needed yes. We indicate that with opengl losely in OE

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.20.5.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
index c8d4f94..7f1ffce 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
@@ -30,8 +30,7 @@ SRC_URI[sha256sum] = "15c0f8d26e9605afe0948d161ba5fd82efee8eda2debd409fd40a440ac
 
 inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
 
-# depends on libxt
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
            gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
-- 
2.10.2

Re: [PATCH V2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Andre McCurdy]

On Tue, Oct 9, 2018 at 8:09 PM, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>
> Some sort of GL is needed yes. We indicate that with opengl losely in OE

It's loosely, not losely.

> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/recipes-sato/webkit/webkitgtk_2.20.5.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> index c8d4f94..7f1ffce 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> @@ -30,8 +30,7 @@ SRC_URI[sha256sum] = "15c0f8d26e9605afe0948d161ba5fd82efee8eda2debd409fd40a440ac
>
>  inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>
>  DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>             gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
> --
> 2.10.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev2)

[Patchwork]

== Series Details ==

Series: "webkitgtk: add opengl to REQUI..." and 1 more (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/13867/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 417245923c)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

[PATCH V3] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

They can't be built without opengl in DISTRO_FEATURES.
[snip]
|webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
fatal error: GL/gl.h: No such file or directory
[snip]

Some sort of GL is needed yes. We indicate that with opengl loosely in OE

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.20.5.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
index c8d4f94..7f1ffce 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
@@ -30,8 +30,7 @@ SRC_URI[sha256sum] = "15c0f8d26e9605afe0948d161ba5fd82efee8eda2debd409fd40a440ac
 
 inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
 
-# depends on libxt
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
            gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
-- 
2.10.2

✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev3)

[Patchwork]

== Series Details ==

Series: "webkitgtk: add opengl to REQUI..." and 1 more (rev3)
Revision: 3
URL   : https://patchwork.openembedded.org/series/13867/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 417245923c)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH V4] webkitgtk/epiphany: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

Hi RP,

I saw you merged V3 to master-next, but I found epiphany depends
on webkitgtk, it also need to add opengl to REQUIRED_DISTRO_FEATURES

Please use V4 to replace

I test it with `bitbake world -n' without `opengl' in DISTRO_FEATURES

Sorry for so many revision, thanks for patchtest, mention
me to correct the error I introduced.

//Hongxu

On 2018年10月10日 15:16, Hongxu Jia wrote:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>
> Some sort of GL is needed yes. We indicate that with opengl loosely in OE
>
> The epiphany depends on webkitgtk, add opengl to REQUIRED_DISTRO_FEATURES also.
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb | 2 +-
>   meta/recipes-sato/webkit/webkitgtk_2.20.5.bb     | 3 +--
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb b/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
> index 8837b9c..b46c9d3 100644
> --- a/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
> +++ b/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
> @@ -8,7 +8,7 @@ DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes avahi libnotify gcr \
>   
>   GNOMEBASEBUILDCLASS = "meson"
>   inherit gnomebase gsettings distro_features_check upstream-version-is-even gettext
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>   
>   SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \
>              file://0002-help-meson.build-disable-the-use-of-yelp.patch \
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> index c8d4f94..7f1ffce 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> @@ -30,8 +30,7 @@ SRC_URI[sha256sum] = "15c0f8d26e9605afe0948d161ba5fd82efee8eda2debd409fd40a440ac
>   
>   inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>   
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>   
>   DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>              gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \

[PATCH V4] webkitgtk/epiphany: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

They can't be built without opengl in DISTRO_FEATURES.
[snip]
|webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
fatal error: GL/gl.h: No such file or directory
[snip]

Some sort of GL is needed yes. We indicate that with opengl loosely in OE

The epiphany depends on webkitgtk, add opengl to REQUIRED_DISTRO_FEATURES also.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb | 2 +-
 meta/recipes-sato/webkit/webkitgtk_2.20.5.bb     | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb b/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
index 8837b9c..b46c9d3 100644
--- a/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
+++ b/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
@@ -8,7 +8,7 @@ DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes avahi libnotify gcr \
 
 GNOMEBASEBUILDCLASS = "meson"
 inherit gnomebase gsettings distro_features_check upstream-version-is-even gettext
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \
            file://0002-help-meson.build-disable-the-use-of-yelp.patch \
diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
index c8d4f94..7f1ffce 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
@@ -30,8 +30,7 @@ SRC_URI[sha256sum] = "15c0f8d26e9605afe0948d161ba5fd82efee8eda2debd409fd40a440ac
 
 inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
 
-# depends on libxt
-REQUIRED_DISTRO_FEATURES = "x11"
+REQUIRED_DISTRO_FEATURES = "x11 opengl"
 
 DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
            gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
-- 
2.7.4

✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev4)

[Patchwork]

== Series Details ==

Series: "webkitgtk: add opengl to REQUI..." and 1 more (rev4)
Revision: 4
URL   : https://patchwork.openembedded.org/series/13867/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 417245923c)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe