Re: [dpdk-dev] [PATCH v1 01/20] net/txgbe: add ethdev probe and remove for VF device

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/22/2021 9:47 AM, Jiawen Wu wrote:
> Introduce virtual function driver in txgbe PMD,
> add simple init and uninit function to probe and remove the device.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

<...>

> @@ -0,0 +1,12 @@
> +;
> +; Supported features of the 'txgbe_vf' network poll mode driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +Multiprocess aware   = Y
> +Linux UIO            = Y
> +Linux VFIO           = Y

The OS name changed, can you please rebase this on top of latest repo?

<...>

> @@ -0,0 +1,137 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2015-2020
> + */
> +
> +#include <sys/queue.h>
> +#include <stdio.h>
> +#include <errno.h>
> +#include <stdint.h>
> +#include <string.h>
> +#include <rte_log.h>
> +#include <rte_ethdev_pci.h>

This header file is renamed, it is 'ethdev_pci.h' now, can you please rebase?

> +
> +#include "txgbe_logs.h"
> +#include "base/txgbe.h"
> +#include "txgbe_ethdev.h"
> +#include "txgbe_rxtx.h"

Can you pleae remove unsued headers and add them as they needed?

> +
> +#define TXGBEVF_PMD_NAME "rte_txgbevf_pmd" /* PMD name */

Is this macro used? And not sure if the comment is useful for this case.

<...>

> +
> +/* Virtual Function device uninit */
> +

Can you please remove the empty line, and other comments are in different 
format, better to align them.