From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH] meson.build: don't include libbpf in the common source set
Date: Tue, 5 Oct 2021 21:00:42 +0200 [thread overview]
Message-ID: <2f0c158c-9f1e-0ab6-168d-24ec033931fd@redhat.com> (raw)
In-Reply-To: <20211005182443.2954499-1-alex.bennee@linaro.org>
On 10/5/21 20:24, Alex Bennée wrote:
> This library is only needed for the softmmu targets and as such
> break static *-user builds where libbpf is detected and it tries to
> link it into the user binaries.
>
> Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.")
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 60f4f45165..d8bcf13b21 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2307,7 +2307,7 @@ subdir('bsd-user')
> subdir('linux-user')
> subdir('ebpf')
>
> -common_ss.add(libbpf)
> +softmmu_ss.add(libbpf)
>
> bsd_user_ss.add(files('gdbstub.c'))
> specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
>
Patch already pending on the list:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg834876.html
next prev parent reply other threads:[~2021-10-05 19:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 18:24 [RFC PATCH] meson.build: don't include libbpf in the common source set Alex Bennée
2021-10-05 18:51 ` Richard Henderson
2021-10-05 19:00 ` Philippe Mathieu-Daudé [this message]
2021-10-05 19:28 ` Paolo Bonzini
2021-10-05 19:27 ` Paolo Bonzini
2021-10-05 20:25 ` Richard Henderson
2021-10-05 22:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0c158c-9f1e-0ab6-168d-24ec033931fd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.