From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Thu, 30 Jun 2016 10:10:02 +0800 Message-ID: <2f0e60e1-f429-2bd3-5f26-fd6199e64f34@linaro.org> References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> <5351858.jEb0qfTvrF@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pf0-f182.google.com ([209.85.192.182]:33893 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbcF3CKP (ORCPT ); Wed, 29 Jun 2016 22:10:15 -0400 Received: by mail-pf0-f182.google.com with SMTP id h14so23889573pfe.1 for ; Wed, 29 Jun 2016 19:10:14 -0700 (PDT) In-Reply-To: <5351858.jEb0qfTvrF@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" , Fu Wei , Catalin Marinas , Will Deacon Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Suravee Suthikulanit , Leo Duran Hi Rafael, On 2016/6/30 9:37, Rafael J. Wysocki wrote: > On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: >> Hi Rafael, >> >> On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: >>> On Wed, Jun 29, 2016 at 8:15 PM, wrote: >>>> From: Fu Wei >>>> >>>> This patchset: >>>> (1)Preparation for adding GTDT support in arm_arch_timer >>>> 1. Move some enums and marcos to header file >>>> 2. Add a new enum for spi type. >>>> 3. Improve printk relevant code >>>> >>>> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >>>> Parse all kinds of timer in GTDT table of ACPI:arch timer, >>>> memory-mapped timer and SBSA Generic Watchdog timer. >>>> This driver can help to simplify all the relevant timer drivers, >>>> and separate all the ACPI GTDT knowledge from them. >>>> >>>> (3)Simplify ACPI code for arm_arch_timer >>>> >>>> (4)Add GTDT support for ARM memory-mapped timer >>> >>> GTDT is ARM-specific AFAICS. >> >> yes, you are right, it is. >> >>> >>> If so, why do we need that code to reside in drivers/acpi/ ? >> >> Although the GTDT is just for ARM64, but this driver is parsing one >> of ACPI table, >> I think that could be treated as ACPI driver. Do I miss something? :-) > > Yes, you are. Nobody except for ARM64 will ever need it. GTDT is part of ACPI spec, drivers/acpi/ is for driver code of ACPI spec, I think it can stay in drivers/acpi/ from this point of view, am I right? Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbcF3CKS (ORCPT ); Wed, 29 Jun 2016 22:10:18 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36344 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcF3CKP (ORCPT ); Wed, 29 Jun 2016 22:10:15 -0400 Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer To: "Rafael J. Wysocki" , Fu Wei , Catalin Marinas , Will Deacon References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> <5351858.jEb0qfTvrF@vostro.rjw.lan> Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Suravee Suthikulanit , Leo Duran From: Hanjun Guo Message-ID: <2f0e60e1-f429-2bd3-5f26-fd6199e64f34@linaro.org> Date: Thu, 30 Jun 2016 10:10:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <5351858.jEb0qfTvrF@vostro.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 2016/6/30 9:37, Rafael J. Wysocki wrote: > On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: >> Hi Rafael, >> >> On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: >>> On Wed, Jun 29, 2016 at 8:15 PM, wrote: >>>> From: Fu Wei >>>> >>>> This patchset: >>>> (1)Preparation for adding GTDT support in arm_arch_timer >>>> 1. Move some enums and marcos to header file >>>> 2. Add a new enum for spi type. >>>> 3. Improve printk relevant code >>>> >>>> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >>>> Parse all kinds of timer in GTDT table of ACPI:arch timer, >>>> memory-mapped timer and SBSA Generic Watchdog timer. >>>> This driver can help to simplify all the relevant timer drivers, >>>> and separate all the ACPI GTDT knowledge from them. >>>> >>>> (3)Simplify ACPI code for arm_arch_timer >>>> >>>> (4)Add GTDT support for ARM memory-mapped timer >>> >>> GTDT is ARM-specific AFAICS. >> >> yes, you are right, it is. >> >>> >>> If so, why do we need that code to reside in drivers/acpi/ ? >> >> Although the GTDT is just for ARM64, but this driver is parsing one >> of ACPI table, >> I think that could be treated as ACPI driver. Do I miss something? :-) > > Yes, you are. Nobody except for ARM64 will ever need it. GTDT is part of ACPI spec, drivers/acpi/ is for driver code of ACPI spec, I think it can stay in drivers/acpi/ from this point of view, am I right? Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Thu, 30 Jun 2016 10:10:02 +0800 Subject: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer In-Reply-To: <5351858.jEb0qfTvrF@vostro.rjw.lan> References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> <5351858.jEb0qfTvrF@vostro.rjw.lan> Message-ID: <2f0e60e1-f429-2bd3-5f26-fd6199e64f34@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rafael, On 2016/6/30 9:37, Rafael J. Wysocki wrote: > On Thursday, June 30, 2016 09:29:59 AM Fu Wei wrote: >> Hi Rafael, >> >> On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: >>> On Wed, Jun 29, 2016 at 8:15 PM, wrote: >>>> From: Fu Wei >>>> >>>> This patchset: >>>> (1)Preparation for adding GTDT support in arm_arch_timer >>>> 1. Move some enums and marcos to header file >>>> 2. Add a new enum for spi type. >>>> 3. Improve printk relevant code >>>> >>>> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >>>> Parse all kinds of timer in GTDT table of ACPI:arch timer, >>>> memory-mapped timer and SBSA Generic Watchdog timer. >>>> This driver can help to simplify all the relevant timer drivers, >>>> and separate all the ACPI GTDT knowledge from them. >>>> >>>> (3)Simplify ACPI code for arm_arch_timer >>>> >>>> (4)Add GTDT support for ARM memory-mapped timer >>> >>> GTDT is ARM-specific AFAICS. >> >> yes, you are right, it is. >> >>> >>> If so, why do we need that code to reside in drivers/acpi/ ? >> >> Although the GTDT is just for ARM64, but this driver is parsing one >> of ACPI table, >> I think that could be treated as ACPI driver. Do I miss something? :-) > > Yes, you are. Nobody except for ARM64 will ever need it. GTDT is part of ACPI spec, drivers/acpi/ is for driver code of ACPI spec, I think it can stay in drivers/acpi/ from this point of view, am I right? Thanks Hanjun