From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C20BC433EF for ; Tue, 14 Dec 2021 14:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235118AbhLNO7m (ORCPT ); Tue, 14 Dec 2021 09:59:42 -0500 Received: from foss.arm.com ([217.140.110.172]:58140 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232616AbhLNO7m (ORCPT ); Tue, 14 Dec 2021 09:59:42 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26983D6E; Tue, 14 Dec 2021 06:59:42 -0800 (PST) Received: from [10.57.34.58] (unknown [10.57.34.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51A4F3F774; Tue, 14 Dec 2021 06:59:40 -0800 (PST) Message-ID: <2f100de5-c3de-e70e-9869-ba1942f686c8@arm.com> Date: Tue, 14 Dec 2021 14:59:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2 5/5] dt-bindings: perf: Add compatible for Arm DSU-110 Content-Language: en-GB To: Suzuki K Poulose , will@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: catalin.marinas@arm.com, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <51a8060493e1220886dcd468fad9a2b603607297.1639490264.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-12-14 14:42, Suzuki K Poulose wrote: > On 14/12/2021 14:16, Robin Murphy wrote: >> DSU-110 is the newest and shiniest for Armv9. Its programmer's model is >> largely identical to the previous generation of DSUs, so we can treat it >> as compatible, but it does have a a handful of extra IMP-DEF PMU events >> to call its own. Thanks to the new notion of core complexes, the maximum >> number of supported CPUs goes up as well. >> >> Signed-off-by: Robin Murphy >> --- >> >> v2: Also make it complete and valid >> >>   Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml | 8 ++++++-- >>   1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> index 09ddeb6a3ccc..7f31bcecedb5 100644 >> --- a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> +++ b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> @@ -21,7 +21,11 @@ description: >>   properties: >>     compatible: >> -    const: arm,dsu-pmu >> +    oneOf: >> +      - const: arm,dsu-pmu >> +      - items: >> +          - const: arm,dsu-110-pmu >> +          - const: arm,dsu-pmu > > Couldn't this be : > >     compatible: >       oneOf: >         - const: arm,dsu-110-pmu >         - const: arm,dsu-pmu > > Otherwise, looks good to me. My intent here was for the new case to use both strings and thus still permit a less-specific match to the original one (hence why there's no change to the actual driver included here). It's a true "compatible" in the sense that you can run the thing with the existing driver as if it's a 1st-gen DSU and get the expected results - at least that's the conclusion I drew from a side-by-side comparison of the TRMs, and the folks testing FPGAs haven't complained since I told them to try it months ago :) Thanks, Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36726C433EF for ; Tue, 14 Dec 2021 15:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BurczM7oYXZc/IFp9xMyshrEry4Xv/7vrEqcptxrawk=; b=HiDmKmscK/s30T rV6H1PAQlX3uXKsRWnmyvfhs0kgXtxmCAY7H1BxtZ12VlSQZyn5PspZUw/2PiMZBdRd1p+wuuwWas zXdQ/aAcrJyoUMNSuOKvNOIkMLyujSQZRFwuBOt1m3ZrIfSDRoif1Ng+Vj+eGPRMSGi7fRMvQpuXh wsGlkpLvjxFKg987iIWmtIBFbNnd+/i8QLzQNVtmeJg2AAikk/SgZonyJI6w01KqWhzZGqO8TdcZ0 msI0VsI13A95pX6oGBK5GVB0tm3c5+J/WNffktO5UulpH0LtDoL/Ut8r2I0KkWx8trP6MbpwoU26P tbdcj7PO7MULaYzGpz3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9HP-00EYEE-0o; Tue, 14 Dec 2021 14:59:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9HL-00EYDH-6n for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 14:59:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26983D6E; Tue, 14 Dec 2021 06:59:42 -0800 (PST) Received: from [10.57.34.58] (unknown [10.57.34.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51A4F3F774; Tue, 14 Dec 2021 06:59:40 -0800 (PST) Message-ID: <2f100de5-c3de-e70e-9869-ba1942f686c8@arm.com> Date: Tue, 14 Dec 2021 14:59:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2 5/5] dt-bindings: perf: Add compatible for Arm DSU-110 Content-Language: en-GB To: Suzuki K Poulose , will@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: catalin.marinas@arm.com, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <51a8060493e1220886dcd468fad9a2b603607297.1639490264.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_065943_315480_7DC17324 X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0xMi0xNCAxNDo0MiwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPiBPbiAxNC8xMi8y MDIxIDE0OjE2LCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4+IERTVS0xMTAgaXMgdGhlIG5ld2VzdCBh bmQgc2hpbmllc3QgZm9yIEFybXY5LiBJdHMgcHJvZ3JhbW1lcidzIG1vZGVsIGlzCj4+IGxhcmdl bHkgaWRlbnRpY2FsIHRvIHRoZSBwcmV2aW91cyBnZW5lcmF0aW9uIG9mIERTVXMsIHNvIHdlIGNh biB0cmVhdCBpdAo+PiBhcyBjb21wYXRpYmxlLCBidXQgaXQgZG9lcyBoYXZlIGEgYSBoYW5kZnVs IG9mIGV4dHJhIElNUC1ERUYgUE1VIGV2ZW50cwo+PiB0byBjYWxsIGl0cyBvd24uIFRoYW5rcyB0 byB0aGUgbmV3IG5vdGlvbiBvZiBjb3JlIGNvbXBsZXhlcywgdGhlIG1heGltdW0KPj4gbnVtYmVy IG9mIHN1cHBvcnRlZCBDUFVzIGdvZXMgdXAgYXMgd2VsbC4KPj4KPj4gU2lnbmVkLW9mZi1ieTog Um9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4KPj4gLS0tCj4+Cj4+IHYyOiBBbHNv IG1ha2UgaXQgY29tcGxldGUgYW5kIHZhbGlkCj4+Cj4+IMKgIERvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9wZXJmL2FybSxkc3UtcG11LnlhbWwgfCA4ICsrKysrKy0tCj4+IMKgIDEg ZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYg LS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGVyZi9hcm0sZHN1LXBt dS55YW1sIAo+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wZXJmL2FybSxk c3UtcG11LnlhbWwKPj4gaW5kZXggMDlkZGViNmEzY2NjLi43ZjMxYmNlY2VkYjUgMTAwNjQ0Cj4+ IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wZXJmL2FybSxkc3UtcG11 LnlhbWwKPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BlcmYvYXJt LGRzdS1wbXUueWFtbAo+PiBAQCAtMjEsNyArMjEsMTEgQEAgZGVzY3JpcHRpb246Cj4+IMKgIHBy b3BlcnRpZXM6Cj4+IMKgwqDCoCBjb21wYXRpYmxlOgo+PiAtwqDCoMKgIGNvbnN0OiBhcm0sZHN1 LXBtdQo+PiArwqDCoMKgIG9uZU9mOgo+PiArwqDCoMKgwqDCoCAtIGNvbnN0OiBhcm0sZHN1LXBt dQo+PiArwqDCoMKgwqDCoCAtIGl0ZW1zOgo+PiArwqDCoMKgwqDCoMKgwqDCoMKgIC0gY29uc3Q6 IGFybSxkc3UtMTEwLXBtdQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgIC0gY29uc3Q6IGFybSxkc3Ut cG11Cj4gCj4gQ291bGRuJ3QgdGhpcyBiZSA6Cj4gCj4gIMKgwqDCoMKgY29tcGF0aWJsZToKPiAg wqDCoMKgwqDCoCBvbmVPZjoKPiAgwqDCoMKgwqDCoMKgwqAgLSBjb25zdDogYXJtLGRzdS0xMTAt cG11Cj4gIMKgwqDCoMKgwqDCoMKgIC0gY29uc3Q6IGFybSxkc3UtcG11Cj4gCj4gT3RoZXJ3aXNl LCBsb29rcyBnb29kIHRvIG1lLgoKTXkgaW50ZW50IGhlcmUgd2FzIGZvciB0aGUgbmV3IGNhc2Ug dG8gdXNlIGJvdGggc3RyaW5ncyBhbmQgdGh1cyBzdGlsbCAKcGVybWl0IGEgbGVzcy1zcGVjaWZp YyBtYXRjaCB0byB0aGUgb3JpZ2luYWwgb25lIChoZW5jZSB3aHkgdGhlcmUncyBubyAKY2hhbmdl IHRvIHRoZSBhY3R1YWwgZHJpdmVyIGluY2x1ZGVkIGhlcmUpLiBJdCdzIGEgdHJ1ZSAiY29tcGF0 aWJsZSIgaW4gCnRoZSBzZW5zZSB0aGF0IHlvdSBjYW4gcnVuIHRoZSB0aGluZyB3aXRoIHRoZSBl eGlzdGluZyBkcml2ZXIgYXMgaWYgaXQncyAKYSAxc3QtZ2VuIERTVSBhbmQgZ2V0IHRoZSBleHBl Y3RlZCByZXN1bHRzIC0gYXQgbGVhc3QgdGhhdCdzIHRoZSAKY29uY2x1c2lvbiBJIGRyZXcgZnJv bSBhIHNpZGUtYnktc2lkZSBjb21wYXJpc29uIG9mIHRoZSBUUk1zLCBhbmQgdGhlIApmb2xrcyB0 ZXN0aW5nIEZQR0FzIGhhdmVuJ3QgY29tcGxhaW5lZCBzaW5jZSBJIHRvbGQgdGhlbSB0byB0cnkg aXQgCm1vbnRocyBhZ28gOikKClRoYW5rcywKUm9iaW4uCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==