Re: [PATCH v2 1/3] pinctrl: amd: Define and use PINCTRL_GRP

From: Basavaraj Natikar <bnatikar@amd.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] pinctrl: amd: Define and use PINCTRL_GRP
Date: Thu, 26 May 2022 11:57:09 +0530	[thread overview]
Message-ID: <2f1df198-36e8-36f4-4474-618013db73ca@amd.com> (raw)
In-Reply-To: <CACRpkdYQ1++WQEFa7tUAX3_B=-fb43UEU6AXyYgHZJhH73DQWw@mail.gmail.com>

On 5/25/2022 11:35 AM, Linus Walleij wrote:

> On Tue, May 24, 2022 at 4:39 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Tue, May 24, 2022 at 10:13 AM Basavaraj Natikar
>> <Basavaraj.Natikar@amd.com> wrote:
>>> AMD pingroup can be extended to support multi-function pins.
>>> Hence define and use PINCTRL_GRP to manage and represent
>>> larger number of pingroups inline.
>> This is good idea, but please make it available for all pin control
>> drivers, since the data structure like
>>
>>   pingroup {
>>     *name;
>>     *pins;
>>     npins;
>>   }
>>
>> is used in many drivers.
>>
>> That said, I think the AMD_ prefix will be misleading in this case.
> Aha you mean like a utility macro? That's useful, don't know where to put it
> though, include/linux/pinctrl/pinmux.h?

For me looks like we need to put this in include/linux/pinctrl/pinctrl.h for 
a generic usage. is this fine?

> Yours,
> Linus Walleij