All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/5] usb-hub: tweak feature names
Date: Fri, 24 May 2019 09:45:29 +0200	[thread overview]
Message-ID: <2f2c6a90-a0b0-9334-6233-e10be14381bf@redhat.com> (raw)
In-Reply-To: <20190524070310.4952-2-kraxel@redhat.com>

On 5/24/19 9:03 AM, Gerd Hoffmann wrote:
> Add dashes, so they don't look like two separate things when printed.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/dev-hub.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c
> index 7e9339b8a83d..9b04b6a6ec2d 100644
> --- a/hw/usb/dev-hub.c
> +++ b/hw/usb/dev-hub.c
> @@ -287,11 +287,11 @@ static const char *feature_name(int feature)
>          [PORT_POWER]         = "power",
>          [PORT_LOWSPEED]      = "lowspeed",
>          [PORT_HIGHSPEED]     = "highspeed",
> -        [PORT_C_CONNECTION]  = "change connection",
> -        [PORT_C_ENABLE]      = "change enable",
> -        [PORT_C_SUSPEND]     = "change suspend",
> -        [PORT_C_OVERCURRENT] = "change overcurrent",
> -        [PORT_C_RESET]       = "change reset",
> +        [PORT_C_CONNECTION]  = "change-connection",
> +        [PORT_C_ENABLE]      = "change-enable",
> +        [PORT_C_SUSPEND]     = "change-suspend",
> +        [PORT_C_OVERCURRENT] = "change-overcurrent",
> +        [PORT_C_RESET]       = "change-reset",
>          [PORT_TEST]          = "test",
>          [PORT_INDICATOR]     = "indicator",
>      };
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  reply	other threads:[~2019-05-24  7:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  7:03 [Qemu-devel] [PATCH v2 0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation Gerd Hoffmann
2019-05-24  7:03 ` [Qemu-devel] [PATCH v2 1/5] usb-hub: tweak feature names Gerd Hoffmann
2019-05-24  7:45   ` Philippe Mathieu-Daudé [this message]
2019-05-24  7:03 ` [Qemu-devel] [PATCH v2 2/5] usb-hub: make number of ports runtime-configurable Gerd Hoffmann
2019-05-24  7:03 ` [Qemu-devel] [PATCH v2 3/5] usb-hub: add helpers to update port state Gerd Hoffmann
2019-05-24  7:03 ` [Qemu-devel] [PATCH v2 4/5] usb-hub: add usb_hub_port_update() Gerd Hoffmann
2019-05-24  7:45   ` Philippe Mathieu-Daudé
2019-05-24  7:03 ` [Qemu-devel] [PATCH v2 5/5] usb-hub: emulate per port power switching Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f2c6a90-a0b0-9334-6233-e10be14381bf@redhat.com \
    --to=philmd@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.