From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940157AbdEZJxF (ORCPT ); Fri, 26 May 2017 05:53:05 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761002AbdEZJws (ORCPT ); Fri, 26 May 2017 05:52:48 -0400 Subject: Re: [PATCH] ubifs: Add freeze support To: Hyunchul Lee References: <1495755004-17036-1-git-send-email-hyc.lee@gmail.com> Cc: Artem Bityutskiy , adrian.hunter@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, kernel-team@lge.com From: Richard Weinberger Message-ID: <2f3210d7-b0c3-f006-754e-ec4bae26454c@nod.at> Date: Fri, 26 May 2017 11:52:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1495755004-17036-1-git-send-email-hyc.lee@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hyunchul, Am 26.05.2017 um 01:30 schrieb Hyunchul Lee: > From: Hyunchul Lee > > for un/freeze support, implement freeze_super and un/freeze_fs > of super_operations. > ubifs_freeze_super just calls freeze_super. because freeze_super always > succeeds if file system is read-only, UBIFS errors should be checked. > if there are errors, UBIFS is switched to read-only mode. > ubifs_freeze_fs runs commit if TNC/LPT isn't clean. though all writes > are blocked and sync_fs is called before, if commit alreay was started > before writes are blocked, TNC/LPT might have dirty COW nodes. you explain how you implement that feature, but not why. What is the use-case? I always thought this interface is only being used by LVM. Thanks, //richard