From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762858AbdAKKVT (ORCPT ); Wed, 11 Jan 2017 05:21:19 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:46865 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762530AbdAKKVP (ORCPT ); Wed, 11 Jan 2017 05:21:15 -0500 X-AuditID: b6c32a3c-f79826d000002380-f0-5876000c84a9 Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board To: Andrzej Hajda , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, inki.dae@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Hyungwon Hwang , Hoegeun Kwon From: hoegeun kwon Message-id: <2f362dda-6c57-6aa4-5572-b27c34c4c78e@samsung.com> Date: Wed, 11 Jan 2017 18:51:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFJsWRmVeSWpSXmKPExsWy7bCmri4PQ1mEQcthC4tb686xWvSeO8lk sf3IM1aL61+es1rMPwIUu/L1PZvF++VdbBZLZ/SxWky6P4HF4savNlaL/sevmS3On9/AbnF5 1xw2ixnn9zFZ/N+zg93i5655LA4CHjtn3WX32LSqk81j+7cHrB73u48zefRtWcXo8XmTXABb VKpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtDhSgpl iTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDQyM9QwNzPSMjIz0T41grI1OgkoTUjKnTdAtO 8VXs37yKuYGxgaeLkYNDQsBEYkdbZBcjJ5ApJnHh3nq2LkYuDiGBHYwSe+//ZYJw2pkkHt6c xg5RZSLR9fQTE4gtJLCcUWJ6vyxE0V1Gic67i5hBEsICyRJX23tZQBIiAp2MEtdePmYEcZgF djBJtBx/CTaKTUBXYsrib2CjeAXsJJZsmwcWZxFQlWg6tRosLioQIXHo2G1miBpBiR+T77GA 2JwC9hL3Nj9kA7GZBRwlHizayQphy0tsXvOWGWSZhMBXdokb0xaxQzwqK7HpADPECy4SS6fd YYWwhSVeHd8C9Zq0xKp/t5ggersZJb43rYAaNIFR4mfDBqhuY4n7D+4xQ2zjk3j3tYcVYgGv REebEESJh8TMwxdZIMKOwADWhQRRH5PE76u9zBMY5Wch+WcWkh9mIflhASPzKkax1ILi3PTU YsMCC73ixNzi0rx0veT83E2M4HSrZbOD8dI5n0OMAhyMSjy8E96WRAixJpYVV+YeYpTgYFYS 4W39WxohxJuSWFmVWpQfX1Sak1p8iNEUGMYTmaVEk/OBuSCvJN7QxMzQxMjE0NDcyMBISZx3 WaN1hJBAemJJanZqakFqEUwfEwenVANjX6XY9awrbYniD1bfL2d9c33GxjUvDB98EeN8Ulsg FBaYauhzpIQ7T/rVg3PvV+n5n01tD3V4ni3w8eJ5I8cJtoeWb2NcmOsjddnKeWd7MhOv9bsJ +4rXpX58tWbetkuM1RsOf7W3PRiUM+XR6zedyr4rBXpUuO/E/fk2KYbNaoWJ66EzX+yMlFiK MxINtZiLihMBlIkG680DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t9jAV0ehrIIg55uZYtb686xWvSeO8lk sf3IM1aL61+es1rMPwIUu/L1PZvF++VdbBZLZ/SxWky6P4HF4savNlaL/sevmS3On9/AbnF5 1xw2ixnn9zFZ/N+zg93i5655LA4CHjtn3WX32LSqk81j+7cHrB73u48zefRtWcXo8XmTXABb lJtNRmpiSmqRQmpecn5KZl66rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yD lfTtEtwypk7TLTjFV7F/8yrmBsYGni5GTg4JAROJrqefmCBsMYkL99azdTFycQgJLGWUaP35 jAXCuc8ocfLTKVaQKmGBZImj6+aDJUQEOhklOn4sZQdJCAn0MUmsPCoCkmAW2MEksffPEjaQ BJuArsSUxd/AdvAK2Eks2TYPrIFFQFWi6dRqoDgHh6hAhETD4XSIEkGJH5PvsYDYnAL2Evc2 PwQbwyxgK7Hg/ToWCFteYvOat8wTGAVmIWmZhaRsFpKyBYzMqxglUguSC4qT0nMN81LL9YoT c4tL89L1kvNzNzGCI/mZ1A7Gg7vcDzEKcDAq8fA+eFESIcSaWFZcmXuIUYKDWUmEt/VvaYQQ b0piZVVqUX58UWlOavEhRlOgPyYyS4km5wOTTF5JvKGJuYm5sYGFuaWliZGSOG/j7GfhQgLp iSWp2ampBalFMH1MHJxSDYwVmx5k1ss9PfWbU0b5zm7haZzdjqk18a+mLVIzuSHg2SKcsCtN POf67cstC6b3nFm9Ia1XTmbi/qOx8q/tKuxV1uo+c2UP3fv49Zyepcu4Fka4zJ3xpPRXU3GR gogGz0He23nz5neLiOl+fbPxcVjej++Cbnzih7LP8+QGNIgYF5nVOvlWByuxFGckGmoxFxUn AgAzrThe+gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111095108epcas1p4e557cb86a8fc5ccbfb50bbfa8c2863a8 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzMo7IKs7JuQKS/sgqzsm5A=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTMy9Bc3Npc3RhbnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 X-RootMTR: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 04:46 PM, Andrzej Hajda wrote: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Hoegeun Kwon >> Tested-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index ddba2f8..6d362f9 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -18,6 +18,18 @@ >> compatible = "samsung,tm2", "samsung,exynos5433"; >> }; >> >> +&dsi { >> + panel@0 { >> + compatible = "samsung,s6e3ha2"; >> + reg = <0>; >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > The same here (as in 1st comment) , te-gpios should be dropper - decon > uses hw-trigger. Hi Andrzej, Thanks for your quick review. Reasonable to remove te-gpios property, The Tizen public already has [1] your patch applied and te-gpios removed. So I will add [1] to the V9 patch. [1] https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900 Best Regards, Hoegeun > > Regards > Andrzej >> + }; >> +}; >> + >> &hsi2c_9 { >> status = "okay"; >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: hoegeun kwon Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Date: Wed, 11 Jan 2017 18:51:12 +0900 Message-ID: <2f362dda-6c57-6aa4-5572-b27c34c4c78e@samsung.com> References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Hyungwon Hwang , Hoegeun Kwon List-Id: devicetree@vger.kernel.org CgpPbiAwMS8xMS8yMDE3IDA0OjQ2IFBNLCBBbmRyemVqIEhhamRhIHdyb3RlOgo+IE9uIDExLjAx LjIwMTcgMDc6MzMsIEhvZWdldW4gS3dvbiB3cm90ZToKPj4gRnJvbTogSHl1bmd3b24gSHdhbmcg PGh1bWFuLmh3YW5nQHNhbXN1bmcuY29tPgo+Pgo+PiBUaGlzIHBhdGNoIGFkZCB0aGUgcGFuZWwg ZGV2aWNlIHRyZWUgbm9kZSBmb3IgUzZFM0hBMiBkaXNwbGF5Cj4+IGNvbnRyb2xsZXIgdG8gVE0y IGR0cy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSHl1bmd3b24gSHdhbmcgPGh1bWFuLmh3YW5nQHNh bXN1bmcuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1 bmcuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBDaGFud29vIENob2kgPGN3MDAuY2hvaUBzYW1zdW5n LmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogSG9lZ2V1biBLd29uIDxob2VnZXVuLmt3b25Ac2Ftc3Vu Zy5jb20+Cj4+IFRlc3RlZC1ieTogQ2hhbndvbyBDaG9pIDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+ Cj4+IC0tLQo+PiAgIGFyY2gvYXJtNjQvYm9vdC9kdHMvZXh5bm9zL2V4eW5vczU0MzMtdG0yLmR0 cyB8IDEyICsrKysrKysrKysrKwo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCsp Cj4+Cj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2V4eW5vcy9leHlub3M1NDMz LXRtMi5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2V4eW5vcy9leHlub3M1NDMzLXRtMi5kdHMK Pj4gaW5kZXggZGRiYTJmOC4uNmQzNjJmOSAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9ib290 L2R0cy9leHlub3MvZXh5bm9zNTQzMy10bTIuZHRzCj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvZXh5bm9zL2V4eW5vczU0MzMtdG0yLmR0cwo+PiBAQCAtMTgsNiArMTgsMTggQEAKPj4gICAJ Y29tcGF0aWJsZSA9ICJzYW1zdW5nLHRtMiIsICJzYW1zdW5nLGV4eW5vczU0MzMiOwo+PiAgIH07 Cj4+ICAgCj4+ICsmZHNpIHsKPj4gKwlwYW5lbEAwIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJzYW1z dW5nLHM2ZTNoYTIiOwo+PiArCQlyZWcgPSA8MD47Cj4+ICsJCXZkZDMtc3VwcGx5ID0gPCZsZG8y N19yZWc+Owo+PiArCQl2Y2ktc3VwcGx5ID0gPCZsZG8yOF9yZWc+Owo+PiArCQlyZXNldC1ncGlv cyA9IDwmZ3BnMCAwIEdQSU9fQUNUSVZFX0xPVz47Cj4+ICsJCWVuYWJsZS1ncGlvcyA9IDwmZ3Bm MSA1IEdQSU9fQUNUSVZFX0hJR0g+Owo+PiArCQl0ZS1ncGlvcyA9IDwmZ3BmMSAzIEdQSU9fQUNU SVZFX0hJR0g+Owo+IFRoZSBzYW1lIGhlcmUgKGFzIGluIDFzdCBjb21tZW50KSAsIHRlLWdwaW9z IHNob3VsZCBiZSBkcm9wcGVyIC0gZGVjb24KPiB1c2VzIGh3LXRyaWdnZXIuCgpIaSBBbmRyemVq LAoKVGhhbmtzIGZvciB5b3VyIHF1aWNrIHJldmlldy4KClJlYXNvbmFibGUgdG8gcmVtb3ZlIHRl LWdwaW9zIHByb3BlcnR5LApUaGUgVGl6ZW4gcHVibGljIGFscmVhZHkgaGFzIFsxXSB5b3VyIHBh dGNoIGFwcGxpZWQgYW5kIHRlLWdwaW9zIHJlbW92ZWQuClNvIEkgd2lsbCBhZGQgWzFdIHRvIHRo ZSBWOSBwYXRjaC4KClsxXSAKaHR0cHM6Ly9yZXZpZXcudGl6ZW4ub3JnL2dlcnJpdC9naXR3ZWI/ cD1wbGF0Zm9ybS9rZXJuZWwvbGludXgtZXh5bm9zLmdpdDthPWNvbW1pdGRpZmY7aD00Njg3Njli ZjZhYmJhYWVkMjU0N2I4YzQzZTk4OWFiNWRjNzg3OTAwCgpCZXN0IFJlZ2FyZHMsCkhvZWdldW4K Cj4KPiBSZWdhcmRzCj4gQW5kcnplago+PiArCX07Cj4+ICt9Owo+PiArCj4+ICAgJmhzaTJjXzkg ewo+PiAgIAlzdGF0dXMgPSAib2theSI7Cj4+ICAgCj4KPgo+CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK