From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9190C433EF for ; Thu, 23 Dec 2021 10:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347810AbhLWK7X (ORCPT ); Thu, 23 Dec 2021 05:59:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239583AbhLWK7W (ORCPT ); Thu, 23 Dec 2021 05:59:22 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0186AC061401 for ; Thu, 23 Dec 2021 02:59:22 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id m12so8452431ljj.6 for ; Thu, 23 Dec 2021 02:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c4iGsoh91KxrBrGqNFTJPQDy9ooHu40v3iiRctF/iBc=; b=EBJc5nrK6p9j6veHdYAAn3scocsoVPD7XdVbJoxP1ulH2p7QyiOSCXbT2xZe8LSVTV eWmj+4Y/y60m/gKXpQNTf8bad6tstfny3dEgun071F8N0Mfmka+sJ+HaBCSOPeifbZak CtWe93t0S4TzF9yByovOrLtGFV/ONI8vREtX1ENZv/tOKJ3BKIupOTolTB2Na37easpO 9ht+6aDNfbUGeA83KmfB1tXduOx0LfqzRSUb9Dg69a3RvbHOmeba9K2eVzcj2QpdakZM LJeBgFb9zaX/zk6FA2Is4luDkTzddWQAMqcKJBAHcPv2oxt0oAD9tcCyW2M5Z8R6OeXz pJUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c4iGsoh91KxrBrGqNFTJPQDy9ooHu40v3iiRctF/iBc=; b=phkNRqxHqBABV197OTUIZrSWj4Dnp6AOHmktA5qitZGDPPIBMwLsasnQ979jlZqeyX 3ztyRqQmlbuhgy69VdmODCL6wlbbOiPtJqAkodamS/xO/7cRi6OT7N3FlprztkigUtBr AQKWc087E7GNtiDcLI/8C35mxhvr+EEXgi9gKN35x+rNaw/UFhtPQaB/7qgysIXPD8A2 imZ2/mUxqM5lE7pmUa7p61kMEzo1IkPvBzemqW2TUsrWcCkoWOeDeTgOWZsfFBfitxEm J/RsUgKbAXV17AWGXB2gHntBdqKXh3e2KU0OFJZ2fEyhHFpTkcGOeokgY62tPxeYGto1 kXgA== X-Gm-Message-State: AOAM530joy4gzdyLw8soWZdkrb9YM+U1TVJKFDvxtx8rbcyvPlD6eSXz nbAcwPDwysBnsvFjcafm7YzlIw== X-Google-Smtp-Source: ABdhPJzrM6Yg+3CEQag1QkRcx4LReAIp1OuWGROh3rLAvg9Pdp7MIzV4ecsfH5Te3AIhQWyFEDqZTg== X-Received: by 2002:a2e:9b88:: with SMTP id z8mr1325078lji.65.1640257160267; Thu, 23 Dec 2021 02:59:20 -0800 (PST) Received: from [192.168.1.102] (88-113-46-102.elisa-laajakaista.fi. [88.113.46.102]) by smtp.gmail.com with ESMTPSA id m21sm452454ljp.66.2021.12.23.02.59.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Dec 2021 02:59:20 -0800 (PST) Subject: Re: [PATCH v3 00/19] CAMSS: Add SM8250 support To: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, robert.foss@linaro.org Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, dmitry.baryshkov@linaro.org References: <20211222003751.2461466-1-bryan.odonoghue@linaro.org> From: Vladimir Zapolskiy Message-ID: <2f3eb25d-3af9-4339-acb2-8d5b01e5881d@linaro.org> Date: Thu, 23 Dec 2021 12:59:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20211222003751.2461466-1-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12/22/21 2:37 AM, Bryan O'Donoghue wrote: > V3: > Publishing this V3 to make it a bit easier to merge > > - Adds Rob Herring's RB for the first DTS change > - Adds Robert Foss' RB for the final three patches > - Validated on latest 5.16-rc6 on rb3 and rb5 > - No functional changes to v2 > > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc6-sm8250-camss-imx577-only-v3 > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc3-sm8250-camss-imx577-only-v2 > > RESEND V2: > + Cc: devicetree@vger.kernel.org on first patch > > V2: > - Adds Tested-by Julian Grahsl as indicated. > - Fixes low-level noise checkpatch --strict > I ended up having to push defines into static inlines for this. > - Adds Reviewed-by Robert Foss. > - Adds VFE/CSID fix for sdm845 as explicit additional sdm845 specific > patch per Robert's suggestion. > > I took the time then to test out on sdm845 to ensure the new patch breaks > nothing "./cam -c 1 --capture=1 --file=capture.raw" continues to produce > expected data. > > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc1-sm8250-camss-imx577-only > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc3-sm8250-camss-imx577-only-v2 > > git diff v5.16-rc1-sm8250-camss-imx577-only..v5.16-rc3-sm8250-camss-imx577-only-v2 -- drivers/media/platform/qcom/camss > > V1/RESEND: > RESEND: git send-email --to=inux-arm-msm@vger.kernel.org -> --to=linux-arm-msm@vger.kernel.org > > This series is imported from excellent enabling work contributed by > Jonathan Marek which we have picked up in Linaro for the RB5 project. > > Link: https://patchwork.kernel.org/project/linux-arm-msm/patch/20210511180728.23781-2-jonathan@marek.ca/ > Link: https://www.qualcomm.com/products/robotics-rb5-platform > Link: https://www.96boards.org/product/qualcomm-robotics-rb5 > Link: https://www.thundercomm.com/app_en/product/1590131656070623?index=1&categoryId=category0&tabIndex=1 > > The RB5 has a slightly different sku I think to Jonathan's platform - > QRB5165 in our case with a different version of LK the relevant bootloader > for the board. > > As a result we needed to make some additional updates to the provided > patcheset, included here. > > The most notable changes are: > > - Addition of clocks. > - Addition of bandwidth settings. > - Representing the dependency on a VFE for a given CSID so that V4L > subdevs will come out of reset right when poked. > > A full tree which is bootable and capable of producing pixel data from the > imx577 main sensor is available here, with this series being a sub-set of > the necessary patches on the SoC side only. > > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=v5.16-rc1-sm8250-camss-imx577-only > > media-ctl --reset > media-ctl -v -d /dev/media0 -V '"imx412 '20-001a'":0[fmt:SRGGB10/4056x3040 field:none]' > media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]' > media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' > media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' > media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]' > media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' > > yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 > Tested-by: Vladimir Zapolskiy I've tested the series on top of v5.16-rc6 on RB5 board, image capturing from the imx577 sensor works fine, if I use the supplied rb5_defconfig. However I have to report that the camss driver is not probed successfully, if it is built-in, then there is an issue related to device link suppliers: platform ac6a000.camss: error -EPROBE_DEFER: wait for supplier camera@1a platform ac6a000.camss: Added to deferred list This could be analyzed separately. -- Best wishes, Vladimir