On 04/03/2017 06:25 AM, Daniel P. Berrange wrote: > On Mon, Mar 27, 2017 at 07:58:51AM +0200, Markus Armbruster wrote: >> = What to do for 2.9 = >> >> I propose to >> >> * drop both "auth_supported" and "password-secret" from the QAPI schema >> >> * drop "password-secret" from QemuOpts >> >> * hide "keyvalue-pairs" in QemuOpts >> >> No existing usage is affected, since all these things are new in 2.9. > > Maybe I'm mis-understanding what you're suggesting wrt QemuOpts, but > 'password-secret' with RBD is not new in 2.9.0 We updated things in the respin of this series; the actual committed version (ending in commit d1c13688) did NOT kill password-secret from QemuOpts, but merely removed it from QMP (it was the QMP portion that was attempted to be new in 2.9). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org